{"id":2229392,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229392/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20260428081403.124732-1-gaoxiang@kylinos.cn/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.1/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428081403.124732-1-gaoxiang@kylinos.cn>","date":"2026-04-28T08:14:03","name":"[v2] libio: Ignore setbuf for open_memstream [BZ #34019]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c473695d3697ef2b6164c4521c846f910625d399","submitter":{"id":92909,"url":"http://patchwork.ozlabs.org/api/1.1/people/92909/?format=json","name":"Gao Xiang","email":"gaoxiang@kylinos.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20260428081403.124732-1-gaoxiang@kylinos.cn/mbox/","series":[{"id":501788,"url":"http://patchwork.ozlabs.org/api/1.1/series/501788/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=501788","date":"2026-04-28T08:14:03","name":"[v2] libio: Ignore setbuf for open_memstream [BZ #34019]","version":2,"mbox":"http://patchwork.ozlabs.org/series/501788/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229392/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229392/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n dmarc=none (p=none dis=none) header.from=kylinos.cn","sourceware.org; spf=pass smtp.mailfrom=kylinos.cn","server2.sourceware.org;\n arc=none smtp.remote-ip=124.126.103.232"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YFp2cgTz1yHv\n\tfor ; Tue, 28 Apr 2026 18:17:34 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 499F94BA9017\n\tfor ; Tue, 28 Apr 2026 08:17:32 +0000 (GMT)","from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232])\n by sourceware.org (Postfix) with ESMTPS id 3535E4BA902B\n for ; Tue, 28 Apr 2026 08:16:16 +0000 (GMT)","from bogon [(117.61.158.201)] by mailgw.kylinos.cn\n (envelope-from )\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 1503073653; Tue, 28 Apr 2026 16:16:08 +0800"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 499F94BA9017","OpenDKIM Filter v2.11.0 sourceware.org 3535E4BA902B"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3535E4BA902B","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3535E4BA902B","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777364178; cv=none;\n b=izxbFtkASzM+x3fgUOdeLbD1zGfESgEkB3ShpANT6bAtdf93Wbt0tMMNyAZln/CrDHU2LZKJ3qAncE+HEjM+UhIxTUVm2Vc7txvbmBBWY3dGrnyOeCoENPxikNyck62EDPe5LEayrs1sCo/a+HlVrjxYpV7kZRUmwaz1jWBpuwo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777364178; c=relaxed/simple;\n bh=4o+CRUZBxiY+4wO1UMBhZdZbC/fVpxtgRfGnNJk8G6A=;\n h=From:To:Subject:Date:Message-ID:MIME-Version;\n b=VgbrNksSLDPDW3ruT/0+WTjqsLZeRTKUY1E+FV6uQxgEpq9/7FW3J/CQbVxk0m1ls+n9Dl0tVsnOcdrvvn3YPzmBMu4qHBgk3tsfLsTosJ2X6rs4dzOIjhLtFutr4s1yW6OAvvWMAvx8rPiQ0s6EIjN/AwwY7Cu5Rtgn74IxmLU=","ARC-Authentication-Results":"i=1; server2.sourceware.org","X-UUID":["826725c242da11f1aa26b74ffac11d73-20260428","826725c242da11f1aa26b74ffac11d73-20260428"],"X-CTIC-Tags":"HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B,\n HR_CTT_MISS\n HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN\n HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE\n HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME\n IP_UNTRUSTED, SRC_UNTRUSTED, IP_UNFAMILIAR, SRC_UNFAMILIAR, DN_TRUSTED\n SRC_TRUSTED, SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS\n DKIM_NOPASS, DMARC_NOPASS, UD_TRUSTED, CIE_GOOD_SPF, CIE_UNKNOWN\n GTI_FG_BS, GTI_C_CI, GTI_FG_IT, GTI_RG_INFO, GTI_C_BU\n AMN_T1, AMN_GOOD, AMN_C_TI, ABX_MISS_RDNS","X-CID-O-RULE":"Release_Ham","X-CID-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:e16d4aca-2451-4c4d-8355-549a2cf20776,\n IP:10,\n URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTI\n ON:release,TS:30","X-CID-INFO":"VERSION:1.3.12, REQID:e16d4aca-2451-4c4d-8355-549a2cf20776, IP:10,\n UR\n L:0,TC:0,Content:0,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION\n :release,TS:30","X-CID-META":"VersionHash:e7bac3a, CLOUDID:7f46d2dc6ec2a054980f91d26b1f2188,\n BulkI\n D:260428161611701L7LC2,BulkQuantity:0,Recheck:0,SF:17|19|66|78|81|82|102|1\n 27|898,TC:nil,Content:0|15|50,EDM:5,IP:-2,URL:1,File:nil,RT:nil,Bulk:nil,Q\n S:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,\n ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_ULS,TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","X-User":"gaoxiang@kylinos.cn","From":"Gao Xiang ","To":"libc-alpha@sourceware.org","Cc":"Xiang Gao ,\n\tRocket Ma ","Subject":"[PATCH v2] libio: Ignore setbuf for open_memstream [BZ #34019]","Date":"Tue, 28 Apr 2026 16:14:03 +0800","Message-ID":"<20260428081403.124732-1-gaoxiang@kylinos.cn>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260428075611.124127-1-gaoxiang@kylinos.cn>","References":"<20260428075611.124127-1-gaoxiang@kylinos.cn>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"},"content":"From: Xiang Gao \n\nopen_memstream and open_wmemstream manage an internal growable buffer.\nThe default setbuf hook can reset that buffer, breaking the assumptions\nused by the string stream overflow paths.\n\nInstall setbuf hooks that leave the internal buffer unchanged, and add\nregression test cases for the narrow and wide cases, based on the\nreproducer in BZ #34019.\n\nChecked on x86_64 with no regression in the libio tests.\n\nReported-by: Rocket Ma \nSigned-off-by: Xiang Gao \n\n---\n\nChanges in v2: Update the prototypes in libioP.h to using FILE *fp\nspacing consistently.\n---\n libio/Makefile | 1 +\n libio/libioP.h | 12 ++++++----\n libio/memstream.c | 9 +++++++\n libio/tst-memstream5.c | 54 ++++++++++++++++++++++++++++++++++++++++++\n libio/vtables.c | 6 +++--\n libio/wmemstream.c | 10 ++++++++\n 6 files changed, 86 insertions(+), 6 deletions(-)\n create mode 100644 libio/tst-memstream5.c","diff":"diff --git a/libio/Makefile b/libio/Makefile\nindex 93656466df..584fcdb14d 100644\n--- a/libio/Makefile\n+++ b/libio/Makefile\n@@ -120,6 +120,7 @@ tests = \\\n tst-memstream2 \\\n tst-memstream3 \\\n tst-memstream4 \\\n+ tst-memstream5 \\\n tst-mmap-eofsync \\\n tst-mmap-fflushsync \\\n tst-mmap-offend \\\ndiff --git a/libio/libioP.h b/libio/libioP.h\nindex 1485d22619..17c0b6e76d 100644\n--- a/libio/libioP.h\n+++ b/libio/libioP.h\n@@ -738,10 +738,14 @@ extern size_t __IO_obstack_xsputn (FILE *fp, const void *data, size_t n)\n attribute_hidden;\n \n /* Jumptable functions for open_{w}memstream. */\n-extern int _IO_mem_sync (FILE* fp) __THROW attribute_hidden;\n-extern void _IO_mem_finish (FILE* fp, int) __THROW attribute_hidden;\n-extern int _IO_wmem_sync (FILE* fp) __THROW attribute_hidden;\n-extern void _IO_wmem_finish (FILE* fp, int) __THROW attribute_hidden;\n+extern int _IO_mem_sync (FILE *fp) __THROW attribute_hidden;\n+extern void _IO_mem_finish (FILE *fp, int) __THROW attribute_hidden;\n+extern FILE *_IO_mem_setbuf (FILE *fp, char *buf, ssize_t size)\n+ __THROW attribute_hidden;\n+extern int _IO_wmem_sync (FILE *fp) __THROW attribute_hidden;\n+extern void _IO_wmem_finish (FILE *fp, int) __THROW attribute_hidden;\n+extern FILE *_IO_wmem_setbuf (FILE *fp, char *buf, ssize_t size)\n+ __THROW attribute_hidden;\n \n /* Other strfile functions */\n struct _IO_strfile_;\ndiff --git a/libio/memstream.c b/libio/memstream.c\nindex 0456adb92f..a5f909cf64 100644\n--- a/libio/memstream.c\n+++ b/libio/memstream.c\n@@ -112,3 +112,12 @@ _IO_mem_finish (FILE *fp, int dummy)\n \n _IO_str_finish (fp, 0);\n }\n+\n+FILE *\n+_IO_mem_setbuf (FILE *fp, char *p, ssize_t len)\n+{\n+ /* memstream manage a growable buffer internally. */\n+ (void) p;\n+ (void) len;\n+ return fp;\n+}\ndiff --git a/libio/tst-memstream5.c b/libio/tst-memstream5.c\nnew file mode 100644\nindex 0000000000..e9d05bb1df\n--- /dev/null\n+++ b/libio/tst-memstream5.c\n@@ -0,0 +1,54 @@\n+/* Test for open_memstream BZ #34019.\n+ Copyright (C) 2026 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ . */\n+\n+#include \n+#include \n+#include \n+#include \n+\n+static int\n+do_test (void)\n+{\n+ /* Narrow: setbuf must not replace the internal growable buffer. */\n+ char *buf = NULL;\n+ size_t len = 0;\n+ FILE *fp = open_memstream (&buf, &len);\n+ setbuf (fp, NULL);\n+ TEST_COMPARE (fputc ('A', fp), 'A');\n+ TEST_COMPARE (fclose (fp), 0);\n+ TEST_COMPARE (len, 1);\n+ TEST_COMPARE_STRING (buf, \"A\");\n+ free (buf);\n+\n+ /* Wide: same crash via _IO_wstr_overflow. */\n+ wchar_t *wbuf = NULL;\n+ size_t wlen = 0;\n+ FILE *wfp = open_wmemstream (&wbuf, &wlen);\n+ TEST_VERIFY_EXIT (wfp != NULL);\n+ setbuf (wfp, NULL);\n+ TEST_COMPARE (fputwc (L'A', wfp), L'A');\n+ TEST_COMPARE (fclose (wfp), 0);\n+ TEST_COMPARE (wlen, 1);\n+ TEST_VERIFY (wbuf != NULL);\n+ TEST_VERIFY (wbuf[0] == L'A' && wbuf[1] == L'\\0');\n+ free (wbuf);\n+\n+ return 0;\n+}\n+\n+#include \ndiff --git a/libio/vtables.c b/libio/vtables.c\nindex 00d9d25b5e..ca9f1b2dc4 100644\n--- a/libio/vtables.c\n+++ b/libio/vtables.c\n@@ -77,9 +77,11 @@\n # pragma weak _IO_cookie_write\n \n # pragma weak _IO_mem_finish\n+# pragma weak _IO_mem_setbuf\n # pragma weak _IO_mem_sync\n \n # pragma weak _IO_wmem_finish\n+# pragma weak _IO_wmem_setbuf\n # pragma weak _IO_wmem_sync\n \n # pragma weak __printf_buffer_as_file_overflow\n@@ -334,7 +336,7 @@ const struct _IO_jump_t __io_vtables[] attribute_relro =\n JUMP_INIT (xsgetn, _IO_default_xsgetn),\n JUMP_INIT (seekoff, _IO_str_seekoff),\n JUMP_INIT (seekpos, _IO_default_seekpos),\n- JUMP_INIT (setbuf, _IO_default_setbuf),\n+ JUMP_INIT (setbuf, _IO_mem_setbuf),\n JUMP_INIT (sync, _IO_mem_sync),\n JUMP_INIT (doallocate, _IO_default_doallocate),\n JUMP_INIT (read, _IO_default_read),\n@@ -357,7 +359,7 @@ const struct _IO_jump_t __io_vtables[] attribute_relro =\n JUMP_INIT (xsgetn, _IO_wdefault_xsgetn),\n JUMP_INIT (seekoff, _IO_wstr_seekoff),\n JUMP_INIT (seekpos, _IO_default_seekpos),\n- JUMP_INIT (setbuf, _IO_default_setbuf),\n+ JUMP_INIT (setbuf, _IO_wmem_setbuf),\n JUMP_INIT (sync, _IO_wmem_sync),\n JUMP_INIT (doallocate, _IO_wdefault_doallocate),\n JUMP_INIT (read, _IO_default_read),\ndiff --git a/libio/wmemstream.c b/libio/wmemstream.c\nindex d0c639be70..8f37a6efb8 100644\n--- a/libio/wmemstream.c\n+++ b/libio/wmemstream.c\n@@ -117,3 +117,13 @@ _IO_wmem_finish (FILE *fp, int dummy)\n \n _IO_wstr_finish (fp, 0);\n }\n+\n+\n+FILE *\n+_IO_wmem_setbuf (FILE *fp, char *p, ssize_t len)\n+{\n+ /* wmemstreams manage a growable buffer internally. */\n+ (void) p;\n+ (void) len;\n+ return fp;\n+}\n","prefixes":["v2"]}