{"id":2229391,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229391/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428081303.990973-7-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428081303.990973-7-marcandre.lureau@redhat.com>","date":"2026-04-28T08:12:53","name":"[PULL,06/15] ui: rename init_keyboard_layout->kbd_layout_new()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6ee4f050e1f4982cdf3870b738f37a460ca208cd","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428081303.990973-7-marcandre.lureau@redhat.com/mbox/","series":[{"id":501785,"url":"http://patchwork.ozlabs.org/api/1.1/series/501785/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501785","date":"2026-04-28T08:12:48","name":"[PULL,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h","version":1,"mbox":"http://patchwork.ozlabs.org/series/501785/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229391/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229391/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QMyABl/l;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YCY5xRHz1yHX\n\tfor ; Tue, 28 Apr 2026 18:15:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHdZm-000669-D3; Tue, 28 Apr 2026 04:13:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHdZl-00065I-3Y\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:13:49 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHdZj-00061q-K6\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:13:48 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-aWm3J9ctMqyy2vqs8h0j7w-1; Tue,\n 28 Apr 2026 04:13:45 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 806731956095; Tue, 28 Apr 2026 08:13:44 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5C29D196B8FB; Tue, 28 Apr 2026 08:13:42 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777364027;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=KlMDlHyLLl3lxtcJ4Plm3iqjAmK+IozF6Q8bNz/RuwA=;\n b=QMyABl/l/oxWvs6Ent7pFNcPnFj2EL14lANU7gH2rLhQcn06+pKB4Tp+RfKC9sYFYSVYr2\n E7xpOpuM5AX3wRUOmHrWY6CmUViIqFy9g21a/1Oc4XwtSxuEDv4unFUBobu7e34ihTQBVd\n +uv5B0kaHU8hVAzdMGnNtnFr8D1Wkoc=","X-MC-Unique":"aWm3J9ctMqyy2vqs8h0j7w-1","X-Mimecast-MFC-AGG-ID":"aWm3J9ctMqyy2vqs8h0j7w_1777364024","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 06/15] ui: rename init_keyboard_layout->kbd_layout_new()","Date":"Tue, 28 Apr 2026 12:12:53 +0400","Message-ID":"<20260428081303.990973-7-marcandre.lureau@redhat.com>","In-Reply-To":"<20260428081303.990973-1-marcandre.lureau@redhat.com>","References":"<20260428081303.990973-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nUse a more convential name.\n\nSuggested-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/keymaps.h | 4 ++--\n ui/curses.c | 4 ++--\n ui/input-barrier.c | 4 ++--\n ui/keymaps.c | 4 ++--\n ui/vnc.c | 6 +++---\n 5 files changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/ui/keymaps.h b/ui/keymaps.h\nindex e8917e56404..89bfbb2704d 100644\n--- a/ui/keymaps.h\n+++ b/ui/keymaps.h\n@@ -52,8 +52,8 @@ typedef struct {\n \n typedef struct kbd_layout_t kbd_layout_t;\n \n-kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n- const char *language, Error **errp);\n+kbd_layout_t *kbd_layout_new(const name2keysym_t *table,\n+ const char *language, Error **errp);\n void kbd_layout_free(kbd_layout_t *k);\n int keysym2scancode(kbd_layout_t *k, int keysym,\n QKbdState *kbd, bool down);\ndiff --git a/ui/curses.c b/ui/curses.c\nindex 161f78c35c3..af4ccb4227d 100644\n--- a/ui/curses.c\n+++ b/ui/curses.c\n@@ -770,8 +770,8 @@ static void curses_keyboard_setup(void)\n keyboard_layout = \"en-us\";\n #endif\n if(keyboard_layout) {\n- kbd_layout = init_keyboard_layout(name2keysym, keyboard_layout,\n- &error_fatal);\n+ kbd_layout = kbd_layout_new(name2keysym, keyboard_layout,\n+ &error_fatal);\n }\n }\n \ndiff --git a/ui/input-barrier.c b/ui/input-barrier.c\nindex 0a2198ca500..74724be8f45 100644\n--- a/ui/input-barrier.c\n+++ b/ui/input-barrier.c\n@@ -679,8 +679,8 @@ static void input_barrier_instance_init(Object *obj)\n /* always use generic keymaps */\n if (keyboard_layout && !kbd_layout) {\n /* We use X11 key id, so use VNC name2keysym */\n- kbd_layout = init_keyboard_layout(name2keysym, keyboard_layout,\n- &error_fatal);\n+ kbd_layout = kbd_layout_new(name2keysym, keyboard_layout,\n+ &error_fatal);\n }\n \n ib->saddr.type = SOCKET_ADDRESS_TYPE_INET;\ndiff --git a/ui/keymaps.c b/ui/keymaps.c\nindex d1b3f43dc8a..6822c097be7 100644\n--- a/ui/keymaps.c\n+++ b/ui/keymaps.c\n@@ -187,8 +187,8 @@ void kbd_layout_free(kbd_layout_t *k)\n g_free(k);\n }\n \n-kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n- const char *language, Error **errp)\n+kbd_layout_t *kbd_layout_new(const name2keysym_t *table,\n+ const char *language, Error **errp)\n {\n kbd_layout_t *k;\n \ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 16dbb0cd6c2..c87d1f61a0a 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3443,10 +3443,10 @@ void vnc_display_init(const char *id, Error **errp)\n \n if (keyboard_layout) {\n trace_vnc_key_map_init(keyboard_layout);\n- vd->kbd_layout = init_keyboard_layout(name2keysym,\n- keyboard_layout, errp);\n+ vd->kbd_layout = kbd_layout_new(name2keysym,\n+ keyboard_layout, errp);\n } else {\n- vd->kbd_layout = init_keyboard_layout(name2keysym, \"en-us\", errp);\n+ vd->kbd_layout = kbd_layout_new(name2keysym, \"en-us\", errp);\n }\n \n if (!vd->kbd_layout) {\n","prefixes":["PULL","06/15"]}