{"id":2229376,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229376/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428081303.990973-2-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428081303.990973-2-marcandre.lureau@redhat.com>","date":"2026-04-28T08:12:48","name":"[PULL,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"05ec191c92d9c2ddb1758f91856c3a98fcd2d79e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428081303.990973-2-marcandre.lureau@redhat.com/mbox/","series":[{"id":501785,"url":"http://patchwork.ozlabs.org/api/1.1/series/501785/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501785","date":"2026-04-28T08:12:48","name":"[PULL,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h","version":1,"mbox":"http://patchwork.ozlabs.org/series/501785/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229376/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229376/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XGpu1waq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Y9Q0b19z1yJH\n\tfor ; Tue, 28 Apr 2026 18:13:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHdZR-0005tu-Nu; Tue, 28 Apr 2026 04:13:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHdZK-0005sr-6A\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:13:22 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHdZI-0005io-NF\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:13:21 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-8COA24F5NRKrC9Elq7bW3g-1; Tue,\n 28 Apr 2026 04:13:16 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 58AD31956059; Tue, 28 Apr 2026 08:13:15 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 2FD4E180047F; Tue, 28 Apr 2026 08:13:13 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777363998;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DTwO7gzGMoGFPz1x9+2GvNTlpfFwIa7tMHQwc8A7sI8=;\n b=XGpu1waqaSYQaSEfhTmMJ6tPFAuFaCmYDe7OiW5C1mA9xLnZ1DP/cI0xpv3Ae3mhTqRXuF\n A8KKLgeO5qvKi9vSlgeJ+R2Iw1qg5pg8WaxcNoBGf39bwT1f0qXxUlxKYNA3ZO+zlWpcrw\n NRYWzOXKjNDX6SbdbyQNTeyr3xgQMMQ=","X-MC-Unique":"8COA24F5NRKrC9Elq7bW3g-1","X-Mimecast-MFC-AGG-ID":"8COA24F5NRKrC9Elq7bW3g_1777363995","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h","Date":"Tue, 28 Apr 2026 12:12:48 +0400","Message-ID":"<20260428081303.990973-2-marcandre.lureau@redhat.com>","In-Reply-To":"<20260428081303.990973-1-marcandre.lureau@redhat.com>","References":"<20260428081303.990973-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nSince those values are related to the VGA font, it make sense to move\nthem here.\n\nReviewed-by: Daniel P. Berrangé \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-priv.h | 5 -----\n ui/vgafont.h | 6 +++++-\n ui/console-vc.c | 1 +\n ui/console.c | 1 +\n 4 files changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/ui/console-priv.h b/ui/console-priv.h\nindex 8bcdb79d914..39798c3e9d7 100644\n--- a/ui/console-priv.h\n+++ b/ui/console-priv.h\n@@ -9,11 +9,6 @@\n #include \"qemu/coroutine.h\"\n #include \"qemu/timer.h\"\n \n-#include \"vgafont.h\"\n-\n-#define FONT_HEIGHT 16\n-#define FONT_WIDTH 8\n-\n struct QemuConsole {\n Object parent;\n \ndiff --git a/ui/vgafont.h b/ui/vgafont.h\nindex 54aeeb7d192..d24b5d47a95 100644\n--- a/ui/vgafont.h\n+++ b/ui/vgafont.h\n@@ -6,6 +6,10 @@\n \n #include \n \n-extern const uint8_t vgafont16[256 * 16];\n+/* supports only vga 8x16 */\n+#define FONT_WIDTH 8\n+#define FONT_HEIGHT 16\n+\n+extern const uint8_t vgafont16[256 * FONT_HEIGHT];\n \n #endif\ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 107294af1cc..6163e21d2c6 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -10,6 +10,7 @@\n #include \"qemu/option.h\"\n #include \"qemu/queue.h\"\n #include \"ui/console.h\"\n+#include \"ui/vgafont.h\"\n \n #include \"pixman.h\"\n #include \"trace.h\"\ndiff --git a/ui/console.c b/ui/console.c\nindex a7bd22515b9..9606da7b1a6 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -24,6 +24,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"ui/console.h\"\n+#include \"ui/vgafont.h\"\n #include \"hw/core/qdev.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-ui.h\"\n","prefixes":["PULL","01/15"]}