{"id":2229365,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229365/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428070647.777141-2-michal.swiatkowski@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260428070647.777141-2-michal.swiatkowski@linux.intel.com>","date":"2026-04-28T07:06:46","name":"[iwl-net,v1,1/2] ice: always do GCS if hardware supports it","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dba42fd32597ead2f30b6015dd2438861a33fb70","submitter":{"id":81972,"url":"http://patchwork.ozlabs.org/api/1.1/people/81972/?format=json","name":"Michal Swiatkowski","email":"michal.swiatkowski@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428070647.777141-2-michal.swiatkowski@linux.intel.com/mbox/","series":[{"id":501778,"url":"http://patchwork.ozlabs.org/api/1.1/series/501778/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501778","date":"2026-04-28T07:06:47","name":"Rework ice Tx checksum","version":1,"mbox":"http://patchwork.ozlabs.org/series/501778/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229365/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229365/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5l9Sw2Zr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Xcb5ls6z1yHv\n\tfor ; Tue, 28 Apr 2026 17:48:47 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6B312835A6;\n\tTue, 28 Apr 2026 07:48:45 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ewXtaIcdU2WR; Tue, 28 Apr 2026 07:48:44 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id AB1F181DF6;\n\tTue, 28 Apr 2026 07:48:44 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id C2DDD1B8\n for ; Tue, 28 Apr 2026 07:48:42 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id B4DEB835A3\n for ; Tue, 28 Apr 2026 07:48:42 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id eXPpyrlZg8JU for ;\n Tue, 28 Apr 2026 07:48:42 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E754E80984\n for ; Tue, 28 Apr 2026 07:48:41 +0000 (UTC)","from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 00:48:41 -0700","from os-delivery.igk.intel.com ([10.102.21.165])\n by fmviesa003.fm.intel.com with ESMTP; 28 Apr 2026 00:48:39 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org AB1F181DF6","OpenDKIM Filter v2.11.0 smtp1.osuosl.org E754E80984"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777362524;\n\tbh=jZwj4tX/oev43hW6mlw83gckHgi/VwfgkmUGlAjEjyk=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=5l9Sw2ZrFBMfqpGhTF/uKnCI10ONo5UJ4TKAy4iR4yCyFabhpSjp6VYFy+GPatB4L\n\t 9uYlt8+ozI21dF+K+b8I6yRGRVhzN3D2tgRoj9n4f9c2kDmD95xTd5GCsPUitXEKdc\n\t kjTR/TfMqgprhTKol1yzvYqEtoA/DTaWSX9MH4H9jljD+tW+wX4f1uuCxufGusVJ8L\n\t U1tdaBI6kIN5TY3ll2I+E9Xi8NZlUQLygkkhouOeBg+WwjHCVHtsp4YJY263XnH7Dx\n\t c+6a+cpk+HSKXU+EgTeClpslea0ZETbq0vS7C00419kTgXyKIW/cWZ8GfXb0LPdn28\n\t UqP0Ix9A/930Q==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org E754E80984","X-CSE-ConnectionGUID":["JEJwj2pgSJO5beip3bt+ew==","oZxoNrDDT2KD76jnox+vpA=="],"X-CSE-MsgGUID":["rAHcBGM/T8ONTCYwoQ9r9w==","RZOxA7l0Sb+HUeBPeYePMQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"82114977\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"82114977\""],"X-ExtLoop1":"1","From":"Michal Swiatkowski ","To":"intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, jramaseu@redhat.com, anthony.l.nguyen@intel.com,\n przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com,\n Michal Swiatkowski ","Date":"Tue, 28 Apr 2026 09:06:46 +0200","Message-ID":"<20260428070647.777141-2-michal.swiatkowski@linux.intel.com>","X-Mailer":"git-send-email 2.49.0","In-Reply-To":"<20260428070647.777141-1-michal.swiatkowski@linux.intel.com>","References":"<20260428070647.777141-1-michal.swiatkowski@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777362522; x=1808898522;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=89VxZuTuAfq1TCEMT31Kq1wu5QB4YSBR1QkGpSsfP4Y=;\n b=ZLqvc++FnAsxpdsJBpfD2Y7dtlR9tMDhJblSsLzeiBCpSRJ6PqOWnuKo\n MSG6+GIM9J9QCO98pbjvtwO6Lb3qERF33AY5RGaiorsp6GxUpLF3yMs3p\n Yx2hZ27tjDlWAjuJhWuYwir+IoSlDQFc/QLh44+MxPY1TqMgPn57OU1Uh\n 6a9nxkpPpDshqA/W7sJKKmStZ+wpbUHeK0DTLLTjDOaVdEy6PYBCoUyUM\n XZ6z+h4BvZi4J5wy7ofZ7eI92ejK3TprzjohnWvEWDqg3AUk0rLpCwshB\n M1s7hgHBZTI48qVHnk8+7OxWMBitECasFwA9eqbBgBRJaMJgOEiIyr7cD\n g==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=ZLqvc++F"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v1 1/2] ice: always do GCS if\n hardware supports it","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"There is no need to check for NETIF_HW_CSUM. If the code reach\ncalculating checksum it means that correct checksum flags are set,\nbecause kernel is checking that when setting ip->summed.\n\nInstead of netdev feature flag use Tx ring flag to check if the hardware\ncan use special descriptor for checksum calculating.\n\nReviewed-by: Przemek Kitszel \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Michal Swiatkowski \n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++++\n drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-\n drivers/net/ethernet/intel/ice/ice_txrx.h | 1 +\n 3 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 837b71b7b2b7..033fabc22f58 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -1415,6 +1415,10 @@ static int ice_vsi_alloc_rings(struct ice_vsi *vsi)\n \t\t\tset_bit(ICE_TX_RING_FLAGS_VLAN_L2TAG2, ring->flags);\n \t\telse\n \t\t\tset_bit(ICE_TX_RING_FLAGS_VLAN_L2TAG1, ring->flags);\n+\n+\t\tif (ice_is_feature_supported(pf, ICE_F_GCS))\n+\t\t\tset_bit(ICE_TX_RING_FLAGS_GCS, ring->flags);\n+\n \t\tWRITE_ONCE(vsi->tx_rings[i], ring);\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c\nindex 4ca1a0602307..25b19a5d817e 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c\n@@ -1743,7 +1743,7 @@ int ice_tx_csum(struct ice_tx_buf *first, struct ice_tx_offload_params *off)\n \tl3_len = l4.hdr - ip.hdr;\n \toffset |= (l3_len / 4) << ICE_TX_DESC_LEN_IPLEN_S;\n \n-\tif ((tx_ring->netdev->features & NETIF_F_HW_CSUM) &&\n+\tif (test_bit(ICE_TX_RING_FLAGS_GCS, tx_ring->flags) &&\n \t !(first->tx_flags & ICE_TX_FLAGS_TSO) &&\n \t !skb_csum_is_sctp(skb)) {\n \t\t/* Set GCS */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.h b/drivers/net/ethernet/intel/ice/ice_txrx.h\nindex 5e517f219379..15dbd5100912 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.h\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.h\n@@ -217,6 +217,7 @@ enum ice_tx_ring_flags {\n \tICE_TX_RING_FLAGS_VLAN_L2TAG1,\n \tICE_TX_RING_FLAGS_VLAN_L2TAG2,\n \tICE_TX_RING_FLAGS_TXTIME,\n+\tICE_TX_RING_FLAGS_GCS,\n \tICE_TX_RING_FLAGS_NBITS,\n };\n \n","prefixes":["iwl-net","v1","1/2"]}