{"id":2229311,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229311/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260428061540.73668-1-venkat88@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260428061540.73668-1-venkat88@linux.ibm.com>","date":"2026-04-28T06:15:40","name":"[v5] char/nvram: Remove redundant nvram_mutex","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2d0b1dfb10ef24c4f389f7269390716153a49c89","submitter":{"id":89673,"url":"http://patchwork.ozlabs.org/api/1.1/people/89673/?format=json","name":"Venkat Rao Bagalkote","email":"venkat88@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260428061540.73668-1-venkat88@linux.ibm.com/mbox/","series":[{"id":501765,"url":"http://patchwork.ozlabs.org/api/1.1/series/501765/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501765","date":"2026-04-28T06:15:40","name":"[v5] char/nvram: Remove redundant nvram_mutex","version":5,"mbox":"http://patchwork.ozlabs.org/series/501765/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229311/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2229311/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kCkur0Nb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20207-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kCkur0Nb;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=venkat88@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4VYm2qBYz1yHv\n\tfor ; Tue, 28 Apr 2026 16:16:12 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g4VYf16gNz2ynv;\n\tTue, 28 Apr 2026 16:16:06 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g4VYc53Zrz2yRn\n\tfor ; Tue, 28 Apr 2026 16:16:03 +1000 (AEST)","from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63S3dq7e2134186;\n\tTue, 28 Apr 2026 06:15:51 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn9r3ymf-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 28 Apr 2026 06:15:50 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63S68hYH032359;\n\tTue, 28 Apr 2026 06:15:49 GMT","from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8xk0dkq-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 28 Apr 2026 06:15:49 +0000 (GMT)","from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com\n [10.20.54.100])\n\tby smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63S6Fj8657868708\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 28 Apr 2026 06:15:46 GMT","from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D8AD020043;\n\tTue, 28 Apr 2026 06:15:45 +0000 (GMT)","from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 19A6120040;\n\tTue, 28 Apr 2026 06:15:44 +0000 (GMT)","from localhost.localdomain (unknown [9.123.2.184])\n\tby smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 28 Apr 2026 06:15:43 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777356966;\n\tcv=none;\n b=VcipnOLEApHrTFPKaAvxszOp5ksT8Q0Y3HdfK81NQs9nuPu/dgoUpoCg5LnQD8iYb9SZehHZ03gpEspSeoaOw9bQNY4JSvDD87mXQkAeLz7faJ7a8fhQheqs5q9IM1xlRF9c8b87JLBmtOchFTT9rcwOqmyh268WfWHuZVUrultWF72zQmQVTbte/BjJSfr1QI7jmtw2TtN4g5Fa84LeoiKzGdu6mK2bmf8sHv9KVOzTU/CkgYRLPXxQLiMX0rq+oI67K5TchuEqnMIn1BX6W1mM+pDFkkEw3N5nYB0bejH+ZT8h9925YWii2LfdyK7KTOVHVsAOrHTmfVrPsykHMw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777356966; c=relaxed/relaxed;\n\tbh=Zv2le+No9TSgxay/sIfX02Z3YDQPTXyPQ6r9GxP8vSY=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=K3Oh0t+lKYab8bex/UUj+JXZAmDfF305xCTyvVl+mp9nUuXBTP5N6r50OGkmSGTd+ojGEk2jgEKVqjFYF702OHjhOBanPtoI0YGr0jqyU/7ZXjKPgUrRNc//r+kqMcjzAH5ddIXfDselNLit+oTWvKmurM2YyiiGcTWFh8MoBXqamRgZhr19vxp9MgN/7TfikQO1hoGrOvsGCu7VKiq0PfJE+HkoUdrofsr7lYBwdvq6qqNU7iIRTMiR6Ta9EINouzwdWzdmt43BrwSCk/5z+mn+Gycfu6TVLRZpugn3Eq2FPUiEmBKrWxoy4MYAlbM1F8q3UAKkkRz8cJ0T7vNxZA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=kCkur0Nb; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=venkat88@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=Zv2le+No9TSgxay/sIfX02Z3YDQPTXyPQ6r9GxP8v\n\tSY=; b=kCkur0NbAAM1lOtDv+AzTWY+8oqCocAckaeYpm7s5/a7yTqQ84U5pkKmW\n\t9gjKQAzxclxwb2BZJKQT12OTFXaomX5V3tD4eMXtzP1N1yCC2Vcw6L7ecPV6KfmN\n\tf5g2OkYHpA2LW55CqVD6juizzCZOboxjQGJVv0GQW0srqbgOa8n+iHKDoW1kuvYK\n\t6AGwHMme53fiLQ8MkeB2kHKjfUGATrhvxLcE278AH3gWAgrIW43UfYBGWe7xO83l\n\t9hHIcimtAL0tLCvBewguxNdu2jfaTwIs9SnDf44OahQaamykoWTKaro9Hvp/Wr/G\n\t4jQ3Qddl6+eQ5rFk7ccypz8LIvYEQ==","From":"Venkat Rao Bagalkote ","To":"Greg Kroah-Hartman ","Cc":"linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, Arnd Bergmann ,\n Christophe Leroy ,\n Ritesh Harjani ,\n Madhavan Srinivasan ,\n Tellakula Yeswanth Krishna ,\n Venkat Rao Bagalkote ","Subject":"[PATCH v5] char/nvram: Remove redundant nvram_mutex","Date":"Tue, 28 Apr 2026 11:45:40 +0530","Message-ID":"<20260428061540.73668-1-venkat88@linux.ibm.com>","X-Mailer":"git-send-email 2.45.2","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"gPS18S9n2b7CyF5254k6wu4tyTqiWTH4","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI4MDA1MCBTYWx0ZWRfX8MvJ/qVJHNe6\n B24w5ZSW7WXQTK7mL5jV6RIrkLPBuq0mGOoxQ7xUhNbpUAxAaCDM0Q9kb5sc2QT3v7Ug6Z+u7Q/\n cPxHZqUwgTsuXiHx8Q6XxiMu3BuVgt/ODZBxBM9aPl0ZtglEpS5YB1nmdA2iihsW/6bXre8eOIf\n Exna0j0szVWvfTh/ZnzzoPZn2Rvsa/npeUsMf165m2cSBLNgxlSssFVgsrohCmIRBqzvWEFWew1\n iGvQ9tq3GBQBCIVG30fiEGzqIMWAvyPlUq43BAI9LY5+BrNMfUk6qIXdFGwS/7VJn5fnXZ7WA/K\n 0IYQ5B8dSKTTRQZ7PghIV/PxvosBJeCZ2mtY/Jeio0xDTXAG8OyA6WH7Yzi/9738mici/xB4roc\n K0tMvzOFHHDdLnc1gc65gKAiQMywAHg7v3ruREA/SQh2ru83Ow9lwcnpc80uLsR3nsRogtKm39B\n gIAIQUZOJG7uzvbSaSQ==","X-Authority-Analysis":"v=2.4 cv=Kc7idwYD c=1 sm=1 tr=0 ts=69f05097 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=WqWmceQO84Qbs2Y3kP8A:9","X-Proofpoint-ORIG-GUID":"W4EQXKQtZa3ZwQO0U5DU1g9z1XXYpdcG","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_01,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 spamscore=0\n malwarescore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604280050","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The global nvram_mutex in drivers/char/nvram.c is redundant and unused,\nand this triggers compiler warnings on some configurations.\n\nAll platform-specific nvram operations already provide their own internal\nsynchronization, meaning the wrapper-level mutex does not provide any\nadditional safety.\n\nRemove the nvram_mutex definition along with all remaining lock/unlock\nusers across PPC32, x86, and m68k code paths, and rely entirely on the\nper-architecture nvram implementations for locking.\n\nReviewed-by: Arnd Bergmann \nSuggested-by: Arnd Bergmann \nTested-by: Tellakula Yeswanth Krishna \nSigned-off-by: Venkat Rao Bagalkote \n---\nChanges since v4:\n- No code changes\n- Resent after v7.1-rc1 as suggested by Arnd Bergmann\n\n drivers/char/nvram.c | 16 +++-------------\n 1 file changed, 3 insertions(+), 13 deletions(-)","diff":"diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c\nindex 9eff426a9286..e89cc1f1c89e 100644\n--- a/drivers/char/nvram.c\n+++ b/drivers/char/nvram.c\n@@ -53,7 +53,6 @@\n #include \n #endif\n \n-static DEFINE_MUTEX(nvram_mutex);\n static DEFINE_SPINLOCK(nvram_state_lock);\n static int nvram_open_cnt;\t/* #times opened */\n static int nvram_open_mode;\t/* special open modes */\n@@ -310,11 +309,8 @@ static long nvram_misc_ioctl(struct file *file, unsigned int cmd,\n \t\tbreak;\n #ifdef CONFIG_PPC32\n \tcase IOC_NVRAM_SYNC:\n-\t\tif (ppc_md.nvram_sync != NULL) {\n-\t\t\tmutex_lock(&nvram_mutex);\n+\t\tif (ppc_md.nvram_sync)\n \t\t\tppc_md.nvram_sync();\n-\t\t\tmutex_unlock(&nvram_mutex);\n-\t\t}\n \t\tret = 0;\n \t\tbreak;\n #endif\n@@ -324,11 +320,8 @@ static long nvram_misc_ioctl(struct file *file, unsigned int cmd,\n \t\tif (!capable(CAP_SYS_ADMIN))\n \t\t\treturn -EACCES;\n \n-\t\tif (arch_nvram_ops.initialize != NULL) {\n-\t\t\tmutex_lock(&nvram_mutex);\n+\t\tif (arch_nvram_ops.initialize)\n \t\t\tret = arch_nvram_ops.initialize();\n-\t\t\tmutex_unlock(&nvram_mutex);\n-\t\t}\n \t\tbreak;\n \tcase NVRAM_SETCKS:\n \t\t/* just set checksum, contents unchanged (maybe useful after\n@@ -336,11 +329,8 @@ static long nvram_misc_ioctl(struct file *file, unsigned int cmd,\n \t\tif (!capable(CAP_SYS_ADMIN))\n \t\t\treturn -EACCES;\n \n-\t\tif (arch_nvram_ops.set_checksum != NULL) {\n-\t\t\tmutex_lock(&nvram_mutex);\n+\t\tif (arch_nvram_ops.set_checksum)\n \t\t\tret = arch_nvram_ops.set_checksum();\n-\t\t\tmutex_unlock(&nvram_mutex);\n-\t\t}\n \t\tbreak;\n #endif /* CONFIG_X86 || CONFIG_M68K */\n \t}\n","prefixes":["v5"]}