{"id":2229160,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229160/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-gtk-clipboard-v5-2-6968feb31a5d@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-gtk-clipboard-v5-2-6968feb31a5d@gmail.com>","date":"2026-04-27T20:06:44","name":"[v5,2/2] ui/gtk: Turn clipboard flag into runtime option","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d4948e51be89c47b6e2fd30be00d24fb90bc5067","submitter":{"id":4408,"url":"http://patchwork.ozlabs.org/api/1.1/people/4408/?format=json","name":"Jindrich Makovicka","email":"makovick@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-gtk-clipboard-v5-2-6968feb31a5d@gmail.com/mbox/","series":[{"id":501720,"url":"http://patchwork.ozlabs.org/api/1.1/series/501720/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501720","date":"2026-04-27T20:06:43","name":"Fix and re-enable GTK clipboard","version":5,"mbox":"http://patchwork.ozlabs.org/series/501720/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229160/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229160/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=OzPy7KCk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4F3c5th5z1yHX\n\tfor ; Tue, 28 Apr 2026 06:07:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSEa-0005VP-KY; Mon, 27 Apr 2026 16:07:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSEL-0005U5-IC\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:06:58 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHSEI-00058M-K7\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:06:57 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so181006365e9.2\n for ; Mon, 27 Apr 2026 13:06:54 -0700 (PDT)","from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a773efe38sm12767755e9.13.2026.04.27.13.06.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 13:06:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777320413; x=1777925213; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=/jY2+kwe2S2V0RgrKuq3DboBzyZETsHe+RrPp0TFj/g=;\n b=OzPy7KCk5IhOaiKMqvFv6ZmHPivm+pa2TX+GXnNcahAROWIaeKuWJtPqT9rhQ73ECM\n rVY7PupJwK6pc9+zGnwbKmPlJEI7zbEW2+pasbz9l9OTOn3Ys/UjNGRm1khzKmZCQ/jF\n 5Qny7DvT9y2V09hdmSglH6JXeS+Y2JBCoWUblWrkyW/PVmf0ohQ82kZNjN/nvgROXTkS\n hepnncpud5yYqpL/9xRHexrRKG+Kv9Xssn5zKnvsWpAZ+RUSvQZ4P7E08Z5wCdqP+Vg4\n 7wH0bZ6YyZ1m0xODpefw0IuFkYOb/kxe/LOxI2kxMnHiZC5nYEQkl5xVe2YY9ageH/O8\n qI2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777320413; x=1777925213;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=/jY2+kwe2S2V0RgrKuq3DboBzyZETsHe+RrPp0TFj/g=;\n b=SW3FUlh2fL94GT9Dw5VA7fy0Cza+E89LaOFTDOlbzW2qzs8IdQ2pvZy2tWKOZUb2GF\n itHUPZ5Z32Bn8ClgVa7grpeXbAkj9YepTQKml/z+J55vTDiCexeQsaXrXWMOAlHpsVdq\n Tazrc6d021l0uxm7xZ3eDuFI3f2Q5oRmL22kFg1aT1jcn7ErejtXk1VHe44Ke+NVBmDg\n 6MbUuFCGNRFGOpgDjN4DPKorr89G8dX5VfQAUQQk5sQwus7bluGD2BSlZekKNWkjindo\n 2eZ2ZpAdKKBLVqdDf8SkDL+Tsn275fm8TcFEKJnYu7zRZg1njfwpIhPEF89UWJrGsPMQ\n ELAA==","X-Gm-Message-State":"AOJu0YxDOyRLAayZatlHtSLgLVdDSpnshkkb4WMkTvHOLgdIzcEMR3YG\n Q7t2tS2PzzToL5DrGXxJ93PyfEEd4zmMPVen0zASqTLf8a2LUn9ey0JKIZiJ5vNRxJo=","X-Gm-Gg":"AeBDieu3lL8dWA3aIi09HOezPw21JyGa6uLvoFB8WEt05Tg67foml6NUJGmu8LuvOfY\n 9JZxaaqmdaiC5ibmoBV5GXhLB0hKnUzGOOr4Lg9UY+ZGwkXhuZ3dOXuAsPkeA9tVZ/vjmlPCiUV\n SbjTYZkDnaJVMVrhzQjMk+dWLJiN/0WjVqaTJ4Oe/jKOSIuRyRSLvWvg6MjsGexCGVIrSJKOlw6\n kNm6AHRWycNZDUy3QBbcIcQMDz24jgYrA+ziOn4jMggbn/bsgkn2Ve8oVp8oEik6V1Dw0oJjmyK\n AK3m2b4j0KJ5tbwJaf+8vfDve3+mrb56OPKtuFGObXJCrojJ6QjRrH6VtUUUjupdowdTNFGpkbs\n iHUudO4SLr619RO5dsmDZGVjNH331VYjXC9StA5qZVKhyDUzgDSXlJSZhbFdSwJiATVB0ZB9pjG\n DrzB3XNAeq8ir2v4DhfW1a/EHxowu4N6Jp5bFYHb8=","X-Received":"by 2002:a05:600c:4f8a:b0:489:d1c:d468 with SMTP id\n 5b1f17b1804b1-48a77b24d5bmr1787845e9.31.1777320412954;\n Mon, 27 Apr 2026 13:06:52 -0700 (PDT)","From":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ","Date":"Mon, 27 Apr 2026 22:06:44 +0200","Subject":"[PATCH v5 2/2] ui/gtk: Turn clipboard flag into runtime option","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260427-gtk-clipboard-v5-2-6968feb31a5d@gmail.com>","References":"<20260427-gtk-clipboard-v5-0-6968feb31a5d@gmail.com>","In-Reply-To":"<20260427-gtk-clipboard-v5-0-6968feb31a5d@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Pierrick Bouvier ,\n Eric Blake , Markus Armbruster ,\n Jindrich Makovicka ","X-Mailer":"b4 0.14.3","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=makovick@gmail.com; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"- Compile the GTK clipboard support unconditionally\n\n- Introduce GTK clipboard option, defaulting to off\n\nSigned-off-by: Jindrich Makovicka \n---\n meson.build | 4 ----\n meson_options.txt | 7 -------\n qapi/ui.json | 6 +++++-\n qemu-options.hx | 9 ++++++---\n ui/gtk.c | 8 +++++---\n ui/meson.build | 4 +---\n 6 files changed, 17 insertions(+), 21 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 096303f021..761c0436a3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1932,7 +1932,6 @@ endif\n gtk = not_found\n gtkx11 = not_found\n vte = not_found\n-have_gtk_clipboard = get_option('gtk_clipboard').enabled()\n \n if get_option('gtk') \\\n .disable_auto_if(not have_system) \\\n@@ -1954,8 +1953,6 @@ if get_option('gtk') \\\n method: 'pkg-config',\n required: get_option('vte'))\n endif\n- elif have_gtk_clipboard\n- error('GTK clipboard requested, but GTK not found')\n endif\n endif\n \n@@ -2475,7 +2472,6 @@ if glusterfs.found()\n endif\n config_host_data.set('CONFIG_GTK', gtk.found())\n config_host_data.set('CONFIG_VTE', vte.found())\n-config_host_data.set('CONFIG_GTK_CLIPBOARD', have_gtk_clipboard)\n config_host_data.set('CONFIG_HEXAGON_IDEF_PARSER', get_option('hexagon_idef_parser'))\n config_host_data.set('CONFIG_LIBATTR', have_old_libattr)\n config_host_data.set('CONFIG_LIBCAP_NG', libcap_ng.found())\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 31d5916cfc..286461129b 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -262,13 +262,6 @@ option('vnc_sasl', type : 'feature', value : 'auto',\n description: 'SASL authentication for VNC server')\n option('vte', type : 'feature', value : 'auto',\n description: 'vte support for the gtk UI')\n-\n-# GTK Clipboard implementation is disabled by default, since it may cause hangs\n-# of the guest VCPUs. See gitlab issue 1150:\n-# https://gitlab.com/qemu-project/qemu/-/issues/1150\n-\n-option('gtk_clipboard', type: 'feature', value : 'disabled',\n- description: 'clipboard support for the gtk UI (EXPERIMENTAL, MAY HANG)')\n option('xkbcommon', type : 'feature', value : 'auto',\n description: 'xkbcommon support')\n option('zstd', type : 'feature', value : 'auto',\ndiff --git a/qapi/ui.json b/qapi/ui.json\nindex e3da77632a..b2c42a7f57 100644\n--- a/qapi/ui.json\n+++ b/qapi/ui.json\n@@ -1319,6 +1319,9 @@\n #\n # GTK display options.\n #\n+# @clipboard: Enable host-guest clipboard sharing. Defaults to \"off\".\n+# (Since 11.1)\n+#\n # @grab-on-hover: Grab keyboard input on mouse hover.\n #\n # @zoom-to-fit: Zoom guest display to fit into the host window. When\n@@ -1344,7 +1347,8 @@\n # Since: 2.12\n ##\n { 'struct' : 'DisplayGTK',\n- 'data' : { '*grab-on-hover' : 'bool',\n+ 'data' : { '*clipboard' : 'bool',\n+ '*grab-on-hover' : 'bool',\n '*zoom-to-fit' : 'bool',\n '*show-tabs' : 'bool',\n '*show-menubar' : 'bool',\ndiff --git a/qemu-options.hx b/qemu-options.hx\nindex 21972f8326..e780bc2ac0 100644\n--- a/qemu-options.hx\n+++ b/qemu-options.hx\n@@ -2209,9 +2209,9 @@ DEF(\"display\", HAS_ARG, QEMU_OPTION_display,\n \" [,window-close=on|off]\\n\"\n #endif\n #if defined(CONFIG_GTK)\n- \"-display gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off]\\n\"\n- \" [,show-tabs=on|off][,show-cursor=on|off][,window-close=on|off]\\n\"\n- \" [,show-menubar=on|off][,zoom-to-fit=on|off]\\n\"\n+ \"-display gtk[,clipboard=on|off][,full-screen=on|off][,gl=on|off]\\n\"\n+ \" [,grab-on-hover=on|off][,show-tabs=on|off][,show-cursor=on|off]\\n\"\n+ \" [,window-close=on|off][,show-menubar=on|off][,zoom-to-fit=on|off]\\n\"\n #endif\n #if defined(CONFIG_VNC)\n \"-display vnc=[,]\\n\"\n@@ -2295,6 +2295,9 @@ SRST\n drop-down menus and other UI elements to configure and control\n the VM during runtime. Valid parameters are:\n \n+ ``clipboard=on|off`` : Enable host-guest clipboard sharing,\n+ defaults to \"off\"\n+\n ``full-screen=on|off`` : Start in fullscreen mode\n \n ``gl=on|off`` : Use OpenGL for displaying\ndiff --git a/ui/gtk.c b/ui/gtk.c\nindex 9ebe7e8df0..ab5f1ef7aa 100644\n--- a/ui/gtk.c\n+++ b/ui/gtk.c\n@@ -2601,9 +2601,11 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)\n opts->u.gtk.show_tabs) {\n gtk_menu_item_activate(GTK_MENU_ITEM(s->show_tabs_item));\n }\n-#ifdef CONFIG_GTK_CLIPBOARD\n- gd_clipboard_init(s);\n-#endif /* CONFIG_GTK_CLIPBOARD */\n+\n+ if (opts->u.gtk.has_clipboard &&\n+ opts->u.gtk.clipboard) {\n+ gd_clipboard_init(s);\n+ }\n \n /* GTK's event polling must happen on the main thread. */\n qemu_main = NULL;\ndiff --git a/ui/meson.build b/ui/meson.build\nindex 4e533d3046..6405e21d5d 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -111,9 +111,7 @@ if gtk.found()\n \n gtk_ss = ss.source_set()\n gtk_ss.add(gtk, vte, pixman, files('gtk.c'))\n- if have_gtk_clipboard\n- gtk_ss.add(files('gtk-clipboard.c'))\n- endif\n+ gtk_ss.add(files('gtk-clipboard.c'))\n gtk_ss.add(when: x11, if_true: files('x_keymap.c'))\n gtk_ss.add(when: opengl, if_true: files('gtk-gl-area.c'))\n gtk_ss.add(when: [x11, opengl], if_true: files('gtk-egl.c'))\n","prefixes":["v5","2/2"]}