{"id":2229146,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229146/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-41-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-41-c413f3605311@redhat.com>","date":"2026-04-27T19:42:40","name":"[41/41] qtest: add \"qom-tests\" command","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bef8cec89ce98338dacbf507de5b1e9f9ecb6730","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-41-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229146/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229146/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=agzF/f/I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DgR3hr7z1yHX\n\tfor ; Tue, 28 Apr 2026 05:50:11 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRuu-00036y-9U; Mon, 27 Apr 2026 15:46:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRuj-0002o5-BQ\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:46 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRuf-0000HM-P5\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:39 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-XyMDERm4M0G3qTkbTuBaMg-1; Mon,\n 27 Apr 2026 15:46:35 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6FB97195608D; Mon, 27 Apr 2026 19:46:34 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C5AC8195608E; Mon, 27 Apr 2026 19:46:32 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319196;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HEApZps73Ho7aFOZh1+bQSHeMmOHaneoKeZvjd0sWTM=;\n b=agzF/f/IYq85lNVLm7BZbU8l01t67YsTrtzgF9D7DZfLA6GlyNqg34EB5mkGFuAPm3l2ZU\n 6tA83Sgrog4CQ2rH+znK4m8TEnbeEk5fhkSL0GCG2MV47So42lG1JG6q0hYB7gr21mBP+x\n D6l8tCLRIAmNb9XrMprd2odFkdhwSfU=","X-MC-Unique":"XyMDERm4M0G3qTkbTuBaMg-1","X-Mimecast-MFC-AGG-ID":"XyMDERm4M0G3qTkbTuBaMg_1777319194","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:40 +0400","Subject":"[PATCH 41/41] qtest: add \"qom-tests\" command","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-41-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4927;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=TkaCs7mNmnZ1B+TylAApTAOAEYAjeYCYy5SFEzjEKNk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wW2ZACVw4f/iGQ4ZmTSUmhufIHN6vhfETm3\n 2y3Bfs5XvaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac\n 5SinD/9ccyvjzHnR2Ej+g1W8x8eECA6wfmZKW5Z0+RRLoIeHFahwrnKV7aJGeZRuA3Rqy3zYa97\n 6OCczmiUPt+mtXqqJQfqBzHWgaxmixLbtLf0lT/mF/QXsJK2arLLApEcHmiLc82Q8B2hKxSYVkZ\n jJB2GW5lqqyv1ajMWx1dUiWV2a5FbpZLK9spY9OTKM5bnIthtKm9W1pXJgGU7k2Zew2jgK/IYoU\n Afh743adISuNxxxJew63ZnmhxLXe9mFETLE94bVVH5ZHU0lln6dexVrPwvcpyD4kMyiK8xI0YTe\n QhXDa8aVJ4g2eJ1HO1RZs9YKKzlLv35HinS/Qr/Wo5Lb6T5O96VY0vwK2QUzsCHGD6uvcXe+ouj\n XnAOB1rMgVRBIomFd7pD8CdJYBGfU/7nXUxkDq1Dg63BkDiBeO3/xsZLFBYuEmcjQJC4nH/moVf\n yB0yHQHryVJLhiN1bQbZCsBvC3f1YcfVwk0tKIqx5F0msgR1HDEQqdIwLcqVkNHR0WR3Sl/0391\n xiab8AI8EWFnZfc7vMiVgfJBx8fzEYqZstNBQbC6Kj4GEFKiwJhGBbsOki0DNQQtDC5KxWatYuv\n 3wGbNjKiFytzElK0oHn360vmMd3DDchDEI9XtfjZtdslYgQq5Sb7mbQbh9Od+07uQvx0r6RShuF\n CojWRMpIW5xiEPA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add a new \"qom-tests\" to exercise basic object lifecycle. Instantiate\nall non-abstract objects, get and set properties and unref.\n\nThis should quickly find leaks and other related issues that are\neventually triggerable at run-time with QMP qom commands.\n\nSigned-off-by: Marc-André Lureau \n---\n tests/qtest/libqtest.h | 8 ++++++++\n system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++\n tests/qtest/libqtest.c | 6 ++++++\n tests/qtest/qom-test.c | 12 ++++++++++++\n 4 files changed, 72 insertions(+)","diff":"diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h\nindex 9c118c89ca0..02d65ecb65d 100644\n--- a/tests/qtest/libqtest.h\n+++ b/tests/qtest/libqtest.h\n@@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap)\n \n void qtest_module_load(QTestState *s, const char *prefix, const char *libname);\n \n+/**\n+ * qtest_qom_tests:\n+ * @s: #QTestState instance to operate on.\n+ *\n+ * Run QOM property get/set round-trip tests on all non-abstract types.\n+ */\n+void qtest_qom_tests(QTestState *s);\n+\n /**\n * qtest_get_irq:\n * @s: #QTestState instance to operate on.\ndiff --git a/system/qtest.c b/system/qtest.c\nindex e9e5773341f..217fccf8544 100644\n--- a/system/qtest.c\n+++ b/system/qtest.c\n@@ -31,6 +31,8 @@\n #include \"qemu/cutils.h\"\n #include \"qemu/target-info.h\"\n #include \"qom/object_interfaces.h\"\n+#include \"qom/qom-qobject.h\"\n+#include \"qobject/qobject.h\"\n \n #define MAX_IRQ 256\n \n@@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, gchar **words)\n new_ns = qemu_clock_advance_virtual_time(ns);\n qtest_sendf(chr, \"%s %\"PRIi64\"\\n\",\n new_ns == ns ? \"OK\" : \"FAIL\", new_ns);\n+ } else if (strcmp(words[0], \"qom-tests\") == 0) {\n+ GSList *list, *l;\n+\n+ list = object_class_get_list(NULL, false);\n+ for (l = list; l; l = l->next) {\n+ ObjectClass *klass = l->data;\n+ const char *type_name = object_class_get_name(klass);\n+ Object *obj;\n+ ObjectPropertyIterator iter;\n+ ObjectProperty *prop;\n+\n+ obj = object_new_with_class(klass);\n+ object_property_iter_init(&iter, obj);\n+ while ((prop = object_property_iter_next(&iter))) {\n+ QObject *value;\n+ Error *local_err = NULL;\n+\n+ value = object_property_get_qobject(obj, prop->name,\n+ &local_err);\n+ if (local_err) {\n+ error_report(\"qom-tests: %s.%s: get failed: %s\",\n+ type_name, prop->name,\n+ error_get_pretty(local_err));\n+ error_free(local_err);\n+ continue;\n+ }\n+\n+ if (prop->set) {\n+ if (!object_property_set_qobject(obj, prop->name, value,\n+ &local_err)) {\n+ error_report(\"qom-tests: %s.%s: set failed: %s\",\n+ type_name, prop->name,\n+ error_get_pretty(local_err));\n+ error_free(local_err);\n+ }\n+ }\n+\n+ qobject_unref(value);\n+ }\n+\n+ object_unref(obj);\n+ }\n+ g_slist_free(list);\n+ qtest_send(chr, \"OK\\n\");\n } else if (process_command_cb && process_command_cb(chr, words)) {\n /* Command got consumed by the callback handler */\n } else {\ndiff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c\nindex 051faf31e14..5f4588b128d 100644\n--- a/tests/qtest/libqtest.c\n+++ b/tests/qtest/libqtest.c\n@@ -1121,6 +1121,12 @@ void qtest_module_load(QTestState *s, const char *prefix, const char *libname)\n qtest_rsp(s);\n }\n \n+void qtest_qom_tests(QTestState *s)\n+{\n+ qtest_sendf(s, \"qom-tests\\n\");\n+ qtest_rsp(s);\n+}\n+\n static int64_t qtest_clock_rsp(QTestState *s)\n {\n gchar **words;\ndiff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c\nindex 6421f2d9d9f..cf4c6b5add5 100644\n--- a/tests/qtest/qom-test.c\n+++ b/tests/qtest/qom-test.c\n@@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname)\n g_free(path);\n }\n \n+static void test_qom_qtests(void)\n+{\n+ QTestState *qts;\n+\n+ qts = qtest_initf(\"-machine none\");\n+\n+ qtest_qom_tests(qts);\n+\n+ qtest_quit(qts);\n+}\n+\n int main(int argc, char **argv)\n {\n char *v_env = getenv(\"V\");\n@@ -238,6 +249,7 @@ int main(int argc, char **argv)\n g_test_init(&argc, &argv, NULL);\n \n qtest_cb_for_every_machine(add_machine_test_case, g_test_quick());\n+ qtest_add_func(\"qom/qom-qtests\", test_qom_qtests);\n \n return g_test_run();\n }\n","prefixes":["41/41"]}