{"id":2229144,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229144/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-38-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-38-c413f3605311@redhat.com>","date":"2026-04-27T19:42:37","name":"[38/41] target/riscv: fix general_user_opts hash table leak","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"72fb9fc47cafc66a4b669eb885be59c130bb5dd1","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-38-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229144/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229144/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cZM+23B4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Dfk3LcWz1xvV\n\tfor ; Tue, 28 Apr 2026 05:49:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRut-00030N-7I; Mon, 27 Apr 2026 15:46:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRuW-0002kx-Gf\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:30 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRuS-0000EP-SH\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:27 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-10--tR7JTepPMSEozC2RIB65w-1; Mon,\n 27 Apr 2026 15:46:18 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 560AF1800464; Mon, 27 Apr 2026 19:46:16 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D29D8300070A; Mon, 27 Apr 2026 19:46:14 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319183;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=l6i+QH3SjfjPRSHNBCrqV1LYOaaUKzs1HKnK3Bilxho=;\n b=cZM+23B4J8odJSHwdE6FaVi1B8mv+JJ7pfwwewCEp/VE4rrn+/6z3fkdC0Z07VrEBOSXVi\n K28bAhFHyrrwwTZFZnQckPn80y0Pc+7URQjxAYKLRk8foXUqdKFKFIPJN32U56n9cwOVY9\n wN68YfYdpjNVYBx3OD4/Va0Qi1ciI9Q=","X-MC-Unique":"-tR7JTepPMSEozC2RIB65w-1","X-Mimecast-MFC-AGG-ID":"-tR7JTepPMSEozC2RIB65w_1777319176","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:37 +0400","Subject":"[PATCH 38/41] target/riscv: fix general_user_opts hash table leak","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-38-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Palmer Dabbelt ,\n Alistair Francis ,\n Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1716;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=ohWQ4ogs9grZ7aGeieqq2xi6Mm2yl57k/5oP/ZyoGyE=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWY7ZTkeW15/SrtnvRCsP8KCpaGLL3aZisI\n pRCltWKIoiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac\n 5U86D/9GvHmn4W0G0j6vfpJCCGnTQ2XR7qJeScmBMKakAQUe6RPe/nHP89IE7igLhDyEE3Ny9Ve\n 3jLmsIiyOLLH8ppP7KbAHow0mfL3ScJbW96VBhkSzUeEHNKVtdi6ruuvQG106nz+E0KiPsTG1vt\n sP179uozxOdWO+T0sAxs8TBDDAnJxsdOTsPk8KJfBFl4HXmGPXS2nL07aElPJRafRlfyjI+qQIu\n fqqw9OMjb7aMf0SFCo4ZTQC8gslVnVp7rAkihQ6Y3bSKFtHVbileJ79pJoP6scKp8//R6n7h4YC\n rXMDS7qhTzJvkNSr/4mEX8IqZ97KLJM2RYMiSNbrWJXou9riUGdLI/n4UVTcyF3st78i7O31pZZ\n +pkdJsHT5CIjchStuhDbG2go+8vmdgIw0HRZSNKpj9XiewgwfHUcKvPdKwnW8lq5Q4FFPpEXdrd\n 4Am0/6JsQzMZq0TqJngerTueAJED3jOwxMMUr5WkX8oMqnMiVA9dUyJ3qg1e9ldg3T0lm5jt5jI\n pzA2DC/z3hEqQe3GRlux9BUPGHcQyaTF1bb69fviGOk26DqmUd9UsM/9cHPa/u/x5zf/j+lVBGb\n vtcgUR2SxZdSc8Y1Zu1tjiazmfwoe+2wwMFVY0btwhOR2AZJIe8xQEb1s5BpnmpGomEKMQmKbfI\n f1Z3kDEDrdrrUBA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The global general_user_opts hash table is recreated on every\nriscv_cpu_init() call, leaking the previous one. Clear any existing\ntable before creating a new one, and destroy it on CPU finalization.\n\nFixes: d167a2247ede (\"target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_cpu_properties[]\")\nSigned-off-by: Marc-André Lureau \n---\n target/riscv/cpu.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c\nindex 8ac935ac06e..15fa03e22a4 100644\n--- a/target/riscv/cpu.c\n+++ b/target/riscv/cpu.c\n@@ -1101,6 +1101,7 @@ static void riscv_cpu_init(Object *obj)\n \"riscv.cpu.rnmi\", RNMI_MAX);\n #endif /* CONFIG_USER_ONLY */\n \n+ g_clear_pointer(&general_user_opts, g_hash_table_destroy);\n general_user_opts = g_hash_table_new(g_str_hash, g_str_equal);\n \n /*\n@@ -2961,6 +2962,11 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)\n DEFINE_RISCV_CPU(type_name, parent_type_name, \\\n .profile = &(profile_))\n \n+static void riscv_cpu_instance_finalize(Object *obj)\n+{\n+ g_clear_pointer(&general_user_opts, g_hash_table_destroy);\n+}\n+\n static const TypeInfo riscv_cpu_type_infos[] = {\n {\n .name = TYPE_RISCV_CPU,\n@@ -2968,6 +2974,7 @@ static const TypeInfo riscv_cpu_type_infos[] = {\n .instance_size = sizeof(RISCVCPU),\n .instance_align = __alignof(RISCVCPU),\n .instance_init = riscv_cpu_init,\n+ .instance_finalize = riscv_cpu_instance_finalize,\n .abstract = true,\n .class_size = sizeof(RISCVCPUClass),\n .class_init = riscv_cpu_common_class_init,\n","prefixes":["38/41"]}