{"id":2229143,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229143/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-32-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-32-c413f3605311@redhat.com>","date":"2026-04-27T19:42:31","name":"[32/41] hw/tpm: free PPI buffer on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7bc72685f512a5b4e7a6fc1b19d7f3613ca69f97","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-32-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229143/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229143/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ys4DuV4i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Df96tHrz1yJX\n\tfor ; Tue, 28 Apr 2026 05:49:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRts-0000sB-Av; Mon, 27 Apr 2026 15:45:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtp-0000Xi-Qw\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:45 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRto-0008S2-CB\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:45 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-3VYbIdaWPZuPSMTDml-vpA-1; Mon,\n 27 Apr 2026 15:45:39 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 09F9E180034D; Mon, 27 Apr 2026 19:45:39 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0A25619560AB; Mon, 27 Apr 2026 19:45:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319143;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zwr78nSyzsd0DrKYZjmxnd5WP2JnUPCWfhydW/PE7V4=;\n b=Ys4DuV4iNqd9xgEckAUwPGosNp389MwQPkXj5HMTIZs/JqBLOUJxcfywPGhSVNuRNM6vnF\n yIhj+ucRJ/nQP6KAwi9EmjPsBzQ5WjyiaesBpCb6ouuB072OOzwV3WQX8OVQPaA9ETQkA6\n tc5Xt7qzeoxpU+Z8GfjPVAK+XsLZEoE=","X-MC-Unique":"3VYbIdaWPZuPSMTDml-vpA-1","X-Mimecast-MFC-AGG-ID":"3VYbIdaWPZuPSMTDml-vpA_1777319139","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:31 +0400","Subject":"[PATCH 32/41] hw/tpm: free PPI buffer on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-32-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Stefan Berger ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1258;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=U9Mzlvq0rrjlmHM8sXAmGAsGCpP4e3dRZe1kgmOmuHM=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVDJwLi20apizk6puKvICJAKyj3t1kRPDZ3\n HhkiYxNrbuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5Zz5D/91pAuelqe9FJFUKfA88vofp5pVr+PVjRqjfFbDYiXdq6pmbbzfk3OL8U4pAxbzMFNGl1k\n OG4wkTO4SVOICrWW94i/hKDB38BBypqupIfbi2EThhyrTaWqnnjEewNgfpBqog2hEPVK1bXN+1D\n hiD2Dsm8enOevm6LMObEa+4AZrhOTsLz2QGoVNtSY5fkQ/vcgxMnkLjCP2yzHPSBndmYfHRy7mC\n APPTamZf+la66ZcuVfC42RrJGkl51NZ0cAZTjMjzdaq1fh4J+qOzemOywGBk6RtFkjhMEKaRQWq\n qz4acAexpo31TFMUoBO2dJoU8hm5TatkCnbKZI0qA4wWWpWlV1S/ByW9vXG586bHv8XmfybzD12\n b1xhWTCqMYu9DMw4PahmFBTq1lCdh+3/37KwB0GBxYcUU2p/prJzDvk0vTfRkH1S/Nd9sHit/GO\n tKKRcwlwmoyIQxrOTT9Ly3x0aYnZUGMsoKyoNvUtKQQOA1PhAec1ycfj2sT2ZDZpDHhEkKvE2/b\n ha0xvP31EG7RPpOW//3uX2MFPNi00vZ4DuhlnN0V35rhCU1MzXU43BZtqPmNwp2wlCFPt4yWR24\n edEs5GynMqQeV+HHnJDEGyARvDNJe6Ek9LPEhDO2ozCdQKiAI1E/ABOF9IgkcZngMbV3+VY1pHk\n gOL9WKSAD4EsKIg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The PPI buffer is allocated with qemu_memalign() in instance_init but\nnever freed when the device is destroyed.\n\nFixes: 46cd2c1050f0 (\"hw/tpm: add PPI support to tpm-tis-device for ARM64 virt\")\nSigned-off-by: Marc-André Lureau \n---\n hw/tpm/tpm_tis_sysbus.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c\nindex 6bec30c36fc..891766ee03c 100644\n--- a/hw/tpm/tpm_tis_sysbus.c\n+++ b/hw/tpm/tpm_tis_sysbus.c\n@@ -150,11 +150,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, const void *data)\n set_bit(DEVICE_CATEGORY_MISC, dc->categories);\n }\n \n+static void tpm_tis_sysbus_finalize(Object *obj)\n+{\n+ TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(obj);\n+ TPMState *s = &sbdev->state;\n+\n+ qemu_vfree(s->ppi.buf);\n+}\n+\n static const TypeInfo tpm_tis_sysbus_info = {\n .name = TYPE_TPM_TIS_SYSBUS,\n .parent = TYPE_DYNAMIC_SYS_BUS_DEVICE,\n .instance_size = sizeof(TPMStateSysBus),\n .instance_init = tpm_tis_sysbus_initfn,\n+ .instance_finalize = tpm_tis_sysbus_finalize,\n .class_init = tpm_tis_sysbus_class_init,\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_TPM_IF },\n","prefixes":["32/41"]}