{"id":2229141,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229141/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-28-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-28-c413f3605311@redhat.com>","date":"2026-04-27T19:42:27","name":"[28/41] hw/i386/pc: free pcspk on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a089512ad10636b67707fbff5771a9a575e4b6fa","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-28-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229141/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229141/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=I7JsGtKR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Ddp3vXHz1xvV\n\tfor ; Tue, 28 Apr 2026 05:48:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRtV-0006KE-9f; Mon, 27 Apr 2026 15:45:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtP-0005ic-Te\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:21 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtO-0008JZ-E1\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:19 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-_XWIiMtdN8Civ23OQsMPyw-1; Mon,\n 27 Apr 2026 15:45:15 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 06718195605E; Mon, 27 Apr 2026 19:45:14 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AC874195608E; Mon, 27 Apr 2026 19:45:12 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319117;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fVTOEc0IiI6uSpSRFYv4vHJMS6ES4xPhZF55+W0yW6Q=;\n b=I7JsGtKRs+ugn4y+UHR3ROniHx2u6An60LNANDNP49Ejj/RE6Gzq+L5oTfw/H7vM6YlHKb\n uvsewnYRr6NuKMUI2TZiJuG8BxdmUJPsTD8kFpt8bdjtcuWS7/8GROSMUvKhr4//0wRg+E\n nC1RJbOODHSqmjWnGxf5//OuQU+SvKs=","X-MC-Unique":"_XWIiMtdN8Civ23OQsMPyw-1","X-Mimecast-MFC-AGG-ID":"_XWIiMtdN8Civ23OQsMPyw_1777319114","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:27 +0400","Subject":"[PATCH 28/41] hw/i386/pc: free pcspk on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-28-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Michael S. Tsirkin\" ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1234;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=MMJi309YeIRVDxOCPmIe2ejVLAl8h+a+IJoTKniQZdE=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVLJBf9rSI+B0oe3XCCh6vD74yXpagfvXIO\n cVXYf8T3NWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5VN3EACwyykIpeyhUnQ0CYMUrtu+T+pAzyxXXo4QYTpGGiZZllZlHuZTSIWQRhGDTE17uvZxobF\n KrAcHSUj9b7A0fPyyNQ2bxdwfY/5SvQve2xuz8hyUaDlABO2tROfnRp6KO7YJYoVhN2HXRndFyk\n W4nMtfU1m9XIE3B38s/DhonuGcgH3Iggj6v76fY1WuO2PW7KKf5Hk9sCcovdE3h4ZrYFOvUXaZC\n 61kHemP6UWJlAwHUFBt1R+m9qJlifsuAnORj+zS15sicXdzTxLQi/NEunc/TttYeNSAZcA56unV\n otWvyzxVOgVcWw9dprKc8TiBEMoDpzYgfwA1ekCCDANs0N9TF/hKy91ZYvEG7yjvXe65SrRjKyi\n dhaU9BEc7qunbLKsD6pGaiH1l4KPgBmf2fuZEXsa+FBqFuS+cpoKrLd19OZxWcNcb/5/xKu3VPq\n DjAuJ/j6JldvzzQRpEd5KO8N27pkWtEF5oWi9QfG6za+KFH0VoF7UPWNlapIbec7qHk4UaSl3bT\n 7P7whEF4l07S5jkznz1wudVjgEatyHn3imreNjnPxflceyzKFqZt1o/HyK7Nwa10tpQsXywCRR+\n HuY6yHkoB8EQ4EpCCX1Uoqad8I0Z25LFrCmiZ9S/DHeg8tpk+eC7CUd556VZ8v4zWRLzIu/iAeB\n 1rU0PMWyJSFgnpQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add pc_machine_finalize() to unref the pcspk device when it was never\nrealized. Once realized, the bus owns it and no action is needed.\n\nFixes: 6b8d1416482f (\"audio: create pcspk device early\")\nSigned-off-by: Marc-André Lureau \n---\n hw/i386/pc.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/hw/i386/pc.c b/hw/i386/pc.c\nindex 2ecad3c503f..7b6ad97e5a9 100644\n--- a/hw/i386/pc.c\n+++ b/hw/i386/pc.c\n@@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj)\n }\n }\n \n+static void pc_machine_finalize(Object *obj)\n+{\n+ PCMachineState *pcms = PC_MACHINE(obj);\n+\n+ if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) {\n+ object_unref(OBJECT(pcms->pcspk));\n+ }\n+}\n+\n static void pc_machine_reset(MachineState *machine, ResetType type)\n {\n CPUState *cs;\n@@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info = {\n .abstract = true,\n .instance_size = sizeof(PCMachineState),\n .instance_init = pc_machine_initfn,\n+ .instance_finalize = pc_machine_finalize,\n .class_size = sizeof(PCMachineClass),\n .class_init = pc_machine_class_init,\n .interfaces = (const InterfaceInfo[]) {\n","prefixes":["28/41"]}