{"id":2229138,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229138/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260427-qom-tests-v1-37-c413f3605311@redhat.com/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.1/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-37-c413f3605311@redhat.com>","date":"2026-04-27T19:42:36","name":"[37/41] hw/ppc/pnv: drop extra ref on PHB after adding as child","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"017e95fc07e121337ddcd3bb7ccc11fbabf58940","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260427-qom-tests-v1-37-c413f3605311@redhat.com/mbox/","series":[{"id":501715,"url":"http://patchwork.ozlabs.org/api/1.1/series/501715/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=501715","date":"2026-04-27T19:41:59","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501715/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229138/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229138/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EWh8u/WA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Dch6gtHz1xvV\n\tfor ; Tue, 28 Apr 2026 05:47:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRuq-0002qV-F4; Mon, 27 Apr 2026 15:46:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRuL-0002kJ-48\n for qemu-ppc@nongnu.org; Mon, 27 Apr 2026 15:46:27 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRuJ-0000DB-IL\n for qemu-ppc@nongnu.org; Mon, 27 Apr 2026 15:46:16 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-6hGOBmWaNsW2Vm7aygMAgw-1; Mon,\n 27 Apr 2026 15:46:11 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 7FCEA19560AA; Mon, 27 Apr 2026 19:46:10 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 41E9119560AB; Mon, 27 Apr 2026 19:46:08 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319175;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4tw5Pz6kISkF6KqFnDKbV4J48BYB8c89DHYYaZAxmEg=;\n b=EWh8u/WAyMpsoPp7SteRKNPl96uNDtpXgd2eR928j+39LiDiDJXFvif1VuK8CWKUmDADt2\n n54SGcxFM7GscIzhCyINI8QwuNXmUZllXcHdiriNqpTXAODE8dtRY89opV8DMSZRVZltMW\n uE376M8/LaNGuxhVkxcxgRKxVcusiko=","X-MC-Unique":"6hGOBmWaNsW2Vm7aygMAgw-1","X-Mimecast-MFC-AGG-ID":"6hGOBmWaNsW2Vm7aygMAgw_1777319170","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:36 +0400","Subject":"[PATCH 37/41] hw/ppc/pnv: drop extra ref on PHB after adding as child","MIME-Version":"1.0","Message-Id":"<20260427-qom-tests-v1-37-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Nicholas Piggin , Aditya Gupta ,\n Glenn Miles , qemu-ppc@nongnu.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=839;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=hrUoAdeW0FsiiSJDTGr0GcRKIqh6cuaaSL1z6lxFAPo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWqiCTtJuQDEw1RwUnMaqqC9IuLDAg5htXc\n iWgqpDwb2aJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac\n 5bTtD/4+7qNBB2zipjY6/9ow4dez0YcGW8jeo7FfiSriSWCiRV5J/uE0n7KNEUNatQlwaw5p+Yq\n PRx5+iF8tHO/40LRPmOqJ9cjHs0kLSP/Mo79BBqtf18G6Yk1luw5YsqHD3kndx4UPTr9NyV04By\n fgK1yGm9NPDgmo2HgmleG4shId/Lss5LS5FC6B2bP7V/Nlub/RFeKNZjhJ6BNBrOlhC858xCAhd\n RsbRQCTnRA6g5i22UJI7TDaRu9NNd5qaEZ1GJlut7pcjb+cBA7jpDvkNkY6cBtDpvP9UOGjm+mR\n CuLkUs/EpeOZcKXGMT43Dq8UvDLnLoBh1X7sSo7e652uLNJ9N9kgFcJV4SBSyd8420AwG3oEZLh\n X90OkT05/X8Q68Jwy/FFSpCiOMliHnjc6dPW4ppC4c0wHvHIqP/ovJHq2eopx43RwFguiPvqjKs\n Uzu3RCca+C8GYJ/erFXcmC018L4efyzCcskgcmSgeHDgUotQlrgt5gjljBOyJ1bVM3QHjm4zUH6\n 28c8laCYZ13v+RVARC9R2k4us2gu1YcRQUXv1lLoo+TiNao3BBuXreSXRzxF6+mt9m/OYIM3QZo\n jQx2+WDBTYvvMVbYHAvqjFcgF0Xsf6sF3rZ73/ZUJKNwHIr1EyvCtJnR5dRTXug6C6LIppnws8j\n ugX8WebIMfcDVzA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-MFC-PROC-ID":"Ru8UvLRFNqDw40YA15rDB6wTlQmlIbvycwtSzoAwZTA_1777319170","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"object_new() returns an object with refcount 1, and\nobject_property_add_child() adds another reference. The initial\nreference must be dropped so the parent becomes the sole owner,\notherwise the PHB objects leak when the chip is destroyed.\n\nFixes: 0d512c7120a2 (\"ppc/pnv: turn chip8->phbs[] into a PnvPHB* array\")\nSigned-off-by: Marc-André Lureau \n---\n hw/ppc/pnv.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c\nindex 524563dcfc2..476255b722f 100644\n--- a/hw/ppc/pnv.c\n+++ b/hw/ppc/pnv.c\n@@ -1590,6 +1590,7 @@ static void pnv_chip_power8_instance_init(Object *obj)\n */\n object_property_add_child(obj, \"phb[*]\", phb);\n chip8->phbs[i] = PNV_PHB(phb);\n+ object_unref(phb);\n }\n }\n \n","prefixes":["37/41"]}