{"id":2229135,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229135/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-30-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-30-c413f3605311@redhat.com>","date":"2026-04-27T19:42:29","name":"[30/41] hw/gpio/pca9552: fix state_str leak in pca955x_set_led","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5e5f937d6c8b25284097ddaac03525bc739d4c67","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-30-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229135/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229135/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=C3lHIV+o;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Dbt17Pkz1xvV\n\tfor ; Tue, 28 Apr 2026 05:47:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRth-0007wE-DC; Mon, 27 Apr 2026 15:45:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtf-0007mG-6z\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:35 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtc-0008ND-SN\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:34 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-xZiJ-uQyMDCxZMmiLV_ZfQ-1; Mon,\n 27 Apr 2026 15:45:28 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C42C0195606C; Mon, 27 Apr 2026 19:45:26 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7B483180045E; Mon, 27 Apr 2026 19:45:24 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319132;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4KHj4DqAixgKGdHuYS54zcv/K3U7GmPCNfmzT2qJpNY=;\n b=C3lHIV+oP7m9d7Z+LlXaukVExa2UNek9LeewYheemZGctSOP0IDIyuAILDFj4p8LLGTf+2\n KyvmPcMerWVGILbm1NcUm+jfHVjoGhSfkD5UXbIRTZZVC1dR60g4XC5ocWIzDqXelS/sUe\n 1UByROZtBMzD3EbB/SUxLvD/wXuFRLY=","X-MC-Unique":"xZiJ-uQyMDCxZMmiLV_ZfQ-1","X-Mimecast-MFC-AGG-ID":"xZiJ-uQyMDCxZMmiLV_ZfQ_1777319126","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:29 +0400","Subject":"[PATCH 30/41] hw/gpio/pca9552: fix state_str leak in pca955x_set_led","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-30-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Glenn Miles , qemu-ppc@nongnu.org,\n qemu-arm@nongnu.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=823;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=3S6fSXjyZtEol8E2g5mMSZCzx5rxZBsHBZ3CL9TbmuI=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVK0C4iwVzskgkTX0g6J8GOfDk4Lj2dMQhL\n 4AV5EeTFvGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5VHpD/9YHfDTPdbCHzUL6KTtqT0i/O/aHZyHqX7yD4Ha0REqGtpXWx47X3ryM9XRoxJamQmB/3y\n dRyMB1xcwSkelCHeK7Z6dXvRFfzQZXRFmM3+XpJRI5/H4f0JL7yigKGb7jTipSgYzhq+ugfQms3\n USgNG4zcM6VGQLfv9NR6GM5vCluwgHl4ktZaO3usjCC79SwUTry6ESajrYg4JvYID/HWB/ekC1y\n M7cn5VjWvAFgaPJ6V9hkEystqETGOnpqoKcSjd1+yq/jnPL1ZiSfRbAi/kUYvoJC2fdAXVIhkpw\n coiA/8U2WfuWzb21hkG2Lb82Yvks7GhdNxUV+qkttbTYWuNaX7DeUq7IABFMy67adCS/qTBiAJZ\n SaPVZvtRfdGlNi3ZzhAyHXi+fBjY7CMDPwzK7PYfTfQj3eYMq532hO4N+Au4FA/JyzH+QH8tbjS\n P+ESBFuHlScLIryYBVVDB7c3QlfA2vIhbXILUVfI9Ms5XfnzCqNb1/gPdTDssNvbXRv6NexlExo\n Sohd+C1Uvj3gPJz8q1X07X5slARIlUCEM3xDAJB+8lLrj+ueyBGHtq5/ZaAJ8G0MTHKtxTGfiUm\n XOSSb1b/n5Qle6/MXuyiy4spVpzLB7bR/WJ7+Tq22Ob5wAgvPvL4EKBmFbghsT4Z7E5UzrIExiJ\n ioDNpKJD2mgzakQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"visit_type_str() allocates state_str, but the function never frees it\non any code path. Use g_autofree to ensure it is freed on return.\n\nFixes: a90d8f84674d (\"misc/pca9552: Add qom set and get\")\nSigned-off-by: Marc-André Lureau \n---\n hw/gpio/pca9552.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c\nindex dd3f1536b65..472d8ad9571 100644\n--- a/hw/gpio/pca9552.c\n+++ b/hw/gpio/pca9552.c\n@@ -342,7 +342,7 @@ static void pca955x_set_led(Object *obj, Visitor *v, const char *name,\n PCA955xState *s = PCA955X(obj);\n int led, rc, reg, val;\n uint8_t state;\n- char *state_str;\n+ g_autofree char *state_str = NULL;\n \n if (!visit_type_str(v, name, &state_str, errp)) {\n return;\n","prefixes":["30/41"]}