{"id":2229134,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229134/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-34-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-34-c413f3605311@redhat.com>","date":"2026-04-27T19:42:33","name":"[34/41] hw/arm/virt: free flash devices and OEM strings on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"609c2487f62b9bc85a099e058191f698caeef9db","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-34-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229134/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229134/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Wmd+6lx8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Dbq0pjWz1xvV\n\tfor ; Tue, 28 Apr 2026 05:47:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRu5-0002KF-LP; Mon, 27 Apr 2026 15:46:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRu3-00029E-M8\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:59 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRu2-0000AS-7U\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:59 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-L27mdzMwMXW_UBxAymJhQg-1; Mon,\n 27 Apr 2026 15:45:52 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 80B53180065B; Mon, 27 Apr 2026 19:45:51 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 04833195608E; Mon, 27 Apr 2026 19:45:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319157;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1c8VsTz/sTG4tzp9Faceii6mKYJmoEBKWa3DjmDQEWE=;\n b=Wmd+6lx8wSGw0mmYKzeE7L+VtI15wFRghR01JPd5gtjQo008T2dq1Urqpyd/v12qlDG+6B\n EOTJ1pKE95LCVTJm6nDQ7Xt3dYUrGLa9iGCRluD+Q04lt3yfVivUxOzuQeB251GtCB9iD+\n obuYHJtURkfChUtK5rlOCxQ5uFQ1bHA=","X-MC-Unique":"L27mdzMwMXW_UBxAymJhQg-1","X-Mimecast-MFC-AGG-ID":"L27mdzMwMXW_UBxAymJhQg_1777319151","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:33 +0400","Subject":"[PATCH 34/41] hw/arm/virt: free flash devices and OEM strings on\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-34-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Maydell , qemu-arm@nongnu.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1638;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=o92YyJD/bOFOENYE87KlzSXzoL53pQjL+BGFBW2kk0s=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wW48UjKTU8KoPx74n2xI5CJTczJW/EUjYlC\n R3ZW1ir2jmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac\n 5WoWD/9dw9rvRCWsv0ETBfKlzGEEGcrQO1E77pa4/nW2MaZjxOBMlucGXfhnDoQBBMD4PVg8I9z\n f02jLPGBD6CN8wQcbCkG24hYz42o3oxxu7fb2Vbhklx+U4aH5HnjnTPA7darMNvF6NTynKIdqXQ\n +Fdrs1fbQKScqWWRQ5Lgg/gOH2XFAKMEebv0B+2lN0pbU5/c2ju6CR+IeoL1hjtGfAsjELlTAb3\n J6u5gAIWdWRq3GsyALc3CLeWy+xAUP7q7FYXvETchMa6rkpM7BEIbW7YVnXipqwZEw19bpjrRxE\n xHs4OdrK1Ei1AeavuXn2ZDpSkWw0NVVaoYuAXENLYO74j4DbF9zPAMnXO5iFJ9X43DsaqBZOXZx\n Y6XNAcchBzGg24RQvz9YB2xlL/bMCylsdzDZFtDAvO+q98SOnh0qop2MFpTGTeSkCGPvfmFikwv\n M7cF54ulM5wpU+rYmlwekDKJezkDNw4P4psluQeDwau7v+jrQQAAdq1THoMrPr+PHh6wISNpEXc\n AOoLaO6fq2Xyeh2BSBtnhKqk6j9h1U+NAS+YkSKfkaAs/8rPh9aL3POG2rkXPWEYnLLpSlbpvDG\n wOIXVlM1Sr68v54HJVNOf0Lz9bCRYimvm1X2RpcAETQwzAKiqM3NjASLoNnRdh5sr7tB9BDH9Jl\n 9VwjIDwjIxrEeFw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Flash devices created in instance_init via qdev_new() hold an extra\nreference that is only dropped on sysbus_realize_and_unref(). When the\nmachine is destroyed before realization, the flash objects leak. Also,\nthe oem_id and oem_table_id strings from g_strndup() are never freed.\n\nFixes: 602b458201ff (\"acpi: Permit OEM ID and OEM table ID fields to be changed\")\nSigned-off-by: Marc-André Lureau \n---\n hw/arm/virt.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/hw/arm/virt.c b/hw/arm/virt.c\nindex f62253e1aba..fac825ccd47 100644\n--- a/hw/arm/virt.c\n+++ b/hw/arm/virt.c\n@@ -4032,6 +4032,19 @@ static void virt_instance_init(Object *obj)\n cxl_machine_init(obj, &vms->cxl_devices_state);\n }\n \n+static void virt_instance_finalize(Object *obj)\n+{\n+ VirtMachineState *vms = VIRT_MACHINE(obj);\n+\n+ for (int i = 0; i < ARRAY_SIZE(vms->flash); i++) {\n+ if (vms->flash[i] && !qdev_is_realized(DEVICE(vms->flash[i]))) {\n+ object_unref(OBJECT(vms->flash[i]));\n+ }\n+ }\n+ g_free(vms->oem_id);\n+ g_free(vms->oem_table_id);\n+}\n+\n static const TypeInfo virt_machine_info = {\n .name = TYPE_VIRT_MACHINE,\n .parent = TYPE_MACHINE,\n@@ -4040,6 +4053,7 @@ static const TypeInfo virt_machine_info = {\n .class_size = sizeof(VirtMachineClass),\n .class_init = virt_machine_class_init,\n .instance_init = virt_instance_init,\n+ .instance_finalize = virt_instance_finalize,\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_HOTPLUG_HANDLER },\n { }\n","prefixes":["34/41"]}