{"id":2229131,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229131/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-35-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-35-c413f3605311@redhat.com>","date":"2026-04-27T19:42:34","name":"[35/41] hw/loongarch/virt: free flash devices and OEM strings on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc1bdf9aef0de57424d82341c76b7ffa483b784a","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-35-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229131/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229131/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LblhJczX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZv4NCLz1xvV\n\tfor ; Tue, 28 Apr 2026 05:46:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRu8-0002UZ-Qx; Mon, 27 Apr 2026 15:46:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRu6-0002QZ-Vh\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:03 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRu5-0000B4-F7\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:02 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-N2PSMl7XO-KlPkVH-a3LGQ-1; Mon,\n 27 Apr 2026 15:45:59 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E46FD1800245; Mon, 27 Apr 2026 19:45:57 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 90858300070A; Mon, 27 Apr 2026 19:45:55 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319160;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7KmAH1cH3IHfFz390iyZWiA2Urz4yiNrRXozv9253eI=;\n b=LblhJczXqqc7kXRh4zpZE0KVFyMZ1c+Og7o4/4+LG1BHAwQIO8CEAwUuIgb7U6GOAKQVN0\n G+4a6y7KjOIooGz2oyvwOtgLmjxlzEQ3B/iHwVIMFTjNZX1zHu9BMTNwo1FrlG3JOvDzmM\n QlBKPc38JUqJ05lk+EV4qryhAkD0a8E=","X-MC-Unique":"N2PSMl7XO-KlPkVH-a3LGQ-1","X-Mimecast-MFC-AGG-ID":"N2PSMl7XO-KlPkVH-a3LGQ_1777319158","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:34 +0400","Subject":"[PATCH 35/41] hw/loongarch/virt: free flash devices and OEM\n strings on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-35-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Song Gao , Bibo Mao ,\n Jiaxun Yang ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1735;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=dxCTCxNaCfORhGdQQtAC7ccm1POGZcOgxYtSD5YETCc=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wW+05ardbd/hj7Op+m929pAm4FEmkm9Ust2\n E8ltKtHXE+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac\n 5RJjEAC4Ifcaa17MbvTtqopgNgrGGBodzZ4MuMz7lEs19qyQ0UUYrCsD9GZoAmK158d1+dJcqro\n pLB6wS6jjTr7L2yoyLGDox/I4yMg0/4YQr3RLvYx+IDNTA/kQ3V7h3870AOQ5qRXaOfZth0rcC8\n o7TxUwUZ5lqbV+sMsH26AEUPjuRf2ecduQ4inG+K0agz6+I3z3Ry123sQ2rGvUp7YvpAtpNCtxB\n JyCKb6hlcXVx2EDVjZW/lgSBIYqYcDHPKJkadQBudDpYvrtpPdGMX9mlDq/GUdBT4x1TnjLsrmz\n u/Z+1RRtif7fsatjHXpMCB6mx00RnvI8lGnQ9Aeb044XuWu/d9bHDlRUY0oySgGJujeWW8g2a1U\n zkfbdCgAlFV1BZu3f5DQ5KhoaT7inHPWcJ5BPObGv0Sa6EmUlLjVxS0YqItjZx46h/+OgbOU3E2\n dDs2F/zVvfzI5H6KW1mXmgstTcOKE6i9+wiNfGSfr+8MBtv+YbemIOQVa9eA1agvhGxc4XfwsV3\n f4+rt1dP1ORwUmp5L8xV5zmM4Lq1y9iT/El89a+k9cWaI1jbbvW64aRQK2eIiIOHq2b88+EL4sw\n 9uAVmCUK1wv7NbiekLXOvNqtqAQmCdNOPLOC2cED4Ok+3Vh0TMYg0BVzFiaEwO0xEnUJoSCq2c/\n aWVqWlWmGnBLplg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Flash devices created in virt_initfn() via qdev_new() hold an extra\nreference that is only dropped on sysbus_realize_and_unref(). When the\nmachine is destroyed before realization, the flash objects leak. Also,\nthe oem_id and oem_table_id strings from g_strndup() are never freed.\n\nFixes: 445c9c645 (\"hw/loongarch/virt: Allow user to customize OEM ID and OEM table ID\")\nSigned-off-by: Marc-André Lureau \n---\n hw/loongarch/virt.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c\nindex 2fc15261309..188fbc86c0c 100644\n--- a/hw/loongarch/virt.c\n+++ b/hw/loongarch/virt.c\n@@ -1535,6 +1535,19 @@ static void virt_class_init(ObjectClass *oc, const void *data)\n \"for PCI MMIO\");\n }\n \n+static void virt_instance_finalize(Object *obj)\n+{\n+ LoongArchVirtMachineState *lvms = LOONGARCH_VIRT_MACHINE(obj);\n+\n+ for (int i = 0; i < ARRAY_SIZE(lvms->flash); i++) {\n+ if (lvms->flash[i] && !qdev_is_realized(DEVICE(lvms->flash[i]))) {\n+ object_unref(OBJECT(lvms->flash[i]));\n+ }\n+ }\n+ g_free(lvms->oem_id);\n+ g_free(lvms->oem_table_id);\n+}\n+\n static const TypeInfo virt_machine_types[] = {\n {\n .name = TYPE_LOONGARCH_VIRT_MACHINE,\n@@ -1542,6 +1555,7 @@ static const TypeInfo virt_machine_types[] = {\n .instance_size = sizeof(LoongArchVirtMachineState),\n .class_init = virt_class_init,\n .instance_init = virt_initfn,\n+ .instance_finalize = virt_instance_finalize,\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_HOTPLUG_HANDLER },\n { }\n","prefixes":["35/41"]}