{"id":2229130,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229130/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-33-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-33-c413f3605311@redhat.com>","date":"2026-04-27T19:42:32","name":"[33/41] hw/arm/sbsa-ref: free unrealized flash devices on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dce57b98d54d896064dcc34293d2e67f876974e6","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-33-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229130/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229130/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NxjvNPvc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZp5xrgz1xvV\n\tfor ; Tue, 28 Apr 2026 05:46:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRtz-0001hk-Mz; Mon, 27 Apr 2026 15:45:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRty-0001a0-1N\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:54 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtv-00008n-Tg\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:53 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-_eoWI6QNPJ-W5oCIJLgS-g-1; Mon,\n 27 Apr 2026 15:45:49 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8302A195608E; Mon, 27 Apr 2026 19:45:45 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EA00330078C0; Mon, 27 Apr 2026 19:45:43 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319151;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=M2PkMqAC5vaH2G5gTELChNOqj8Q/G8/EbVxLibW6cbY=;\n b=NxjvNPvctK0kk/qPwmKQcJdlz/WKoAi6fFeu6KjE8A5+/4I7MwtnsIgPyM0dOolM7/jxRI\n 3s7Ey8IXqRX2p2sFjn44r0H+SshgeIAB/BUlw6E6PTpzz1aYbGR+TN0oFSQ4B/mRb0u01Z\n CgYnzqJXcXbdZofa0DjDa93Z3jLZmgo=","X-MC-Unique":"_eoWI6QNPJ-W5oCIJLgS-g-1","X-Mimecast-MFC-AGG-ID":"_eoWI6QNPJ-W5oCIJLgS-g_1777319145","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:32 +0400","Subject":"[PATCH 33/41] hw/arm/sbsa-ref: free unrealized flash devices on\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-33-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1629;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=8wpYSEdYwoIU5tUZLybA2hUuHMnCp+KlNmMB/+ET4dQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wV06CFj7hU2c0ZsBhZ0KcgP4PY3RTTUXEPN\n bRTQukYYHqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5eBIEACXMPEDc3nHnUDB7r7nxHaJQV7rnZW20f4A9ijvHe1etzhDlhofGT9nPrC9rOpd1x1ZbI0\n /82NqaELAEkcGEsU7U8xj7AYdKjPeoJG4/On99rxa3gtAptqfo84oHPEqV/PLmef1ghkA6rMDvQ\n t5wZWe2taCU3Xztf/bgENfdp7xq1meGpXdCzvT2dNC8800yc4n903es+6DJiL1H8jJBrKQoJ/SY\n sa26dFWazW4YkDx2pgCLtdJWt3aiK0LyVN9zlsLlHhKKV4kBLHQURLxJ1i10/oUMGLOTuEUkg0W\n uv9loq7oSH25EGtvVMSfFGIaVi+5zB0iL2lD7OW3am56GOT5y3yEaPt3Yh3QK9ExvNnMf26wT6b\n M0KsLYQqc3sZImyvd/VaN7uj2XXtOd3k7A52kUjr6aA1duMo/LddkHqIPTlXT3qZ5azcXPkynZc\n kb3zaSfiKnZlI0nNS7x9GmnWG4DKiHNHmUaR9g38u5Y1kzQgnn7ZvvyeU9CJJW08F2Jf8OUgI9X\n Ht7+Vp18PFksUIc37C2YJ4iTCJldw2WIIHMHNWkZE+f9g57DCzOpuVMqHn0EtQGJQLOVhxvKmNC\n zdkE2e72gujIwCbvubhl+oW+paYXtWNQSy9uYt/CNPjbizGkSzn3XA9R+lxTLLK2MuPFYK0nDGu\n dRo/021qlK179eg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Flash devices are created with qdev_new() in instance_init and added as\nchildren, but the initial reference from qdev_new() is only dropped by\nsysbus_realize_and_unref() during machine init. When the machine object\nis destroyed before realization (e.g. during qtest device introspection),\nthe flash devices leak.\n\nFixes: e9fdf453240e (\"hw/arm: Add arm SBSA reference machine, devices part\")\nSigned-off-by: Marc-André Lureau \n---\n hw/arm/sbsa-ref.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c\nindex 52c35e10c2d..484b90053e8 100644\n--- a/hw/arm/sbsa-ref.c\n+++ b/hw/arm/sbsa-ref.c\n@@ -892,6 +892,17 @@ static void sbsa_ref_instance_init(Object *obj)\n sbsa_flash_create(sms);\n }\n \n+static void sbsa_ref_instance_finalize(Object *obj)\n+{\n+ SBSAMachineState *sms = SBSA_MACHINE(obj);\n+\n+ for (int i = 0; i < ARRAY_SIZE(sms->flash); i++) {\n+ if (sms->flash[i] && !qdev_is_realized(DEVICE(sms->flash[i]))) {\n+ object_unref(OBJECT(sms->flash[i]));\n+ }\n+ }\n+}\n+\n static void sbsa_ref_class_init(ObjectClass *oc, const void *data)\n {\n MachineClass *mc = MACHINE_CLASS(oc);\n@@ -930,6 +941,7 @@ static const TypeInfo sbsa_ref_info = {\n .name = TYPE_SBSA_MACHINE,\n .parent = TYPE_MACHINE,\n .instance_init = sbsa_ref_instance_init,\n+ .instance_finalize = sbsa_ref_instance_finalize,\n .class_init = sbsa_ref_class_init,\n .instance_size = sizeof(SBSAMachineState),\n .interfaces = aarch64_machine_interfaces,\n","prefixes":["33/41"]}