{"id":2229129,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229129/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-27-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-27-c413f3605311@redhat.com>","date":"2026-04-27T19:42:26","name":"[27/41] system/qtest: free log path on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7745721e6e52fcb4cc1eb4807c0bee1cbee16586","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-27-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229129/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229129/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EryZjkP2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZg2MKcz1xvV\n\tfor ; Tue, 28 Apr 2026 05:46:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRtT-00063C-KM; Mon, 27 Apr 2026 15:45:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtL-0005aA-VR\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:19 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtJ-0008IW-OD\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:14 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-iMw9gmEtNXW4_wLa3d5IVg-1; Mon,\n 27 Apr 2026 15:45:09 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A64A918002C0; Mon, 27 Apr 2026 19:45:08 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 439D11800349; Mon, 27 Apr 2026 19:45:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319112;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=YDtpaZFoApAnKThlAbsCdyTdSRS0TaBslbFfhxXNOYc=;\n b=EryZjkP2JD1+dQy3gDDbGEtPNcPtcaB9g0qCI9jMrxMKv/+lIKhG+qmDZcXTgqABejFcUf\n j9ldWCBGiS/d6Yu0NdNheKNal2vAkqFY4AsOjsSaVAdg+fVrpfydDrZNxq76PG9JPrkRqj\n BWi4+MxpOCdUuN4+6JlA6Q0fzUZ/OnU=","X-MC-Unique":"iMw9gmEtNXW4_wLa3d5IVg-1","X-Mimecast-MFC-AGG-ID":"iMw9gmEtNXW4_wLa3d5IVg_1777319108","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:26 +0400","Subject":"[PATCH 27/41] system/qtest: free log path on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-27-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1002;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=oUcgYvxDMbjcVVL4+rKdZP5X8MfYcAB3srIVB+yU/jg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVdvi9M0Yk1HEjYko3i4AiOzhd0AUA6WlFM\n PcBHOgYyqiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5aKdD/41g/ze5sZI/CUX4VbJs9QyTFQhupKv7Hg0GMP9/C9C6bNjX7eYHBykzA4vuXuQ0Ifqo5j\n zIZRqkL4CK+Jzooni7ymGLUHLnfIFROx6xxls9y/D1PMKcXPAYJAtC5Vwyr+/TyJjgPc9gY8H02\n I1Djrsp1J1S3o6bLOq1nmzVwwXGbOEDPnacq098H9AnVaZ4dbEEL+2U2k6BI98m8dtvOpgxGNoJ\n eDy8Jv+xYC780qYw+tc/bl84ixLQ3X9UzExqqPkzL+bXyH2oqxkVGGBSekCcnBw6q7myabueT4S\n PX+9mclenH+AmGiuSIyP+XH8umCA3kHsiUVcMQwTHg7VigmsNe4x9lRAG57CUy6+SUoL5ZA3fj5\n zgLOuEC8YSglSfVcU7JylutW8HLcH9z+zb9dD+ILpu2+Bp6PgJHzqBtbxm3XF+4MkZJ2BFR92h/\n yuxUyT8ih5DBzarcACvX6Vpp27AIkd5yRGV7gZWRj/YXZ/DmlS9XK56Yj/1p2ROPw1wcGF2asbD\n pXv0nANtJBfOPpEsE8K0xZrqrtkYmDiWs2i5ZuZvNuM/6U7Jc+1tvwkbpkLgt8GlbqwviFENqxu\n FQMAqKS/u+dNR+43WxGq2nqk2TGVSRsWZVjQAE6fYPBKE/4y5RjPholQgRuco8G5f2SVGAf9RsX\n siRLzLfwkBsWNfQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"qtest_set_log allocates log via g_strdup, but no instance_finalize\nexisted for the qtest type.\n\nFixes: 6ba7ada3559e (\"qtest: add a QOM object for qtest\")\nSigned-off-by: Marc-André Lureau \n---\n system/qtest.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/system/qtest.c b/system/qtest.c\nindex cf90cd53adb..e9e5773341f 100644\n--- a/system/qtest.c\n+++ b/system/qtest.c\n@@ -1020,10 +1020,18 @@ static void qtest_class_init(ObjectClass *oc, const void *data)\n qtest_get_log, qtest_set_log);\n }\n \n+static void qtest_finalize(Object *obj)\n+{\n+ QTest *q = QTEST(obj);\n+\n+ g_free(q->log);\n+}\n+\n static const TypeInfo qtest_info = {\n .name = TYPE_QTEST,\n .parent = TYPE_OBJECT,\n .class_init = qtest_class_init,\n+ .instance_finalize = qtest_finalize,\n .instance_size = sizeof(QTest),\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_USER_CREATABLE },\n","prefixes":["27/41"]}