{"id":2229126,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229126/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-14-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-14-c413f3605311@redhat.com>","date":"2026-04-27T19:42:13","name":"[14/41] ui/console: remove console from global list on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b71cbebd80143b12b25f13b792de4267614ae0f4","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-14-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229126/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229126/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=CllAZTpT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZ30Dlcz1xvV\n\tfor ; Tue, 28 Apr 2026 05:45:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRsQ-00022Q-5C; Mon, 27 Apr 2026 15:44:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRs2-0001aT-SE\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:56 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRs1-0007vB-3O\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:54 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-ijAB9nJkNeaqWpZ13AfHCw-1; Mon,\n 27 Apr 2026 15:43:50 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E382A1956089\n for ; Mon, 27 Apr 2026 19:43:49 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8FC811800347; Mon, 27 Apr 2026 19:43:48 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319032;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=egYIv/p9RXUeDoiMYZq9As3HoDtdRyVZwD6hR7aG2Jo=;\n b=CllAZTpTPVT1oCUmFqnI06r/lJAzEykUA1izlTX9pf/sSXQ7X0nkqAbGBh/NMsmjGOT4Is\n VtZNwEWpVWLQxtD+JTVaATgVj9yBFaK8zcWW9DaIPQA4jJ5PBoH1sxp36cum/PWt+6QgzA\n KlS5ZWUVFNah2ROL5n6Eropt/jXi/os=","X-MC-Unique":"ijAB9nJkNeaqWpZ13AfHCw-1","X-Mimecast-MFC-AGG-ID":"ijAB9nJkNeaqWpZ13AfHCw_1777319030","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:13 +0400","Subject":"[PATCH 14/41] ui/console: remove console from global list on\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-14-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1404;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Wp7WR0az9Jyz+mnAyK07uOQyeMTXWYE2QIBV7PHHnZE=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUhOPyGzvb2BgMJUMAWRwr83cuFs2T6dHMt\n +33n93FZ/+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5Qe7D/9dBYxhksySVuJ9gtIVqop0gMCze1pLRzlTeAHdFVEl0Xtt8Fe24yynvJy5nV90Lc3uFZT\n RKgn+0b15JXgUJRcZppnlZhQ3YcFiwla8TuR0O0lcwZQmPl968sfTQTGLo5dg8F0vd5cmXpkFEA\n HajIQk5hPrQbGYOz6A5v0Aomse7DKtvq60qjtSensOhxKdHRFKaPKmHqfj+Zl5Yw6YqbUsjZfo8\n IxzIMMv2+8iJhpdk0nLJowobPfa9CvekyMGz//QPH73FcJ4xC1k6sgLnWMarB3vVRWfRXpVbIBt\n JN2F3pAYKWRVTh6AK0ShEvK+/duotjiLlUiHZ3VSQiwy5ci3z7E/t141SqLRQkiXHfmSbGTjm1i\n SvKxfX/6EYWxyYwakcxJllSqaj9oLPUmrPebLQKRSimQ6lpzxSFQ8pkNId9vnHzEfMBxzV4rqcP\n wGwOsuKVnPFY2OfxuEetyQSZEUsbaoBeSWdzsi2FjdO635ZZYyIXCZb/RM17Z2Q0gwARndat47N\n IZSuzG2EukcQDbLKKYCy3IQj/0lnmQR5OBxvNpHlxvMpgCSYYCT25Pj2I2BkHV3Dsd4D8+2IaI8\n j1I4/MFELMZquvPKd5/rGiyA+GDTM4li88ha7lpxfbIVFk9TJCVHqwvVmapZu0jOTaL26JCgRY2\n LWq9c5nZXgVlHBw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This commit removes the QemuConsole from the global \"consoles\" list when\nit is finalized, fixing use-after-free on throw-away objects.\n\nReproducer: QMP command qom-list-properties with typename\n\"qemu-text-console\", \"qemu-fixed-text-console\" or\n\"qemu-graphic-console\".\n\nThe assertions added ensure that `dcls`, `gl_block`, and the\n`dump_queue` are empty before removal, confirming the console is in a\nclean state. This is left to handle correctly in a future series for\nhot-unplug case.\n\nReported-by: Markus Armbruster \nSigned-off-by: Marc-André Lureau \n---\n ui/console.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/ui/console.c b/ui/console.c\nindex a7bd22515b9..fde8f50db21 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -394,10 +394,14 @@ qemu_console_finalize(Object *obj)\n {\n QemuConsole *c = QEMU_CONSOLE(obj);\n \n- /* TODO: check this code path, and unregister from consoles */\n+ /* TODO: fix hot-unplug support of consoles */\n+ assert(c->dcls == 0);\n+ assert(c->gl_block == 0);\n+ assert(qemu_co_queue_empty(&c->dump_queue));\n g_clear_pointer(&c->surface, qemu_free_displaysurface);\n g_clear_pointer(&c->gl_unblock_timer, timer_free);\n g_clear_pointer(&c->ui_timer, timer_free);\n+ QTAILQ_REMOVE(&consoles, c, next);\n }\n \n static void\n","prefixes":["14/41"]}