{"id":2229125,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229125/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-26-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-26-c413f3605311@redhat.com>","date":"2026-04-27T19:42:25","name":"[26/41] accel/kvm: free device path on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9fdf1eb2769fd6357c48d161cbcc3f2cb9fa0537","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-26-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229125/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229125/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YYQd2AwA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZ23VX1z1yJX\n\tfor ; Tue, 28 Apr 2026 05:45:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRtU-0006DM-LC; Mon, 27 Apr 2026 15:45:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtF-0005Nr-MM\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:13 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRtD-00087C-Lq\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:08 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-lz-EHQIzMRC18mRq1xyT0w-1; Mon,\n 27 Apr 2026 15:45:03 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id BFE8719560B7; Mon, 27 Apr 2026 19:45:02 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6B2D1180045E; Mon, 27 Apr 2026 19:45:00 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319106;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jswsE+qpixbv6iOMTTcNCxgSkRm1F5eNCKVbDRXPEJ8=;\n b=YYQd2AwAmx21tOQ3TjtUDUoD4Mk2su053npf8Vw/hkvE++3bwHjSWVAWlBnk2HDghDL9iv\n fVjSmG73Zr9Qvou8qCkZUMmDEvZMEaUsXj73qQjdSX5uSyaTtQIfkEmHyRuyr/kp0uJ9v8\n b9a3Ti6gfhkK6l5XZ4hUTNsghsQcfL0=","X-MC-Unique":"lz-EHQIzMRC18mRq1xyT0w-1","X-Mimecast-MFC-AGG-ID":"lz-EHQIzMRC18mRq1xyT0w_1777319102","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:25 +0400","Subject":"[PATCH 26/41] accel/kvm: free device path on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-26-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini , kvm@vger.kernel.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1040;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=kb8aCpIeuANYOHpQ9UF6rV+rRvi+Joa1R7pBjpmZggY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVXPLyYwKimOxS6oHWzamgH/Fh9RyoF6TkM\n V5JZpGSwF2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5d70EACNGoq43OB3CaDM+7/7tFMzAAPCltI8juSVy+j+3BQDmaiciMy8bMR3VtcqDRoH55QM7xI\n IqP0HNxUcWeJh2XLTOBJ5hYzF/nir0jZ6tgSfu1c4sy11+ubmdXSkNzCQJs8VUQcZJp5zbFBkZU\n h9wDDUuWH+UpbZJ6Sm7vh5ZdOlNKEYQoCtAb6oBaa27BeQdEcYqtXFQYI+Pq0ts8xMrR0bJP12o\n PGMgtKvnEaFp9oR4tzjePuSx8m8kyG+591qp7sdFwzYUdawCKzTlp9J6tXqp8u0xmHjXWzUuTDl\n ngjv8zO0wc8g8qUu9qLSMEfPA+8xv4jIPjTHKJL6sqn8WUtdLcNKdwivbLIGeNLOKXykNT6Fa6C\n 1zo3UYF4Q9rN+9d0OHJgdRk8dn8uPoAPv/efVD5eZWXSK1tWxLH0bqhSjy4Rf5QD0+3N8e0a1d4\n IalaY4y2lxfv5e/o8xyO/b7ctnx27/liTCmbgkuGULj8jItFCXahZt+Po6mS7Z14I6iAJUGdwxd\n Wguq+pOIjKJu5Kza1R8xjFXXgpUTSUCtBBlY6lVTq4CDlxx9w4s5t4k49hTurX4w7KEIRt8gX8c\n uxJ1w9Jo9SuXddTwQsMwzb5Yn5EYY0/tc++BnB/2qNWPzZp6LoLE46Vr96YTfex1wsMMubbuVfJ\n fKPAsHDnqtqFmqg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"kvm_set_device allocates device via g_strdup, but no\ninstance_finalize existed for the KVM accelerator type.\n\nFixes: aef158b093b9 (\"Add class property to configure KVM device node to use\")\nSigned-off-by: Marc-André Lureau \n---\n accel/kvm/kvm-all.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\nindex 92af42503b1..96f90ebb240 100644\n--- a/accel/kvm/kvm-all.c\n+++ b/accel/kvm/kvm-all.c\n@@ -4342,10 +4342,18 @@ static void kvm_accel_class_init(ObjectClass *oc, const void *data)\n kvm_arch_accel_class_init(oc);\n }\n \n+static void kvm_accel_finalize(Object *obj)\n+{\n+ KVMState *s = KVM_STATE(obj);\n+\n+ g_free(s->device);\n+}\n+\n static const TypeInfo kvm_accel_type = {\n .name = TYPE_KVM_ACCEL,\n .parent = TYPE_ACCEL,\n .instance_init = kvm_accel_instance_init,\n+ .instance_finalize = kvm_accel_finalize,\n .class_init = kvm_accel_class_init,\n .instance_size = sizeof(KVMState),\n };\n","prefixes":["26/41"]}