{"id":2229124,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229124/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-19-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-19-c413f3605311@redhat.com>","date":"2026-04-27T19:42:18","name":"[19/41] ui/console-vc: destroy fifo on text console finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"81b947fd19a4ecf505adaca074548ef6f13bc859","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-19-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229124/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229124/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ms4nB/5q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZ15lndz1xvV\n\tfor ; Tue, 28 Apr 2026 05:45:29 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRsc-0002qh-A8; Mon, 27 Apr 2026 15:44:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRsX-0002HY-8Q\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:26 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRsV-0007yr-RS\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:24 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-0iS2rUBqPbqQ72lXHqwNDg-1; Mon,\n 27 Apr 2026 15:44:20 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EA2AD19560B5\n for ; Mon, 27 Apr 2026 19:44:19 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EE73819560AB; Mon, 27 Apr 2026 19:44:18 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319063;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7mO1Q1PX7LwqKmv4izDa+Ri7d+hEtOWbrxErFRjbh8M=;\n b=Ms4nB/5qcl3A1Qc7Rals0oDREQ3aBgQv7GT+DqX/rZVXzVcyweItxOEz0dNb6E9N6qNh8h\n nMd3NH3ipCZUsJY093fuWBOoKK9MRWNjWFgN+QQX1GIFDTAutLq2eEQvyz3g5tgn39Hsff\n TTyvEA4Fck5UzDmu1HPLzQlIWu1shN4=","X-MC-Unique":"0iS2rUBqPbqQ72lXHqwNDg-1","X-Mimecast-MFC-AGG-ID":"0iS2rUBqPbqQ72lXHqwNDg_1777319060","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:18 +0400","Subject":"[PATCH 19/41] ui/console-vc: destroy fifo on text console\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-19-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=699;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=/copMMdgfN/IQj7Op8a3U5/jQ7AvugHm22MyFvCxwcs=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVDWc2RTzTdzVaACw0HBTV7aFjGoUZeyq/P\n futjwZkBG+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5TKuEACYTWAOJR1BUnf0ErDjRwkFUsggntWcKEhW661y6xonoNUubqd9bT9XDm8ZDPPVhkX7hp9\n NdyFyk5IAnf5Ctjir5T7KHpimpj1EvgOe/qA2my5/oOq/ndXuUfVMJXwnUhjm3hhNr3oKen/3Cx\n 2RjkRiojnG8z7S1EG7YINO2qrzgY2KBuf2K6elgSxVnOfVBeOOeIu9uAoF0u2wcE8qQTA9YOy0G\n b+9zBslSRfLrHuHKowdTUXhAkjhNcf9qzDq5uq5okAHRDWEpLZIq+ZhdBdzVV0GYykSsXPv23Bi\n kpGx62E/H13Jk14+vYA5hquDbr/CoJv1K3J1qucS1FA4hXUmYRy4O8a3c3QDk3n+72uFaZKZNXZ\n CpzDhpXfsUPVWI1Y8q9fG0nIX2mELeOsSEOIirWUg6gSXdg3ErIQNtNZKc5jgYLdpErd7hBKGKj\n W1ZY0ySKjekfB1uQ8Z/OQWPkjkL3SxrUfP6cYKiYtgaZepd7Pl4b7d8KvjC8dULkKuBaU0HaN6A\n LfRCApulxDvgX4enDISQb8kluC3hyXE9BSBspx+K2gy3UJ9e2abKsZZt+7auWmBMMsrFcLH57md\n aqWDrOnZMCz7L/Abf6+XrN9MQ3r5W2QLouDQKp0GaBGM7qNa5eOBi+cwFKQPksUQX82U5lNyzvd\n nT7oanfPcuUQP6A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"qemu_text_console_init creates a fifo8 via fifo8_create, but\nqemu_text_console_finalize never called fifo8_destroy, leaking the\nunderlying buffer.\n\nFixes: 0c9d0641ac (\"ui/console: replace QEMUFIFO with Fifo8\")\nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 107294af1cc..89fa9a216e1 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1081,6 +1081,7 @@ qemu_text_console_finalize(Object *obj)\n {\n QemuTextConsole *s = QEMU_TEXT_CONSOLE(obj);\n \n+ fifo8_destroy(&s->out_fifo);\n QTAILQ_REMOVE(&vt100s, &s->vt, list);\n }\n \n","prefixes":["19/41"]}