{"id":2229121,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229121/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-15-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-15-c413f3605311@redhat.com>","date":"2026-04-27T19:42:14","name":"[15/41] hw/i386/x86: free oem_id and oem_table_id on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9c1ac9b19416dcb4a7d18cc2be6ae62aad9a960a","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-15-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229121/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229121/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ybz9liMv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DYz1rlkz1xvV\n\tfor ; Tue, 28 Apr 2026 05:45:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRsZ-0002R6-OP; Mon, 27 Apr 2026 15:44:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRs9-0001nk-4V\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:01 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRs7-0007vq-7l\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:00 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-NHRMhUqBMceaEsuhhYz0cw-1; Mon,\n 27 Apr 2026 15:43:57 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 36C56195609D; Mon, 27 Apr 2026 19:43:56 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D61581800352; Mon, 27 Apr 2026 19:43:54 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319038;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FjtgSdF/RmKZsYPVx79tmSgU9IPq9ejhGQ1cMOPcuRs=;\n b=Ybz9liMvSiAQNcxUhu9XsFJ/l9eOZMDgxDqSVvQnqbmz5oVIkiuSX44Citx4/DQ/kuhJVx\n UJNwVuzFkYrwZzUbedHOCJpC6eHSuK0hMv8H3ZhduQGMlmy+0675qzz0uwyWVN8hWXOwwl\n B906fVBEY4WHZuPEgdeVWzZn6L70RwU=","X-MC-Unique":"NHRMhUqBMceaEsuhhYz0cw-1","X-Mimecast-MFC-AGG-ID":"NHRMhUqBMceaEsuhhYz0cw_1777319036","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:14 +0400","Subject":"[PATCH 15/41] hw/i386/x86: free oem_id and oem_table_id on\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-15-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Michael S. Tsirkin\" ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1380;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=xERWYRvCuiLTWF3DPmtzusKt3TfQ56Tk1JuAhFbMaJw=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUdq/Ah6awE67u+JM6xKjDPtqDWwrspPswn\n bwx9l2qBDmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5bt4D/9TLOyiF/NMkcEgHcxikbz8iBM/t4O0SpFAHIjWf/NZrlNSJaEycYalGNUoD8W7qbbn3Ww\n ZJd4mrRuytXzTQTkS3oqNZLW0ADhV3r4vu2ZOCzDudfpiRQdPRFoP4DWo2PXo/DAzbtNH1KZOSG\n A3gEdFXQjEzRcY4VyCscVSCs57tWZXe1FdTCJNKiXZnI2zDp4QIZPYlm1OqttLdYzYyKZoIem13\n Nh3XwRMKQOfT1xLoeqCNy6mA4jLxZyAKUwRUuITk2bWHFsDQblt95Rmulvz52Tan5pdiAZw0bLz\n HP7iZRUjTt0GGz+VOpP1iF/3/S9v6ca6iRGmq2UvPJmI+24MgSaZ+0FUH32Gknn87pUPyal9Ugj\n krqdRsz0S+3I08+z7jjZ3KNE21fWCmRmdAnwFyoDdAHuM0e9t49Qjwmr68RijbXi2PUDzXVK6x7\n ZvBSWTD071aRR+Swrs0BkObJc6IVdmr2oK68lJouLJZWMsEHk4ZQzi6UuCISnTzRMdoZ0n4joTX\n f7iA4HNEjUp1h2TO/gfngtvMC6JUMq2kH09cy8KSGfiRLzFSrO/ioZAg+X00RvwwevBHG9E6oFl\n rugkX+g58JNpBiJ2NF5TVvCElWw//JFA4eAe5+fbIOqvhgM6/PH/bI761+qRfr7855ecZviUS7s\n 3yEzpZkKgDhGvcA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"x86_machine_initfn allocates oem_id and oem_table_id via g_strndup,\nbut no instance_finalize existed for x86_machine_info, so these\nstrings were never freed when the object was destroyed.\n\nAdd x86_machine_finalize to release both fields.\n\nFixes: d07b22863b8e (\"acpi: Move setters/getters of oem fields to X86MachineState\")\nSigned-off-by: Marc-André Lureau \n---\n hw/i386/x86.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/hw/i386/x86.c b/hw/i386/x86.c\nindex 01872cba073..dc7f0d56b01 100644\n--- a/hw/i386/x86.c\n+++ b/hw/i386/x86.c\n@@ -372,6 +372,14 @@ static void x86_machine_initfn(Object *obj)\n x86ms->above_4g_mem_start = 4 * GiB;\n }\n \n+static void x86_machine_finalize(Object *obj)\n+{\n+ X86MachineState *x86ms = X86_MACHINE(obj);\n+\n+ g_free(x86ms->oem_id);\n+ g_free(x86ms->oem_table_id);\n+}\n+\n static void x86_machine_class_init(ObjectClass *oc, const void *data)\n {\n MachineClass *mc = MACHINE_CLASS(oc);\n@@ -445,6 +453,7 @@ static const TypeInfo x86_machine_info = {\n .abstract = true,\n .instance_size = sizeof(X86MachineState),\n .instance_init = x86_machine_initfn,\n+ .instance_finalize = x86_machine_finalize,\n .class_size = sizeof(X86MachineClass),\n .class_init = x86_machine_class_init,\n .interfaces = (const InterfaceInfo[]) {\n","prefixes":["15/41"]}