{"id":2229120,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229120/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-10-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-10-c413f3605311@redhat.com>","date":"2026-04-27T19:42:09","name":"[10/41] backends/cryptodev-lkcf: skip cleanup when not initialized","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"448ce9f2489ffe2e97b88afc38eed47676034666","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-10-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229120/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229120/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hiu9rLcB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DYy03rCz1xvV\n\tfor ; Tue, 28 Apr 2026 05:45:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRsL-0001ze-PM; Mon, 27 Apr 2026 15:44:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRri-0001I4-NC\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:37 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrf-0007oh-N2\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:34 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-EytumEKpOAGGqVZzecd0Gw-1; Mon,\n 27 Apr 2026 15:43:27 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DBB021800282; Mon, 27 Apr 2026 19:43:24 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7B313300757C; Mon, 27 Apr 2026 19:43:22 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319010;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=I+eC6NQYMsyddRo7PFwbRV3xFGGbIUsTRsbhZr7HhNM=;\n b=hiu9rLcBro0M6Kj2SI7r2F2q90MAX0s1YUxJoSkWbXIhcVAW/HpKG6TYLRpaw/QehdbFMp\n YbaFVlOBOULNbZiiLCfBVtq5FNcmXrt0C0mVcgszQDRy1W2jrw3SnPOlcUQtrkFj+MMEXD\n STAhI8nH/3ZPe+MF37/Mzq/5IyvV3Mg=","X-MC-Unique":"EytumEKpOAGGqVZzecd0Gw-1","X-Mimecast-MFC-AGG-ID":"EytumEKpOAGGqVZzecd0Gw_1777319005","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:09 +0400","Subject":"[PATCH 10/41] backends/cryptodev-lkcf: skip cleanup when not\n initialized","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-10-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n \"Gonglei (Arei)\" ,\n zhenwei pi ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1164;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=HrppNKbbNxohb7YDYQ92lXKgUl9QPVoSeBjpfd/wmpc=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUVsUu48ebgWl2IieQbcdJdJN9Z8NKmaH2I\n dUqTTBFDc2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5YvAD/9AYxD8efG/BQzajgGHPRt51FSZdQNbMk818g8Aivr1flz3uaINzf91x8JZrX7+9of5otf\n zjKs/PJzbFkm5jqGfS0DkhsI5KE2uXYNKsBzJH6TofR8JixB9d8hT75VO07hdBe4PIDaYRDTKNL\n hYyWZPn3tbVqY73fRP+pdT2rJQC/Y6Ph+JTX+M/x6DBKD6sHZrJ6FELop79KCv2BTilLfLCW6Dl\n xB2c2l/EyUqizeaffMds1doj57Qkxp+dyFV8WnCvIyTpz/IiZKRluR+0NqCH/ahqKRsQtHv4WNO\n NcaZH+s3EKFtyP54JQ11H8n5nWdc/utu6vwRDW6lIGYUQTpIKKQcmB07auUEsScUb/UJg3ZeGhx\n xnnnL0of9S5vmr2UxwaSkUDfqxmQUeAVa7XE8qoQRi8J4tk4d4bHx3EQpZcYzrg67F3E4nn+McL\n 1Q6kYWA0+L7b82/q8SjwVAHKf+nDucm3fzWNv6QwOxSBxAXsH0rzuBQKkXY7ZIE49QXmDuNsjA0\n 7h+JfZ0YRZ185+tZhFgNP+G0ouA5xO97AFf29ahGgUlpIzLUJw4K6fz4r69eTy8u1wJ9rladnwB\n ouJET7bjYe+yxho5jbIg5bb6D6VKgGcau/cI+rYr0J+fQCuJKtpkqIaXFsfGifZ0k/zPeG8Sg5s\n tUpne4rlXYfFy3A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"cryptodev_lkcf_cleanup() locks a mutex that is only initialized\nduring the init vfunc (called at realize time). When the backend\nis destroyed without ever being realized, the mutex is uninitialized\nand the lock aborts.\n\nReturn early from cleanup when the backend was never started.\n\nNote: it looks like cryptodev init/cleanup callbacks should rather be\nregular complete/finalize overrides (calling the parent method).\n\nFixes: 39fff6f3e8b3 (\"cryptodev: Add a lkcf-backend for cryptodev\")\nSigned-off-by: Marc-André Lureau \n---\n backends/cryptodev-lkcf.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c\nindex 40c7bd3c5a0..74db03fe96b 100644\n--- a/backends/cryptodev-lkcf.c\n+++ b/backends/cryptodev-lkcf.c\n@@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *backend, Error **errp)\n CryptoDevBackendClient *cc;\n CryptoDevLKCFTask *task, *next;\n \n+ if (!lkcf->running) {\n+ return;\n+ }\n+\n qemu_mutex_lock(&lkcf->mutex);\n lkcf->running = false;\n qemu_mutex_unlock(&lkcf->mutex);\n","prefixes":["10/41"]}