{"id":2229118,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229118/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-23-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-23-c413f3605311@redhat.com>","date":"2026-04-27T19:42:22","name":"[23/41] net/can: free ifname on socketcan finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6b04fc6338e143fe7384a56ca409257dee637e9e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-23-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229118/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229118/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=jKi/P6MU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DYr4my9z1yJX\n\tfor ; Tue, 28 Apr 2026 05:45:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRtB-00056y-0s; Mon, 27 Apr 2026 15:45:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRsy-0004hg-9f\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:54 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRsw-00082U-Or\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:51 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-scGLjG0uPeGo4vpIL5PzDg-1; Mon,\n 27 Apr 2026 15:44:45 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DBE501800282; Mon, 27 Apr 2026 19:44:43 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 508DC19560AB; Mon, 27 Apr 2026 19:44:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319090;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=hQRjqUoc7vncI0l+hyaSVFOjsbZOyeIpqu/UWPsxqd8=;\n b=jKi/P6MUcDd1GFKwkS14DjExy5xHoLD03NSdpSJRalRMVVBEurgrBUTiSykilT8GXxaDBo\n rIa7ZspPLHWLB8WzytZdohd+FMO81u5/5cYVhLPe9wq/DqJvcS9Pmxeu7UsQh1a37FIu6A\n Ac6nEzaBUkZIsr61pRza4Zj+h4Vzuyw=","X-MC-Unique":"scGLjG0uPeGo4vpIL5PzDg-1","X-Mimecast-MFC-AGG-ID":"scGLjG0uPeGo4vpIL5PzDg_1777319084","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:22 +0400","Subject":"[PATCH 23/41] net/can: free ifname on socketcan finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-23-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1160;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=T+85e7xuXg9EayFeuwtfh/5N5bXTovQE7UAq/AO7gww=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVrFjRixhuNCY+Q+nnAmVzh1gFmLm0rQZAa\n okmszpZ5kaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5YJ+D/wJYhK5np4MRUDtWxcOCulAj+2vUx4Llktz765wYx+7LQEVGHj2/ejeM+MwLGE2WE9jjRy\n 8f5CVktT+9nodqQlnzRXqI0h8aolM2tnoUtZQGtQ6oqPEgDwzbY//8fLZUUQ3cZ0nJ8kxXSKg17\n 6v6KutTP6MQUNYqCoT3fLOLJyNuJDHGQCuT7VmkKBCAjWT0aSsqi889FnkMIuhEy16V50jXXU0e\n UtdE7L2XJnANmuCVIUZq3M23vFm/UVg+SAgnM4ZhtHFHuqC4FkFK7egu81+MTrLCMW2NmWKLnDZ\n Szpyp9HpyxzRnviqrSsiHFUfTFBfAGrJjF2UkjnZLqW5Gmp5mypYC20+Ocdwmn77w5X0yh2BASF\n uq0VhGMciP1DugO65bOcth1gA/v6RihqTJpOjBFa1mgDLcT86J7a2tQ2BgxSFIK2i5auBi/wqwe\n GG5lwp2D9KbSRabiN7mQT5od4hVg5Pm48ZDyAJsp7wwFFgx8OQ9CrHLXtv9PyhVF0CcciShgYD2\n 1ODKQEPsLupfKaOD+JreJQUTJn1JeefRQBwlW8wBdJ1cYTJx+YZhenuALrzVA0J5HXZrxEum/J+\n 3R1MvR6YRFRlirx/G7/KEcyGCocsOhGPBUaIW7l0SHgZ2R4CmoRV9cfHxBv/5m5mrJBUAHm2Rd6\n yJo+lpNFz3wDvbw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"can_host_socketcan_set_if allocates ifname via g_strdup, but no\ninstance_finalize existed to free it.\n\nFixes: ea15ea8a7c67 (\"net/can: support for connecting to Linux host SocketCAN interface.\")\nSigned-off-by: Marc-André Lureau \n---\n net/can/can_socketcan.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c\nindex 8a57ae07178..be67ed7f5a9 100644\n--- a/net/can/can_socketcan.c\n+++ b/net/can/can_socketcan.c\n@@ -319,11 +319,19 @@ static void can_host_socketcan_class_init(ObjectClass *klass,\n chc->disconnect = can_host_socketcan_disconnect;\n }\n \n+static void can_host_socketcan_finalize(Object *obj)\n+{\n+ CanHostSocketCAN *c = CAN_HOST_SOCKETCAN(obj);\n+\n+ g_free(c->ifname);\n+}\n+\n static const TypeInfo can_host_socketcan_info = {\n .parent = TYPE_CAN_HOST,\n .name = TYPE_CAN_HOST_SOCKETCAN,\n .instance_size = sizeof(CanHostSocketCAN),\n .instance_init = can_host_socketcan_instance_init,\n+ .instance_finalize = can_host_socketcan_finalize,\n .class_init = can_host_socketcan_class_init,\n };\n \n","prefixes":["23/41"]}