{"id":2229114,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229114/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-11-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-11-c413f3605311@redhat.com>","date":"2026-04-27T19:42:10","name":"[11/41] RFC io/net-listener: move mutex init to instance_init","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3e453b8bcccd8432627bfd0e3958169bbce897f8","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-11-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229114/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229114/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=f3A9fCvJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DYN6dzMz1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRs8-0001lc-O8; Mon, 27 Apr 2026 15:44:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrk-0001JV-HH\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:43 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRri-0007qk-GB\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:35 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-155wX3K5NM25kz0SWDP0TA-1; Mon,\n 27 Apr 2026 15:43:31 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C400519560B6\n for ; Mon, 27 Apr 2026 19:43:30 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6C806180045E; Mon, 27 Apr 2026 19:43:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319013;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bCdTxip8FNtJt22m42Ll7TRz6Zd06sy9UeGEc0+Czr8=;\n b=f3A9fCvJpf5xWSfH6nlhZfK/k994QHoXyWsAaZ9pzlTy++FIwsdpBiQftbAj2FYUGMqp3/\n HPZdF8Tcn7AMvJxSCVQQKKNbTcictPR7Ry2bxWNB90LCI6f02iNy1bUfuvL3U6ar2cDxQm\n gNnKF5W/vZ6jAOelfRHYoQ6YG9GMXHk=","X-MC-Unique":"155wX3K5NM25kz0SWDP0TA-1","X-Mimecast-MFC-AGG-ID":"155wX3K5NM25kz0SWDP0TA_1777319010","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:10 +0400","Subject":"[PATCH 11/41] RFC io/net-listener: move mutex init to\n instance_init","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-11-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n peterx@redhat.com,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1998;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=AI5iHywR+QJtls1SfbIwtt7tGFLKNLtYM1nZ2EPFdE8=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUTPj7CJgSq8YwiimLt+PkyyUp1rMGmtyHC\n fUZCH1hgIqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5biiD/oCqLacfxTJFTvmKcd+iTxjz1hp0q4/2fXdcMOyWC5NtM7bFf4vvyuObSTCDUrePO7S3Lb\n bK4VliKw3SWZVBqy0/XmXv6ipdScP6ww7bCog11BdzpsSFb1yHWB81SawlPJ80cS29Cm7wRC1Sz\n wEEBMqAsTcqM0+WnknyAoQmo0ase6qshynQLT74CKNkRtL41ucPLeU8D+W3kEz9/1tk0Xl69oy8\n zsI53Ae9f/atKlLFrwswDGfaRB9lgB689yY03EjyimHefgR5P8dl4gBgo/1x0AThBIP6zjEHZ2o\n CagxczwoCazE44ytloYJkU8z08r/jGRYMuLfnUKXUCaee6FVTbcsXHmtcIcze2dkjha7U/TfmKD\n rRRiLUF4DBWnLH8JO4ejwopNKQK9y2zwsEp2iIUpO9itNCrurd6/0pAw1DyXlXAqpCjy+nXt1wJ\n jIqtNE9RTwFbk8CPwVQIcA6SEZIdb2M/rmegtSX4ZngyOCgwJQKRKY0GXdZoNIyAL/DdXCs4DSw\n 1o8HQEMQJhnSiaBAvDjAtc5MQJ/+QQhCvTbbPW1+QRMQD2exEh32BLYcy/s1hRDgg8srPqRtqXc\n 3AM9uFG7tiKUP6qMyDqu5UJ4YCBYw4lqSrcO/8obt0YmA59H8zhvxuCFhNnERCtQDYCSYCWP4C8\n omTw+LsJqwH9lvA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The QIONetListener mutex is initialized in the convenience\nconstructor qio_net_listener_new() rather than in an instance_init.\nThis means a bare object_new(TYPE_QIO_NET_LISTENER) produces an\nobject with an uninitialized mutex, but instance_finalize\nunconditionally calls qemu_mutex_destroy() on it, which aborts.\n\nMove the mutex initialization to a proper instance_init so that init\nand finalize are always paired regardless of how the object is\ncreated.\n\nThis patch is just added for completeness, but \"qio: Fix\nqom-list-properties crash on net listener object\" from Peter Xu is\nbasically the same.\n\nFixes: 9d86181874a (\"qio: Protect NetListener callback with mutex\")\nCc: peterx@redhat.com\nSigned-off-by: Marc-André Lureau \n---\n io/net-listener.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/io/net-listener.c b/io/net-listener.c\nindex 9410d72da9c..1fd0f6cb5ab 100644\n--- a/io/net-listener.c\n+++ b/io/net-listener.c\n@@ -38,7 +38,6 @@ QIONetListener *qio_net_listener_new(void)\n QIONetListener *listener;\n \n listener = QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER));\n- qemu_mutex_init(&listener->lock);\n return listener;\n }\n \n@@ -440,6 +439,13 @@ qio_net_listener_get_local_address(QIONetListener *listener, size_t n,\n return qio_channel_socket_get_local_address(sioc, errp);\n }\n \n+static void qio_net_listener_instance_init(Object *obj)\n+{\n+ QIONetListener *listener = QIO_NET_LISTENER(obj);\n+\n+ qemu_mutex_init(&listener->lock);\n+}\n+\n static void qio_net_listener_finalize(Object *obj)\n {\n QIONetListener *listener = QIO_NET_LISTENER(obj);\n@@ -463,6 +469,7 @@ static const TypeInfo qio_net_listener_info = {\n .parent = TYPE_OBJECT,\n .name = TYPE_QIO_NET_LISTENER,\n .instance_size = sizeof(QIONetListener),\n+ .instance_init = qio_net_listener_instance_init,\n .instance_finalize = qio_net_listener_finalize,\n };\n \n","prefixes":["11/41"]}