{"id":2229113,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229113/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-20-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-20-c413f3605311@redhat.com>","date":"2026-04-27T19:42:19","name":"[20/41] target/i386/sev: add finalize functions and fix leaking setters","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c0136d77a03ee98025e3954619f7cc1a11e2f086","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-20-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229113/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229113/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=A8fjODbl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DYC5Rk5z1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRsj-0003ru-Pd; Mon, 27 Apr 2026 15:44:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRsg-0003ZR-QE\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:34 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRsf-000806-4F\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:34 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-66sLjyeEMly5eSJMVCE_XQ-1; Mon,\n 27 Apr 2026 15:44:27 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 21D2A1800345; Mon, 27 Apr 2026 19:44:26 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id CBEBE300070A; Mon, 27 Apr 2026 19:44:24 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319072;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Z3mpIj7kKLWQd1wHYRB/isiRg9MwxmXnW9JJf/oFUXQ=;\n b=A8fjODblbnw/+fItA3KyI/i+wnMYTXUT4MNyn7xuaCflpYNsm8Njs4py0LCUeOygvunVic\n I6gQi//rbAHRiOFiMXIP162AtHUWMZO8DRupb9mGap59BDYhCMGsRsBBIbvNKDtr346AIb\n gqbZy1aKu2Mx5LTsiTZEnZRLzEpvxtQ=","X-MC-Unique":"66sLjyeEMly5eSJMVCE_XQ-1","X-Mimecast-MFC-AGG-ID":"66sLjyeEMly5eSJMVCE_XQ_1777319066","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:19 +0400","Subject":"[PATCH 20/41] target/i386/sev: add finalize functions and fix\n leaking setters","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-20-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini , Zhao Liu ,\n Marcelo Tosatti , kvm@vger.kernel.org","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4011;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=owTdgCW7z+9rJcjQ83R8ZEybDyEY8YNmwtxW2tfBqxA=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVh3bge/hfu7M/mrWwNzqJk9dgdWrhJfDTA\n kRvwWFs6TaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5YS/D/44TGXRiKZhlIVanFn8435rX5HTctjAkmt5JVuGq93W2jX/6NB9o6p+UYPrvNcz9xeRued\n +67951etfZW+rt4Eht7tX7nN0YOf/FTLnHAcrkFfdyMR8r/lP1Bne4qhDdLnTBkqwfR2IbgT+Uw\n hGQMpc83p4WHRo+nQpHAO93xbH6bOW2XgbTemdwaO7DVK55JxBA/0713I6qlm7+QcF/WdRTSYEU\n sKU+9Dm0DSqltJQ51JM3jRvLju6Q8PNeybeDNSlHVDjoD1aVJu0TN6KCcPALc9i1LCwmgcK6qyx\n ALotZh3NJtOPxjSX57aKsaJZvFetSCXYrNE3ql9JR1GxYX4GzEsOQW7er/UZ9bLBaASoCdGjORe\n P9sgw6t/PW9pYfqPl9cIaMKmia9jQo/ZRJZna7AhQ45RL05aFzfMNeLgumaNBVRE1czuRFJyCv1\n Samt+ncT7GrJeym2Wez9sNueqBlRrs66CYhuxSHHDkivA1N2xS/d36PeLP5+2jutCNLBM+zm/R0\n CWHbHUYoDSByF3H2u8jnMcnBU8EQhbF3JS4EgMgb5EgDucaoY+Rl+cfDDNJzjGIEZLkI/eWP3PQ\n WD8uGBEZb2cFIMJLQP978qKhVyi5RV2oyjGehUIHCIGv/HeorfSWgIfBQdFTUS8224kAPRlquV7\n Pt/qLRCMLtb+Xag==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"None of the three SEV types (sev-common, sev-guest, sev-snp-guest)\nhad instance_finalize functions, so all string fields allocated\nduring init or by property setters were leaked on object destruction.\n\nAdd sev_common_finalize, sev_guest_finalize, and\nsev_snp_guest_finalize to free the allocated fields.\n\nAlso fix sev_common_set_sev_device, sev_guest_set_dh_cert_file,\nand sev_guest_set_session_file to free the old value before\nreplacing it.\n\nFixes: a9b4942f485b (\"target/i386: add Secure Encrypted Virtualization (SEV) object\")\nSigned-off-by: Marc-André Lureau \n---\n target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 37 insertions(+)","diff":"diff --git a/target/i386/sev.c b/target/i386/sev.c\nindex 261b6aaa37b..3c2734ad83b 100644\n--- a/target/i386/sev.c\n+++ b/target/i386/sev.c\n@@ -2527,6 +2527,7 @@ sev_common_get_sev_device(Object *obj, Error **errp)\n static void\n sev_common_set_sev_device(Object *obj, const char *value, Error **errp)\n {\n+ g_free(SEV_COMMON(obj)->sev_device);\n SEV_COMMON(obj)->sev_device = g_strdup(value);\n }\n \n@@ -2831,12 +2832,21 @@ sev_common_instance_init(Object *obj)\n QTAILQ_INIT(&sev_common->launch_vmsa);\n }\n \n+static void\n+sev_common_finalize(Object *obj)\n+{\n+ SevCommonState *sev_common = SEV_COMMON(obj);\n+\n+ g_free(sev_common->sev_device);\n+}\n+\n /* sev guest info common to sev/sev-es/sev-snp */\n static const TypeInfo sev_common_info = {\n .parent = TYPE_X86_CONFIDENTIAL_GUEST,\n .name = TYPE_SEV_COMMON,\n .instance_size = sizeof(SevCommonState),\n .instance_init = sev_common_instance_init,\n+ .instance_finalize = sev_common_finalize,\n .class_size = sizeof(SevCommonStateClass),\n .class_init = sev_common_class_init,\n .abstract = true,\n@@ -2856,6 +2866,7 @@ sev_guest_get_dh_cert_file(Object *obj, Error **errp)\n static void\n sev_guest_set_dh_cert_file(Object *obj, const char *value, Error **errp)\n {\n+ g_free(SEV_GUEST(obj)->dh_cert_file);\n SEV_GUEST(obj)->dh_cert_file = g_strdup(value);\n }\n \n@@ -2870,6 +2881,7 @@ sev_guest_get_session_file(Object *obj, Error **errp)\n static void\n sev_guest_set_session_file(Object *obj, const char *value, Error **errp)\n {\n+ g_free(SEV_GUEST(obj)->session_file);\n SEV_GUEST(obj)->session_file = g_strdup(value);\n }\n \n@@ -2937,12 +2949,23 @@ sev_guest_instance_init(Object *obj)\n sev_guest->legacy_vm_type = ON_OFF_AUTO_AUTO;\n }\n \n+static void\n+sev_guest_finalize(Object *obj)\n+{\n+ SevGuestState *sev_guest = SEV_GUEST(obj);\n+\n+ g_free(sev_guest->dh_cert_file);\n+ g_free(sev_guest->session_file);\n+ g_free(sev_guest->measurement);\n+}\n+\n /* guest info specific sev/sev-es */\n static const TypeInfo sev_guest_info = {\n .parent = TYPE_SEV_COMMON,\n .name = TYPE_SEV_GUEST,\n .instance_size = sizeof(SevGuestState),\n .instance_init = sev_guest_instance_init,\n+ .instance_finalize = sev_guest_finalize,\n .class_init = sev_guest_class_init,\n };\n \n@@ -3195,6 +3218,19 @@ sev_snp_guest_instance_init(Object *obj)\n sev_snp_guest->kvm_start_conf.policy = DEFAULT_SEV_SNP_POLICY;\n }\n \n+static void\n+sev_snp_guest_finalize(Object *obj)\n+{\n+ SevSnpGuestState *sev_snp_guest = SEV_SNP_GUEST(obj);\n+\n+ g_free(sev_snp_guest->guest_visible_workarounds);\n+ g_free(sev_snp_guest->id_block_base64);\n+ g_free(sev_snp_guest->id_block);\n+ g_free(sev_snp_guest->id_auth_base64);\n+ g_free(sev_snp_guest->id_auth);\n+ g_free(sev_snp_guest->host_data);\n+}\n+\n /* guest info specific to sev-snp */\n static const TypeInfo sev_snp_guest_info = {\n .parent = TYPE_SEV_COMMON,\n@@ -3202,6 +3238,7 @@ static const TypeInfo sev_snp_guest_info = {\n .instance_size = sizeof(SevSnpGuestState),\n .class_init = sev_snp_guest_class_init,\n .instance_init = sev_snp_guest_instance_init,\n+ .instance_finalize = sev_snp_guest_finalize,\n };\n \n static void\n","prefixes":["20/41"]}