{"id":2229112,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229112/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-2-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-2-c413f3605311@redhat.com>","date":"2026-04-27T19:42:01","name":"[02/41] chardev/char-socket: handle NULL addr in char_socket_get_addr","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"81f5e833beb7008b112340fd74bc174fd4a449fd","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-2-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229112/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229112/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JV8GUm8p;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DY158x1z1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRr6-0000uZ-QJ; Mon, 27 Apr 2026 15:42:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRqt-0000qO-MW\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:44 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRqq-0007hy-KD\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:42 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-A30x2vMEM1abmnukM2kG7g-1; Mon,\n 27 Apr 2026 15:42:36 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D67D71800454\n for ; Mon, 27 Apr 2026 19:42:35 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8DDB0300070A; Mon, 27 Apr 2026 19:42:33 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777318960;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=MpZfxbMbvI+LoOauwmGQ7lN3E+YKy7RIysjR5B8VSug=;\n b=JV8GUm8pbR2c+KmSHsNGnN/Hui3wVLeuz75s+T+AdcvmV0wA5dnw91ocANRHg0jM9pDDCb\n 6a382HEfsQX74f6rNG3LKqQojU/Qp27j0QBe/ZLrqGxS8rS0dWx8mYDvif9v8WTammrCPq\n HU0WxfcDZp5bFZOghmEfuJ8dK2B8RVs=","X-MC-Unique":"A30x2vMEM1abmnukM2kG7g-1","X-Mimecast-MFC-AGG-ID":"A30x2vMEM1abmnukM2kG7g_1777318955","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:01 +0400","Subject":"[PATCH 02/41] chardev/char-socket: handle NULL addr in\n char_socket_get_addr","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-2-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=807;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=OqoZXlzFf70MD8aVuu81IsB2OfurhLf51jzWd985d5c=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUxNaEGAUSFoncgex/xqbAlH89hcs0waV6p\n dDsIi5LKZqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5V9+D/42oppCsFcGimP/mQ10jT/G5+69yF/oXFUc59ryhiXA+GeMCbb67j/yqNnraHKmLG4dc9k\n 4tet53MeLMCWDNxh+TOG2/Ta0CClETSTD2Va+8traDjLyKkK8FcfIxfFoEqa2OJ+Urmpv8jP7XA\n kkbQU23JOIPjd+qzKzxKpUuNxn1s2Vgt2ZHHh/tMUYzpxiOGsMgGmnmpOlki8p/C9y9jUm5PVde\n o6+gGig4BvHr1vN9CY2e3mqQZE/Ou8EirTqgUE5Mt0HUmFIOxLHpNmqVxNgDOevXQMJ3goDH+vv\n nOFYYJuvQT8/Je4HtDxnYNQaQ6MKth5FNgs+DuH1Gfju/NjrqS2Uge03nbnTZH39X7UV2U1LaA5\n aNRZjMow9VCuvqTt4u7IsqPP//Mo1HewMGIuCWDRsZVnSruDv/n5A3Zt+sk7bAhPEfIb7mdaIfz\n SoByF5+7CIb01+Q4dnjAZ7cqDZFUNh9ahxieyYlEEjf5DgkAVD+bHCHlSKlauq6HiNhgHoiiB9O\n 7p19VPiczrGR0g4oJm/ArqM80LVltWR72lwwtioar3Mk+lQ5Ils82vLC509mf9AavJVurobHMpy\n KU1On7gjT83mMsqOZ8d4dTLcfAgSLUaR7sg08Pqe/HV0ZdiNB/uKBJspIV+gzSchnEmbs/Hy+xq\n 5iZM8w4cMgjm4iw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When called on an unrealized chardev (e.g. from\nqmp_qom_list_properties), s->addr is NULL. Return an error instead of\nassert().\n\nFixes: 123676e9894f (\"char-socket: add 'addr' property\")\nSigned-off-by: Marc-André Lureau \n---\n chardev/char-socket.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/chardev/char-socket.c b/chardev/char-socket.c\nindex e064b105c50..b629575fcf8 100644\n--- a/chardev/char-socket.c\n+++ b/chardev/char-socket.c\n@@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const char *name,\n {\n SocketChardev *s = SOCKET_CHARDEV(obj);\n \n+ if (!s->addr) {\n+ error_setg(errp, \"socket not connected\");\n+ return;\n+ }\n visit_type_SocketAddress(v, name, &s->addr, errp);\n }\n \n","prefixes":["02/41"]}