{"id":2229111,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229111/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-13-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-13-c413f3605311@redhat.com>","date":"2026-04-27T19:42:12","name":"[13/41] RFC system/ioport: move embedded memory region cleanup to portio_list_destroy","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"940fd063553fe2fa970ec8152160f6ff0b6432ae","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-13-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229111/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229111/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NkDcNg8M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DY04DKZz1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRsa-0002cQ-UZ; Mon, 27 Apr 2026 15:44:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrw-0001Uv-TB\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:49 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrv-0007uJ-AO\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:48 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-PYToC1IyOp-NuJRWFJdgYA-1; Mon,\n 27 Apr 2026 15:43:45 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0AF3E19560B7; Mon, 27 Apr 2026 19:43:44 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A746519560AB; Mon, 27 Apr 2026 19:43:42 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319026;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=obrpckS7iH34v1YoqBhaWwTyK91hVQnXne3ur+tLSJo=;\n b=NkDcNg8M6r3pBeha6zuiVdGdFYoYLLHgMcaXFrB1yEt9s9GOYFvccUc+OF3LcjkprS8q5u\n cwIRsYU99Ka+6J62hbaM0td3uyUnyACYx/HlkNtfdAuucvRYJXBhZs2uNvhRHQEpOBIa+2\n bOUHo7UCQ3KSklVcWG7Y3tVPXBo2Vg0=","X-MC-Unique":"PYToC1IyOp-NuJRWFJdgYA-1","X-Mimecast-MFC-AGG-ID":"PYToC1IyOp-NuJRWFJdgYA_1777319024","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:12 +0400","Subject":"[PATCH 13/41] RFC system/ioport: move embedded memory region\n cleanup to portio_list_destroy","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-13-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n peterx@redhat.com, Paolo Bonzini ,\n Peter Xu ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1706;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=RVIgJ+CKJPiIQNDTIeDKy6h8zXHge6yaQ/kw2SNexDY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUCbYdI8sm3Wl/Y+5ecL5Qob5gxsyoKCyy5\n 3yEyxiGPbmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5YaCD/oCF7F8ll2wVQMUzZqrg6AW2iVPjgGlqrRMkntM5VLZhJqNZ9DtyFxGtmIw8LYV+srL23b\n D8pbqBPqZu3AY8WerwAoHrFWNkqkeCxZaaBuX4YfcMqFIaJ3/+iIh/ZuV/J6OSs4sUollMrNZPr\n u/CV6h4+yL/ttBtneEMFpSYcBZd+hmk9JBa8VLTZroeoLmJ3bZ3I6nTLbPjn8UUj4hmdDnxvA2n\n yjO0x5hCcyC2k+QyIVjMchTjYMK1SJv1GpFkCR+a8hSHy+SX+xSQUzKG01GwehOlH6437psbHka\n 6zWPrTbviuPEK+Ns30O9lTDus8+xG2Xec4MWY5Jck+1E0sRWJ+A96GfyDnEMLLtCM4F/ncO2BS6\n 8p7/ksvM9jFEjixp8AMD0DWOCVt9oez6Li9BzqBgIbAiiOthPubdYYg5yHR5T2xPvULeDbsUSWM\n B+f0OSa663ZVlQ+tglnpJW9/K827U8j9xgb4TXG7iiV1yAiUvdVD6N8H1jzPMbhbQJ1cOeZXz0p\n 3qlghv7p8HYS5xPDoGqT85gG9FknSM8fH1Ic1px64+gMIt+IOkjPp4FuzeEiSsjtRQXWMqgav5/\n 3887DjDbQV0ZndsrE4zE1qNSayW4RSOenABUvCi6KUCuHZ4hcC8rTJdCT64kDZKSJDp2E4Yl/g3\n xlz/3XcOJFv2xPg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"memory_region_portio_list_finalize() unconditionally calls\nobject_unref() on the embedded MemoryRegion, but when the object was\ncreated via bare object_new() the MemoryRegion was never initialized\nand has a refcount of 0, triggering an assertion failure.\n\nThe unref in finalize drops the keep-alive reference added during the\nreparenting in portio_list_add_1(). Move it to portio_list_destroy()\nwhere the cleanup belongs, and assert the refcount is zero in\nfinalize.\n\nThis is an alternative to \"system/ioport: Fix qom-list-properties crash\non portio list obj\" patch, hence the RFC.\n\nFixes: 690705ca0b0f (\"softmmu/ioport.c: make MemoryRegionPortioList owner of portio_list MemoryRegions\")\nCc: peterx@redhat.com\nSigned-off-by: Marc-André Lureau \n---\n system/ioport.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/system/ioport.c b/system/ioport.c\nindex 9209bff2eab..aa8f3229804 100644\n--- a/system/ioport.c\n+++ b/system/ioport.c\n@@ -145,6 +145,7 @@ void portio_list_destroy(PortioList *piolist)\n for (i = 0; i < piolist->nr; ++i) {\n mrpio = container_of(piolist->regions[i], MemoryRegionPortioList, mr);\n object_unparent(OBJECT(&mrpio->mr));\n+ object_unref(OBJECT(&mrpio->mr));\n object_unref(mrpio);\n }\n g_free(piolist->regions);\n@@ -346,7 +347,8 @@ static void memory_region_portio_list_finalize(Object *obj)\n {\n MemoryRegionPortioList *mrpio = MEMORY_REGION_PORTIO_LIST(obj);\n \n- object_unref(&mrpio->mr);\n+ /* dropped by portio_list_destroy(), or never initialized */\n+ assert(!mrpio->mr.parent_obj.ref);\n g_free(mrpio->ports);\n }\n \n","prefixes":["13/41"]}