{"id":2229109,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229109/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-5-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-5-c413f3605311@redhat.com>","date":"2026-04-27T19:42:04","name":"[05/41] hw/pci-host/q35: handle NULL bus in pci-hole64 getters","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b85d76d588fc860fbda3d9bb8c6e780a6738afad","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-5-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229109/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229109/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=U3luQWN0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DXy2bTqz1yJX\n\tfor ; Tue, 28 Apr 2026 05:44:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRrX-00015j-M2; Mon, 27 Apr 2026 15:43:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrD-0000vT-08\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:04 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRr9-0007lJ-Mu\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:01 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-iRs8dY4ANxiqQ6iN1C1KvQ-1; Mon,\n 27 Apr 2026 15:42:55 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AB4F6195609F\n for ; Mon, 27 Apr 2026 19:42:54 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5C44619560B1; Mon, 27 Apr 2026 19:42:52 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777318978;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8SNI1+7ODP9d4wGo3twIW0HT5Ncz2Zi9RbkwAn71yk4=;\n b=U3luQWN0dldfJXlciHpgZYlubIEbOu5uFkpdDg2xC7jYkJ2qBmSMfMXCKViIx0uH07KcWr\n xx9DI30F29LHLM3Uqlc8OdUIEpz6a9bZK8VnYMqGm/gYS6bN4O8G9boaM6f3BA/OANBNsd\n tejjomjVbsCjt+cusuMTN/3nBMdfVkQ=","X-MC-Unique":"iRs8dY4ANxiqQ6iN1C1KvQ-1","X-Mimecast-MFC-AGG-ID":"iRs8dY4ANxiqQ6iN1C1KvQ_1777318974","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:04 +0400","Subject":"[PATCH 05/41] hw/pci-host/q35: handle NULL bus in pci-hole64 getters","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-5-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n \"Michael S. Tsirkin\" ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1827;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=8e76537D5foz+/YCdH5/+xzv4nxJP353Lst5euJM2Tk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUpdJX9/qeaPQuc7r/VS2SBxeRwFhSvpzXn\n v9AnGks56GJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5cfzD/4twr3PbCkYodwlk2w7Z0fmNWOyK7bC9ESXDQVCUhzTka1DAMyqfj1CLK87TxyVE5tV0Eh\n cWf+5PXzmahDXqvxoV6J5F92nZSt5/uA01CSznlKszwBdJDliiWEBy0J3OjRoijoXFsfnMniOjA\n ovExHDbNQdMyv8fC13ImVQqlye/YFcGUvMOCz9p3hM9Lpy4FOQaslu3sF3QHn/JaEfGueD1VaEf\n UdGTmycNRgpupOwRzmUFCnVp4GJ/oK2ffAHdKNuDC8v21kjdkw8EzkgigJqK2kTkBpe7kNbcoWP\n IwOUKk8dJtjDlnIQBQBcFXOSsJv1PkaSvQWSYBvXrxlKNvbRSysqveRhxwFyc4o3s1j5/gNO4Uk\n uk3AngOVu7bY78APJIbH/nVKpZSKJN8SBlsVbU56NH+X4spOTb52f20aA0TqJ4MD9Cj2L3aCd/p\n ZDDdrWMUdn3LRhLOu8t9qD7p9MTXqi3ejlFwMb3TzD0Hu2R/TUY50vDFE+tV33vGKvE+fNBCJto\n CDxYAP8xOBCAhrPoo3UCKU+4+ERGQytbNkjcy5KaSVeQ++R4kc8IoZHYlWmGo3xlZWMBpZQrbR/\n JgHCk7LrCXIfrTt2qrjEaZFCFayPelzVdSKg9ii+5kmerRtSgXsu9yzCgt/lN/WzWqgWcbGXe/t\n IEWi1pW/TH9jaoA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When called on an unrealized Q35 host bridge (e.g. from\nqmp_qom_list_properties), h->bus is NULL since the root bus is only\ncreated during realize. Guard against this in both the\npci_hole64_start and pci_hole64_end getters.\n\nSigned-off-by: Marc-André Lureau \n---\n hw/pci-host/q35.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c\nindex e85e4227b37..149c32b4b0e 100644\n--- a/hw/pci-host/q35.c\n+++ b/hw/pci-host/q35.c\n@@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj, Visitor *v,\n const char *name, void *opaque,\n Error **errp)\n {\n- uint64_t hole64_start = q35_host_get_pci_hole64_start_value(obj);\n+ PCIHostState *h = PCI_HOST_BRIDGE(obj);\n+ uint64_t hole64_start;\n \n+ if (!h->bus) {\n+ error_setg(errp, \"bus not realized\");\n+ return;\n+ }\n+ hole64_start = q35_host_get_pci_hole64_start_value(obj);\n visit_type_uint64(v, name, &hole64_start, errp);\n }\n \n@@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, Visitor *v,\n {\n PCIHostState *h = PCI_HOST_BRIDGE(obj);\n Q35PCIHost *s = Q35_HOST_DEVICE(obj);\n- uint64_t hole64_start = q35_host_get_pci_hole64_start_value(obj);\n+ uint64_t hole64_start;\n Range w64;\n uint64_t value, hole64_end;\n \n+ if (!h->bus) {\n+ error_setg(errp, \"bus not realized\");\n+ return;\n+ }\n+ hole64_start = q35_host_get_pci_hole64_start_value(obj);\n pci_bus_get_w64_range(h->bus, &w64);\n value = range_is_empty(&w64) ? 0 : range_upb(&w64) + 1;\n hole64_end = ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL << 30);\n","prefixes":["05/41"]}