{"id":2229108,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229108/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-1-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-1-c413f3605311@redhat.com>","date":"2026-04-27T19:42:00","name":"[01/41] hw/pci: handle missing bus in prop_pci_busnr_get","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5dd5240ac140b420e9513f68b767c6576a9cc123","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-1-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229108/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229108/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=i+IZEjTP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DXx5CYpz1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRqy-0000r2-2Q; Mon, 27 Apr 2026 15:42:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRql-0000pC-UF\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:39 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRqk-0007ez-0u\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:42:35 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-aXZnIwACP_CyMswST68e4g-1; Mon,\n 27 Apr 2026 15:42:30 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 00A461956089\n for ; Mon, 27 Apr 2026 19:42:30 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9F3A11800664; Mon, 27 Apr 2026 19:42:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777318952;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LNwbxYxWQ04sNy4bBLSed8SroTUWt0gC5fF5Xjj2gTA=;\n b=i+IZEjTPWOImh31CwMqoJOFdeBzksG2aEXXRxevtfFHHXuhq3eoEn6f+S1s1mFoFv7TcC+\n rMlb1J5vAnqjfYn2Lc76MUceFVPY4Dod1x2NBjJD1a9QxVgmYQY/RjJsrXzM1Sz13KtHac\n S25uFb0P9qjWa8OULYKkJMK2pvqniAI=","X-MC-Unique":"aXZnIwACP_CyMswST68e4g-1","X-Mimecast-MFC-AGG-ID":"aXZnIwACP_CyMswST68e4g_1777318950","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:00 +0400","Subject":"[PATCH 01/41] hw/pci: handle missing bus in prop_pci_busnr_get","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-1-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n \"Michael S. Tsirkin\" ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1270;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=P8mQvnMK/kAJD5u8Y7BnOIAYXw5cBODLSGhSeHfU+Ug=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUCSpgafM7qyg1PvbrmiREBZP6oFhStmU2U\n tMJvXGTP9CJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5XTqD/9CvkfW7mTllAvHZ2AT6f9GPWMs9EBtQEzZjBMTPmdJy2wbEVOOKeEwIWpSxGQPqt9ZqUV\n T0cTkQ3auWdpDBlycfhmpqugb6q+u1QZVlXA88J3nSGrXKRDXODy+t0L3j6mZchbhT2h9ZlN52D\n vgsi2Ch4ueqM8xrT39ec1PFzwRd4C9OPbWhwreS/PrX+SUirssX8MMEolodvH6yoX5Ytdh+gRtv\n aeYy7IKN8gIDRBAoPuIFd6MwwWk4KT0A76lDl0pd4dMCAYVoqgJKJ7zzxL92Ny3cMztFU1oQpLN\n +0aodTrLuSIcA53sWxsFEJb3bqAFoAEEeT31GbomLDDDa/p7mVsb3Se/LuV9mAD2omY3ZbzwUSl\n lHYCHdVySrqv3PUITuwyrpxmuion5UGJ/bouN+oxn0Tots8BgzcTdBaqObd57hTFTf+ljg4QLEI\n 4OGGGFHjjpZ8LP5sYZA22vNLP94Cl+wXW7JA7ch/1iWCwZLJhMC6ftDLP1jhlAAbCDh2BEOwSJ1\n I9RFHew3jMWG7kYscKJH5LEy3gqKrcof70DH119fvOV26ik5cjvjILiakQWIUy1HZEj58MfX9cZ\n sXmqarT4Yn21o8bAgSFq/lx04J9Dq9Xi3+/MeVpHWCuisQONlnbN31J6u2A0HfE5cfjt1q9fC2a\n CNS+/Mbrn6PxdCQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When called on an unrealized device (e.g. from\nqmp_qom_list_properties), pci_get_bus() returns NULL since the device\nhas no parent bus. Check for this to avoid a NULL dereference in\npci_bus_num().\n\nFixes: df9ac7254fd9 (\"hw/pci: Add a busnr property to pci_props and use for acpi/gi\")\nSigned-off-by: Marc-André Lureau \n---\n hw/pci/pci.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/pci/pci.c b/hw/pci/pci.c\nindex a0dbb81fd90..bf13cabd174 100644\n--- a/hw/pci/pci.c\n+++ b/hw/pci/pci.c\n@@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType type);\n static bool pcie_has_upstream_port(PCIDevice *dev);\n \n static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name,\n- void *opaque, Error **errp)\n+ void *opaque, Error **errp)\n {\n- uint8_t busnr = pci_dev_bus_num(PCI_DEVICE(obj));\n+ PCIDevice *dev = PCI_DEVICE(obj);\n+ PCIBus *bus = pci_get_bus(dev);\n+ uint8_t busnr;\n \n+ if (!bus) {\n+ error_setg(errp, \"device not attached to a PCI bus\");\n+ return;\n+ }\n+ busnr = pci_bus_num(bus);\n visit_type_uint8(v, name, &busnr, errp);\n }\n \n","prefixes":["01/41"]}