{"id":2229106,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229106/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-7-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-7-c413f3605311@redhat.com>","date":"2026-04-27T19:42:06","name":"[07/41] qom: skip link property check callback when clearing link","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"440426476054227142784589fc4d1064e05d5f49","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-7-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229106/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229106/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QepGUPc7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DXl60zmz1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRs1-0001VL-Vo; Mon, 27 Apr 2026 15:43:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrU-00017l-4Q\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:22 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrL-0007mG-0D\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:13 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-owOWmJtIOk6rRrLYNehKWA-1; Mon,\n 27 Apr 2026 15:43:08 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 423B41956094\n for ; Mon, 27 Apr 2026 19:43:07 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E0ED33000C22; Mon, 27 Apr 2026 19:43:05 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777318989;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dkX4SaBJSWzoDN/sOyJvVpRC/vSgOt3wi3wuQ84cUVk=;\n b=QepGUPc7ydkDS0Kqkk+XA0k1WNAakvGbDH6VQgAA3C0GznQj7B7BIV5SQkKFR+HiBHd3YA\n VDvASYvQeE2JpTiyU1Qc5b8IPNhl0kg5pfol558I1nBbJkDqKEAEyVVMUwGN00q9MhHobh\n puZpwNSzla2OxNO4iyXTdCPxDMMxrSI=","X-MC-Unique":"owOWmJtIOk6rRrLYNehKWA-1","X-Mimecast-MFC-AGG-ID":"owOWmJtIOk6rRrLYNehKWA_1777318987","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:06 +0400","Subject":"[PATCH 07/41] qom: skip link property check callback when clearing\n link","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-7-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1162;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=vC5EqRuLT1EHVRF50SbrOTYnlQJlgmg5h0I92toPkN4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUuEHAbsYlatMksb7LilqMPlMdLwvSSQuJl\n 9b1KUoGSH6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5RYuD/sFkxlPXbMwzaV6K6bhiZH2HINk243XPDTtBVV9408K/K28p5QpmJFcCxnJPqyCF8EACkQ\n Cpn1L1irJP4EqS9YVShUOVlBDA5duSI0a+sGT396B5AM6mIScBXnNY/TpqSORTRR6WuqS4KafzY\n XcydlKxzP5HocaxiE4Jts5J1ODhVFRrEg+OCbZ7OFHP4r/gitaXslJDatrH9NidHdW2gixaR63p\n FLvWnG3ZB3k5q/6ajWR93MYE5Ahpj+34GPAu9a1Ex+d6FCTU/7E8PMyok9uPL1jZy88+1CH2pfA\n CBu8DK3e5yO1j93ykVKYTvCkfuIdVfujJyhnEfouSAVnglCNUCk0V3rAJRvePy2cpsaZjYAnQbZ\n f/T041/yRT7VoPEFtPXnoz2Cofi8TgTeEV+NXyeeuI2sikiPPUixyvcj7ecz308sCVwLtpyatuE\n fItz+BikPN3kFoN81TG/cK4tjtWIOPBYluaP7nA+7UI2nLU5e1MFgRnkn1y5mXrpIAAJ7k8CfGX\n jRiIED/i2Grt5S3dW30zWsC+Pba/RN7tUDiXGsXqmz/KHgf793A+sesrz9pyZwtb/H3/mwCSn5p\n 9nrDqTD96OWKtabsAU0sOp6TIeNL025tSeBQev04e7dp+noKD8p27tK5PDbi7RBANxSFe9VGodC\n XtRPbqT5PmDKbug==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When setting a link property to an empty string (clearing the link),\nnew_target is NULL. The check callback is still invoked with this NULL\nvalue, but callbacks like isa_ipmi_bmc_check() cast it with\ntype-checking macros (IPMI_BMC(val)) which crash on NULL.\n\nThere is nothing to validate when the link is being cleared, so skip\nthe check callback entirely when new_target is NULL.\n\nSigned-off-by: Marc-André Lureau \n---\n qom/object.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/qom/object.c b/qom/object.c\nindex f981e270440..c50334b3023 100644\n--- a/qom/object.c\n+++ b/qom/object.c\n@@ -1903,10 +1903,12 @@ static void object_set_link_property(Object *obj, Visitor *v,\n \n g_free(path);\n \n- prop->check(obj, name, new_target, &local_err);\n- if (local_err) {\n- error_propagate(errp, local_err);\n- return;\n+ if (new_target) {\n+ prop->check(obj, name, new_target, &local_err);\n+ if (local_err) {\n+ error_propagate(errp, local_err);\n+ return;\n+ }\n }\n \n *targetp = new_target;\n","prefixes":["07/41"]}