{"id":2229104,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229104/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-8-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-8-c413f3605311@redhat.com>","date":"2026-04-27T19:42:07","name":"[08/41] hw/intc/apic: guard against NULL cpu in set_id","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e98fe52e7e6d2dd7a0267d1955b8f153f108b3c0","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-8-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229104/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229104/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=flVgYHmP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DXR26LMz1yHv\n\tfor ; Tue, 28 Apr 2026 05:44:07 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRrx-0001TO-O8; Mon, 27 Apr 2026 15:43:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrX-00019j-D5\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:26 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrQ-0007mp-Cn\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:20 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-SzoP2UELNFC540owXlEy3A-1; Mon,\n 27 Apr 2026 15:43:13 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id ED6E919560AA\n for ; Mon, 27 Apr 2026 19:43:12 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A20AA300070A; Mon, 27 Apr 2026 19:43:11 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777318995;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jsDuVbJMnbV55+CZsRKXWrAKU/qLmpyZfnS+LXbfJaY=;\n b=flVgYHmPT75D0jvzMyVeuIhQuKrRqCl2xOr72SbC//uO57GegAYyNqZnZTKs83Heg68CbN\n nynZHp8dLkv8xBDsYBwx742JxxtB8ZtfvPd8Wjgya0pceTPoHHC3s4Z1me6hVFXVS92gYI\n X3e9bP+gehfXkufGPzihWNVQNr1w5NU=","X-MC-Unique":"SzoP2UELNFC540owXlEy3A-1","X-Mimecast-MFC-AGG-ID":"SzoP2UELNFC540owXlEy3A_1777318993","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:07 +0400","Subject":"[PATCH 08/41] hw/intc/apic: guard against NULL cpu in set_id","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-8-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n \"Michael S. Tsirkin\" , Paolo Bonzini ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1117;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=H/f0y1ZnM9kksExg6Lf8cmvRVM4vb76ZFVmLHYG2Wgc=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUYlNFKpccl4gxJ2U0GJ/9luzgYzhAvxbdX\n Nk0MqWZG5eJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5ZkoEACUuA5REwi62+En3zKbTk8/3i/t12qRrpbkH8piICTfxS32qkvA1P/U4agWSacmWTcuaxy\n 4Gtq87Zb48YRIxxRiCBBW9dQY8pKKmgIoBSc2vYteW9lRpkS7CQBlyazvpG75LSFznmXh7HGDMG\n Zrlmq4RreXplBPcAe9FKT4Fn8yCJMw9w0VJ1maXwStnFNyYf9XB4aOVpZx9rvw/iirpprXgtA65\n GFsWbLxOYeg3piPyoVSLID4L01fGlovT5gWuoYDtSDau16YvK4QeseXaaeJJTWipqenwsHi3ieD\n SdcK30Np+NeUBgso7abywsme8ocaRQRBh4gqUpkr0VMH8b1y0wO8WtyVUobgfaDMb8iulQtx3eS\n sUwBW0uU11SgRV8HniCKHQqeFITYjLgnS/zP3pCRzpj9Iu2XSm1vLIrmzt2J8emi91xsvNh6d/J\n Js/LvAYcuXrCY+eutgdgl7ZDfwhYfmrHV+GASpaHcTs+dMjYSVLMVxTihtTHsc9q0q3G8DyPSwR\n Xdtb4IsBLLQaXEEjnP/v1gIw13pXGtd+fj2BDjnatqhkSDg1NgRFhPgvE2Y1gg2G9pc5581y0cp\n CrQ2flZaN+wUTXCXX5bst87KNRIYzLUjuVLjFDliFfkZLaxWgExGKZcmkJUzOiVQKo83OTcyUIV\n wh26Y4vgqphxk0g==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"apic_common_set_id() dereferences s->cpu to check for x2APIC support\nwhen the APIC ID is >= 255. On a standalone APIC object that has not\nbeen attached to a CPU, s->cpu is NULL, causing a segfault.\n\nAdd a NULL check before dereferencing. When there is no CPU, the\nx2APIC feature cannot be verified, so reject the large APIC ID.\n\nFixes: b5ee0468e9d2 (\"apic: add support for x2APIC mode\")\nSigned-off-by: Marc-André Lureau \n---\n hw/intc/apic_common.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c\nindex bf4abc21d7b..874a05e529c 100644\n--- a/hw/intc/apic_common.c\n+++ b/hw/intc/apic_common.c\n@@ -421,7 +421,7 @@ static void apic_common_set_id(Object *obj, Visitor *v, const char *name,\n return;\n }\n \n- if (value >= 255 && !cpu_has_x2apic_feature(&s->cpu->env)) {\n+ if (value >= 255 && (!s->cpu || !cpu_has_x2apic_feature(&s->cpu->env))) {\n error_setg(&local_err,\n \"APIC ID %d requires x2APIC feature in CPU\",\n value);\n","prefixes":["08/41"]}