{"id":2229103,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229103/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-6-c413f3605311@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-qom-tests-v1-6-c413f3605311@redhat.com>","date":"2026-04-27T19:42:05","name":"[06/41] hw/remote: check visit return in vfu_object_set_socket","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d725851bbb8f02eb068104b44638e1fe9ad24901","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-6-c413f3605311@redhat.com/mbox/","series":[{"id":501716,"url":"http://patchwork.ozlabs.org/api/1.1/series/501716/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716","date":"2026-04-27T19:42:03","name":"Fix various QOM object life-cycle issues","version":1,"mbox":"http://patchwork.ozlabs.org/series/501716/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229103/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229103/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HndBesju;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DX20WNCz1yHv\n\tfor ; Tue, 28 Apr 2026 05:43:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRre-0001Dh-BO; Mon, 27 Apr 2026 15:43:31 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrM-0000yi-6U\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:14 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRrE-0007lk-So\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:08 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-uY5k2CaGNz6QCrNEUz8r8g-1; Mon,\n 27 Apr 2026 15:43:02 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2410A195608B; Mon, 27 Apr 2026 19:43:01 +0000 (UTC)","from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8017A19560B1; Mon, 27 Apr 2026 19:42:58 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777318983;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1pEn/2hVVxeAUWb0BmkZAfz7mfTs19c+tKrVGD3uLaA=;\n b=HndBesjua9M3q88FNIMiSz7Mf4qOcF6MJjigZaMJaaEXa6vAXQFGkpT4aKrxTi9agaJ01d\n xhgIuVnL4P7nu39nIILORr5Scih/haLfUCJB7BlMRZwHofNwxj6jppkimCXj94cFUXoAlS\n RuLehzr8zlwAGTcPGfCB9BPsmrjpsqo=","X-MC-Unique":"uY5k2CaGNz6QCrNEUz8r8g-1","X-Mimecast-MFC-AGG-ID":"uY5k2CaGNz6QCrNEUz8r8g_1777318981","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 27 Apr 2026 23:42:05 +0400","Subject":"[PATCH 06/41] hw/remote: check visit return in vfu_object_set_socket","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260427-qom-tests-v1-6-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Elena Ufimtseva ,\n Jagannathan Raman ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1017;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=OO0tb8zQyK1Y9je3PseFy7KqoAQ349m+oesD3AFJRzk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wU86khG3YZJuikiYHMH9sfKpSwXyEdq8g2x\n RpYPJHmxPCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5QUdD/0fBGHHHdAkPVR5h0zXL0jd5tdmTxVYBKZh7iydIvp/mgBymlidKHBeDa3RMIO7hagKzRv\n fjh5G6kZOLl0X7Q9WwliRbTmqorCBTIGUqYWCA+d3sQeVZ4/i0OaI8K7nsX0iuY3iLIO78n1Lc5\n 8BEgVlVD9vGYYBARzRio9isOKPip48S8BtyJbzn77yaVYggfEgOVhh8bSjNBHwg4DvZy0ugvHAK\n qqr3tz5mtASoCPRRLRPeVvKlEBu64107gxHudvVLJp6uauqLK7phR48/8QlU4masWcymIzkqEol\n MP7TqiDA18jE1kCQKs3G/G+G2MPS9qi9Z9c0Xn9V01O8qimncpLcaC82a/xZv3TGB5qQ1ctIdIz\n ZbhO52ddIevbqpnlMwJUajpjqukuhlRf0fIkUGgBUzUeWDhr1lXW+NMT8PA5BdfO/O5Jqbgpy9a\n gXdg5YUGcddQHQkvSHBtoieZTAwPZA/8DG4GoHkjvITi6+CFn3zVVpP8rdOiZAoO2V2HICz0Yeh\n /2t47gEL68Zm/W6tV5AloRnyhi+QHEr6v2bowce8RBAgNj/2AVt8NSE79lIBYdwnn2HyhrtqHcN\n YpMxgpFSRPAOb7wFKYx0PV4UIkSHr2KeJT8R/MkqPZD57N9+/hwXD921bVeQvqnAFzVcVG8IWZl\n bLZxinbNIQpMl8Q==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"vfu_object_set_socket() dereferences o->socket without checking if\nvisit_type_SocketAddress() succeeded. On failure, o->socket remains\nNULL, leading to a NULL dereference. Check the return value.\n\nFixes: 8f9a9259d32c (\"vfio-user: define vfio-user-server object\")\nSigned-off-by: Marc-André Lureau \n---\n hw/remote/vfio-user-obj.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c\nindex 12ecdab6dea..49bf5ecae0c 100644\n--- a/hw/remote/vfio-user-obj.c\n+++ b/hw/remote/vfio-user-obj.c\n@@ -161,7 +161,9 @@ static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name,\n \n o->socket = NULL;\n \n- visit_type_SocketAddress(v, name, &o->socket, errp);\n+ if (!visit_type_SocketAddress(v, name, &o->socket, errp)) {\n+ return;\n+ }\n \n if (o->socket->type != SOCKET_ADDRESS_TYPE_UNIX) {\n error_setg(errp, \"vfu: Unsupported socket type - %s\",\n","prefixes":["06/41"]}