{"id":2229099,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229099/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-gtk-clipboard-v4-1-176ad9919931@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427-gtk-clipboard-v4-1-176ad9919931@gmail.com>","date":"2026-04-27T19:39:10","name":"[v4,1/2] ui/gtk: Use non-blocking clipboard retrieval","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f5bd2d8ab10bc94dbc705b1ee6942ca6bef9804","submitter":{"id":4408,"url":"http://patchwork.ozlabs.org/api/1.1/people/4408/?format=json","name":"Jindrich Makovicka","email":"makovick@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-gtk-clipboard-v4-1-176ad9919931@gmail.com/mbox/","series":[{"id":501714,"url":"http://patchwork.ozlabs.org/api/1.1/series/501714/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501714","date":"2026-04-27T19:39:11","name":"Fix and re-enable GTK clipboard","version":4,"mbox":"http://patchwork.ozlabs.org/series/501714/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229099/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229099/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JsZKJVTs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DS0564Qz1yJX\n\tfor ; Tue, 28 Apr 2026 05:40:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHRnp-0007Uq-VZ; Mon, 27 Apr 2026 15:39:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHRna-0007T8-0R\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:39:20 -0400","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHRnY-0006s8-Dl\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:39:17 -0400","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso113154385e9.2\n for ; Mon, 27 Apr 2026 12:39:15 -0700 (PDT)","from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a773e70c2sm8281035e9.10.2026.04.27.12.39.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 12:39:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777318754; x=1777923554; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=o1m5TZjfPpKFGxNcdvdtQL+COsgMLl98v9ZR1ImYqYM=;\n b=JsZKJVTslNlRLf5GumJ8nz0Ym7TzKFXcfz/jKn24Y4yvR/FH4pnTsvWMcf5zzCiwPe\n EpGy5IicWWOFzjiDma8OBLgkYHvTn58S/k1lqXJ08Nic74Lm4ktWokANA4IQKniUGwyc\n eToIb+IESv8nBQGQFmBrGdzel+HDMsXG/fE3yIRWFoAu14ovmYpGkrRXOuwP8zqRnBFZ\n 7ECRrbDKlZn6bRSmdHLYqAE4uuEIs/MOf5uC5wUhzmweP1riDxEbjD/YNmdW0zXsWop/\n ZnZhfmXmOP7t6oRc9UBg7dLhXgDlKaH392lnSqpne312d5/2TSOJF15MKFpD2M3PBxJs\n ds+w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777318754; x=1777923554;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=o1m5TZjfPpKFGxNcdvdtQL+COsgMLl98v9ZR1ImYqYM=;\n b=OhVwdA/cvSCte+VHdZYiAKPPd1b9pru1NhqxoR4wNVGwcH5/1oaLBuGUj2M1owDILv\n HSJd9qqhx8OkJw9mMPW98Q1lr3NtK2UMWCe8uqfpm/K20mbq40T0BCJ88t7z1IOs2pop\n i3Fm4Odu1Y+z9ho9unB43noI2O5Otou0frrdkp6wOfUm3cdB23Paa/2cUugmjFis8Hhn\n CHY2LZ/7n4tCvtGuky204HYIVcDfoTj92j84ZPiUEFuNN9IvipvnGldWTtIt9SJRNV0m\n k0Q/B908UraKzTuMpGUJmUX9qr9bsyKEVEi2qdasbLar0XKxlDQrg/g5p6/8OfU7zFiv\n QnsQ==","X-Gm-Message-State":"AOJu0YxyAKm3NnSH/0+aQ+tA608fS/6Kml1drV6Oqpk8x2HyI/5Yu278\n q4fPfdRDFRHsMvfVnxJeMU+8Gp9YJG6Q4pVgGV9aX84jt9yv/VVoPOIA","X-Gm-Gg":"AeBDies9tmd/r8OWLq+ySlt9mXsJiJ2cX3rgjBr6gb71HFU5nUowMj+IshIsRMdeqK8\n hY38/2jNGSE7WneF8NWBW8dc6Sz3Nq0Xhg8Y1m/7MrHHK6+ybUzlsxLBnlflYlnUa08nenuf+2+\n qcwA1xWQtaByoaGbXiqT4dFRRJ6ReImMhwdFSnVDoC4sqrDp948o2zvWvaKQtlQHpUX/GD5+4OY\n WRHUfH9WTuzN2kjG6w0HIctzQL2uW7XhveVfzLOxNJVfRuo5n9UbOOoCdk2Rb0q9isdpvc17ag7\n OHnb7aX1a3gwWb6f5Abtj4t0536F8VRNzEM1iKkpR3iHjOEI5b5+NcnWYcFb7WgjI699az92z7L\n A/fSwOgfdrKCmEc9JfUoonhv1lFuGAnT2rO4vjp/0b5gGV4tW+ewOZd2TUy7+nYe61SLzk8Us94\n kCimemhFyA86YPpujJGGL68lVdsSR1Og9Fxr0fA4M=","X-Received":"by 2002:a05:600c:3386:b0:488:a977:8de with SMTP id\n 5b1f17b1804b1-48a77e64f29mr142535e9.16.1777318754450;\n Mon, 27 Apr 2026 12:39:14 -0700 (PDT)","From":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ","Date":"Mon, 27 Apr 2026 21:39:10 +0200","Subject":"[PATCH v4 1/2] ui/gtk: Use non-blocking clipboard retrieval","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260427-gtk-clipboard-v4-1-176ad9919931@gmail.com>","References":"<20260427-gtk-clipboard-v4-0-176ad9919931@gmail.com>","In-Reply-To":"<20260427-gtk-clipboard-v4-0-176ad9919931@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Pierrick Bouvier ,\n Jindrich Makovicka ","X-Mailer":"b4 0.14.3","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=makovick@gmail.com; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Jindrich Makovicka \n---\n ui/gtk-clipboard.c | 53 ++++++++++++++++++++++++++++++++++++++++-------------\n 1 file changed, 40 insertions(+), 13 deletions(-)","diff":"diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c\nindex 65d89ec601..463ed4e905 100644\n--- a/ui/gtk-clipboard.c\n+++ b/ui/gtk-clipboard.c\n@@ -136,26 +136,55 @@ static void gd_clipboard_notify(Notifier *notifier, void *data)\n }\n }\n \n+static void\n+gd_clipboard_request_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+\n+ if (text) {\n+ qemu_clipboard_set_data(info->owner, info, QEMU_CLIPBOARD_TYPE_TEXT,\n+ strlen(text), text, true);\n+ }\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_clipboard_request(QemuClipboardInfo *info,\n QemuClipboardType type)\n {\n GtkDisplayState *gd = container_of(info->owner, GtkDisplayState, cbpeer);\n- char *text;\n \n switch (type) {\n case QEMU_CLIPBOARD_TYPE_TEXT:\n- text = gtk_clipboard_wait_for_text(gd->gtkcb[info->selection]);\n- if (text) {\n- qemu_clipboard_set_data(&gd->cbpeer, info, type,\n- strlen(text), text, true);\n- g_free(text);\n- }\n+ qemu_clipboard_info_ref(info);\n+ gtk_clipboard_request_text(gd->gtkcb[info->selection],\n+ gd_clipboard_request_text_received_callback,\n+ info);\n break;\n default:\n break;\n }\n }\n \n+static void gd_clipboard_owner_change_targets_received_callback(\n+ GtkClipboard *clipboard,\n+ GdkAtom *targets,\n+ gint n_targets,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+\n+ if (n_targets) {\n+ if (gtk_targets_include_text(targets, n_targets)) {\n+ info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n+ }\n+ }\n+\n+ qemu_clipboard_update(info);\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_owner_change(GtkClipboard *clipboard,\n GdkEvent *event,\n gpointer data)\n@@ -173,12 +202,10 @@ static void gd_owner_change(GtkClipboard *clipboard,\n switch (event->owner_change.reason) {\n case GDK_OWNER_CHANGE_NEW_OWNER:\n info = qemu_clipboard_info_new(&gd->cbpeer, s);\n- if (gtk_clipboard_wait_is_text_available(clipboard)) {\n- info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n- }\n-\n- qemu_clipboard_update(info);\n- qemu_clipboard_info_unref(info);\n+ gtk_clipboard_request_targets(\n+ clipboard,\n+ gd_clipboard_owner_change_targets_received_callback,\n+ info);\n break;\n default:\n qemu_clipboard_peer_release(&gd->cbpeer, s);\n","prefixes":["v4","1/2"]}