{"id":2229087,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229087/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260427193139.2109938-1-skhawaja@google.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260427193139.2109938-1-skhawaja@google.com>","date":"2026-04-27T19:31:38","name":"PCI: Init driver override spinlock in new_id_store()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1302f02ad2f298f5a5eeb2cf214ab287a7c5b681","submitter":{"id":91295,"url":"http://patchwork.ozlabs.org/api/1.1/people/91295/?format=json","name":"Samiullah Khawaja","email":"skhawaja@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260427193139.2109938-1-skhawaja@google.com/mbox/","series":[{"id":501712,"url":"http://patchwork.ozlabs.org/api/1.1/series/501712/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=501712","date":"2026-04-27T19:31:38","name":"PCI: Init driver override spinlock in new_id_store()","version":1,"mbox":"http://patchwork.ozlabs.org/series/501712/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229087/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229087/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=DYeTMuAe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53245-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=google.com header.i=@google.com\n header.b=\"DYeTMuAe\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.202","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=google.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=flex--skhawaja.bounces.google.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DGv4D05z1xvV\n\tfor ; Tue, 28 Apr 2026 05:32:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CDDF5303D73C\n\tfor ; Mon, 27 Apr 2026 19:32:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2978041B374;\n\tMon, 27 Apr 2026 19:32:01 +0000 (UTC)","from mail-pl1-f202.google.com (mail-pl1-f202.google.com\n [209.85.214.202])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 02AA241B362\n\tfor ; Mon, 27 Apr 2026 19:31:58 +0000 (UTC)","by mail-pl1-f202.google.com with SMTP id\n d9443c01a7336-2b2e6ee9444so114248335ad.1\n for ; Mon, 27 Apr 2026 12:31:58 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777318321; cv=none;\n b=BgYMCq3EOYDJvGufTKcwuoAdsYuycVVcoYOzdlsVQz1+azQNq2rhQ/a9Gg6JWG3RVElD5fJfzEVLu6LRuPATjK+hODxyFiIQXplWwV8UvIxs2ZXRNR2P39gmduMdZPVAX1QcDzjBGVWNDo7lFr14FqlELqHIKF0aZQKeFQCPUj0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777318321; c=relaxed/simple;\n\tbh=LVmCeMbPONRbWHAmNFPGHdz4QzY8fHP3vOP6GzcGnRU=;\n\th=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type;\n b=VgyN8zzNM5NWBGBzuNRrJXZxawnu5dI7XVmZOZVzUXUEuOg/KNRRk7jb7oEu2JosMeX0PAthYWNfU2nl2mQ1EGlcysJk4fFa2ZUTMxGOpddUMUNPZnxAQ6QUGKVgW1JCa21ndIViQ/HfeHDUdWQyRGcjm6jkc/QMnPRHH20oJCM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=google.com;\n spf=pass smtp.mailfrom=flex--skhawaja.bounces.google.com;\n dkim=pass (2048-bit key) header.d=google.com header.i=@google.com\n header.b=DYeTMuAe; arc=none smtp.client-ip=209.85.214.202","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777318318; x=1777923118;\n darn=vger.kernel.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=snPdlzVdOYUMpgWp4O8YWqXKWZOQ7VLQKeDCjnOdDtE=;\n b=DYeTMuAeP/GoKy2Dhhs3rvzRf2vHU2G61rL1gUIeND9t3PYoAQNblwMmxwoYXeT68g\n H4UIdyp6ZuM1usHZpAFe5hZT4WxcFIsSaQi3c2Xcdz5BSzDe7jLBsklpFb+RRk9MCXtl\n G260v/VF5VQXMFwnbpf2igjRMfjK9OHBchx99mQE7LY93GtAg/LKIzQtZU9kdkQdvhYF\n K9nKBKQXoUNgGUK9xIWYNHr0Y4wHToTNQ0oXMDZUvcXXsnM31GYpAT4shxwMvgZgdLcH\n nfIfEgnMc78HZjnUgH69zYEl6GGV+CaaegoQmYHOZm76rx1H9i70QJSmYMZZCPH4Ob80\n PtWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777318318; x=1777923118;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=snPdlzVdOYUMpgWp4O8YWqXKWZOQ7VLQKeDCjnOdDtE=;\n b=U5FJuMJPukrCi0HyWwbTh8GjzTnP1JZVh9zqMgHNtIBxazcypL8WyJKWeG8PaqWIJW\n S38SIxnwadY+7cXhoZL990g6JWVVGkWja2bOqM4r5ulR/u4Zh7GLBEPQBIw6l552HjVY\n ifAyIP9Q718da8t0Cto3Hv7g6QBNJYkLXgAWlzdMi6wmrMGWKfbDklF+o/WIdLnFIh47\n QE9XctYWlZtP2srDFCDhW4e9GgyDRgLBGb4niwz06oscz/hrBPFBjHSWbweZ2iAhToXS\n ahyr0voVoL39woTH5Guqd+jbpdfLuZTCr7ADPoeHpeyYkkDeMFovwPReiZaG8gnk35Gi\n 9xbw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/E8BBZH1PJS7vPpRhzYAT1TecNUgUkOIRpEJRPM1HsAtU9p++eC8cWoc8goL/CP/v06cHMJfUX8H4=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw1ysyKnTet7mAZC3Z+1823b8+OgyHRDB7TJ6k/9f42KJSO05ZR\n\tHy+DzF7vj+986OqWVsdn9xJApYZK++12uhQj+BpfXJHUnlJBp1mnVlDLgjG37PdyrBzFERVpuA9\n\t4NCBvS6L4b8IjSw==","X-Received":"from plda4.prod.google.com ([2002:a17:902:ee84:b0:2b0:af2d:2502])\n (user=skhawaja job=prod-delivery.src-stubby-dispatcher) by\n 2002:a17:903:1107:b0:2b4:5bf8:a7e1 with SMTP id\n d9443c01a7336-2b97bfd91e7mr146815ad.6.1777318318229;\n Mon, 27 Apr 2026 12:31:58 -0700 (PDT)","Date":"Mon, 27 Apr 2026 19:31:38 +0000","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","Mime-Version":"1.0","X-Mailer":"git-send-email 2.54.0.545.g6539524ca2-goog","Message-ID":"<20260427193139.2109938-1-skhawaja@google.com>","Subject":"[PATCH] PCI: Init driver override spinlock in new_id_store()","From":"Samiullah Khawaja ","To":"Bjorn Helgaas , Danilo Krummrich ,\n\tGui-Dong Han ,\n Greg Kroah-Hartman ,\n\tAlex Williamson ,\n \"open list:PCI SUBSYSTEM\" ,\n\topen list ","Cc":"dmatlack@google.com, Samiullah Khawaja ,\n\t\"open list:PCI SUBSYSTEM\" ,\n open list ","Content-Type":"text/plain; charset=\"UTF-8\""},"content":"When setting new_id of a PCI device driver using sysfs a lockdep splat\noccurs. This is because the new_id function new_id_store() checks for\ndriver_override by creating temporary pci_dev structs.\n\nSince the newly added driver_override spinlock is not init for temporary\npci_dev structs, the lockdep splat complains about it.\n\nInit the driver_override spinlock to fix this.\n\n[ 4.464296] INFO: trying to register non-static key.\n[ 4.466207] The code is fine but needs lockdep annotation, or maybe\n[ 4.468487] you didn't initialize this object before use?\n[ 4.470486] turning off the locking correctness validator.\n[ 4.472494] CPU: 2 UID: 0 PID: 177 Comm: liveupdate-iomm Not tainted 7.0.0+ #9 PREEMPT(full)\n[ 4.472497] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014\n[ 4.472498] Call Trace:\n[ 4.472501] \n[ 4.472503] dump_stack_lvl+0x5d/0x80\n[ 4.472508] register_lock_class+0x77e/0x790\n[ 4.472512] ? check_prev_add+0xf4/0xd30\n[ 4.472513] ? check_prev_add+0xf4/0xd30\n[ 4.472515] __lock_acquire+0x3b4/0x1b80\n[ 4.472518] ? raw_irqentry_exit_cond_resched+0x20/0x50\n[ 4.472556] lock_acquire+0xbf/0x2e0\n[ 4.472558] ? pci_match_device+0x24/0x180\n[ 4.472563] _raw_spin_lock+0x30/0x40\n[ 4.472567] ? pci_match_device+0x24/0x180\n[ 4.472569] pci_match_device+0x24/0x180\n[ 4.472571] new_id_store+0x189/0x1d0\n[ 4.472574] kernfs_fop_write_iter+0x14f/0x210\n[ 4.472578] vfs_write+0x263/0x5e0\n[ 4.472583] ksys_write+0x79/0xf0\n[ 4.472585] do_syscall_64+0x117/0xf80\n[ 4.472587] ? clear_bhb_loop+0x40/0x90\n[ 4.472590] entry_SYSCALL_64_after_hwframe+0x77/0x7f\n[ 4.472592] RIP: 0033:0x7fe7bc0beeb2\n[ 4.472595] Code: 18 41 8b 93 08 03 00 00 59 5e 48 83 f8 fc 75 1a 83 e2 39 83 fa 08 75 12 e8 2b ff ff ff 0f 1f 00 49 89 ca 48 8b 44 24 20 0f 05 <48> 83 c4 18 c3 66 0f 1f 84 00 00 00 00 00 48 83 ec 10 ff 74 24 18\n[ 4.472596] RSP: 002b:00007ffcdbb1ed80 EFLAGS: 00000202 ORIG_RAX: 0000000000000001\n[ 4.472598] RAX: ffffffffffffffda RBX: 00007fe7bc2415c0 RCX: 00007fe7bc0beeb2\n[ 4.472599] RDX: 000000000000000a RSI: 00005580955433c0 RDI: 0000000000000001\n[ 4.472600] RBP: 000000000000000a R08: 0000000000000000 R09: 0000000000000000\n[ 4.472601] R10: 0000000000000000 R11: 0000000000000202 R12: 000000000000000a\n[ 4.472602] R13: 00005580955433c0 R14: 000055805932493e R15: 0000558095545490\n[ 4.472605] \n\nFixes: cb3d1049f4ea (\"driver core: generalize driver_override in struct device\")\nFixes: 10a4206a2401 (\"PCI: use generic driver_override infrastructure\")\nSigned-off-by: Samiullah Khawaja \n---\n drivers/pci/pci-driver.c | 5 +++++\n 1 file changed, 5 insertions(+)\n\n\nbase-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731","diff":"diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c\nindex d10ece0889f0..5f453213b8c5 100644\n--- a/drivers/pci/pci-driver.c\n+++ b/drivers/pci/pci-driver.c\n@@ -215,6 +215,11 @@ static ssize_t new_id_store(struct device_driver *driver, const char *buf,\n \t\tpdev->subsystem_device = subdevice;\n \t\tpdev->class = class;\n \n+\t\t/*\n+\t\t * Initialize the embedded struct device driver_override lock to\n+\t\t * avoid the lockdep errors.\n+\t\t */\n+\t\tspin_lock_init(&pdev->dev.driver_override.lock);\n \t\tif (pci_match_device(pdrv, pdev))\n \t\t\tretval = -EEXIST;\n \n","prefixes":[]}