{"id":2229023,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229023/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427170520.101242-5-kwolf@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427170520.101242-5-kwolf@redhat.com>","date":"2026-04-27T17:05:20","name":"[4/4] iotests/046: Test that discard/write_zeroes wait for dependencies","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"16df7fd27fa1874c6ae1024cde6e94808ccca239","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/1.1/people/2714/?format=json","name":"Kevin Wolf","email":"kwolf@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427170520.101242-5-kwolf@redhat.com/mbox/","series":[{"id":501688,"url":"http://patchwork.ozlabs.org/api/1.1/series/501688/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501688","date":"2026-04-27T17:05:16","name":"qcow2: Fix corruption on discard during write with COW","version":1,"mbox":"http://patchwork.ozlabs.org/series/501688/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229023/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229023/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=FRO0mJvj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g492q20kxz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 03:06:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHPPF-0007qG-V8; Mon, 27 Apr 2026 13:06:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kwolf@redhat.com>) id 1wHPPA-0007j4-KK\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 13:05:58 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kwolf@redhat.com>) id 1wHPP8-0006Ud-8g\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 13:05:55 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-IC3RRJevMQyC33fVLEPCjw-1; Mon,\n 27 Apr 2026 13:05:50 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5C1C919560B4; Mon, 27 Apr 2026 17:05:49 +0000 (UTC)","from merkur.fritz.box (unknown [10.44.49.22])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4FE121800446; Mon, 27 Apr 2026 17:05:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777309553;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xt1Ev/wLan3HxX+yy3/W3SrxiXPBZBxO+DaqEQ//04c=;\n b=FRO0mJvj0nXivpU+I9K5yx16vr/Wk6M7gYG79LbBwzK/vNTJmu/+ch7UM4N+lvKHw79nvD\n mUFp5UR2wlmQvggDsnwF3os5cFXCKUm8T2XPnSVK9swGAY9NLtv3gNX61kdHr2Ekg1DSaI\n BBPBO6wx6oXu9MSSL0GiX0/UsJ+lDrY=","X-MC-Unique":"IC3RRJevMQyC33fVLEPCjw-1","X-Mimecast-MFC-AGG-ID":"IC3RRJevMQyC33fVLEPCjw_1777309549","From":"Kevin Wolf <kwolf@redhat.com>","To":"qemu-block@nongnu.org","Cc":"kwolf@redhat.com, hreitz@redhat.com, den@openvz.org, stefanha@redhat.com,\n qemu-stable@nongnu.org, qemu-devel@nongnu.org","Subject":"[PATCH 4/4] iotests/046: Test that discard/write_zeroes wait for\n dependencies","Date":"Mon, 27 Apr 2026 19:05:20 +0200","Message-ID":"<20260427170520.101242-5-kwolf@redhat.com>","In-Reply-To":"<20260427170520.101242-1-kwolf@redhat.com>","References":"<20260427170520.101242-1-kwolf@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This is a regression test for the bug fixed in the previous commit where\ndiscard and write_zeroes operations wouldn't consider their dependencies\nin s->cluster_allocs. Without the fix, this results in a corrupted\nimage.\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\n---\n tests/qemu-iotests/046     | 46 ++++++++++++++++++++++++++++++++++++++\n tests/qemu-iotests/046.out | 36 +++++++++++++++++++++++++++++\n 2 files changed, 82 insertions(+)","diff":"diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046\nindex 4c9ed4d26e1..e03dd401479 100755\n--- a/tests/qemu-iotests/046\n+++ b/tests/qemu-iotests/046\n@@ -184,6 +184,48 @@ aio_write -P 160 0x104000 0x18000\n resume A\n aio_flush\n EOF\n+\n+# Create a pre-allocated zero cluster, then start a write on it and discard it\n+# before the L2 update is made\n+cat  <<EOF\n+write -P 181 0x120000 0x10000\n+write -z 0x120000 0x10000\n+\n+break write_aio A\n+aio_write -P 180 0x120000 0x10000\n+wait_break A\n+aio_discard 0x120000 0x10000\n+resume A\n+aio_flush\n+EOF\n+\n+# Create a pre-allocated zero cluster, then start a write on it and a\n+# concurrent zero write with MAY_UNMAP before the L2 update is made\n+cat  <<EOF\n+write -P 181 0x130000 0x10000\n+write -z 0x130000 0x10000\n+\n+break write_aio A\n+aio_write -P 180 0x130000 0x10000\n+wait_break A\n+aio_write -z -u 0x130000 0x10000\n+resume A\n+aio_flush\n+EOF\n+\n+# Create a pre-allocated zero cluster, then start a write on it and a\n+# concurrent zero write without MAY_UNMAP before the L2 update is made\n+cat  <<EOF\n+write -P 181 0x140000 0x10000\n+write -z 0x140000 0x10000\n+\n+break write_aio A\n+aio_write -P 180 0x140000 0x10000\n+wait_break A\n+aio_write -z 0x140000 0x10000\n+resume A\n+aio_flush\n+EOF\n }\n \n overlay_io | $QEMU_IO blkdebug::\"$TEST_IMG\" | _filter_qemu_io |\\\n@@ -264,6 +306,10 @@ verify_io()\n     # Undefined content for 0x10c000 0x8000\n     echo read -P 160 0x114000 0x8000\n     echo read -P 17  0x11c000 0x4000\n+\n+    echo read -P 0   0x120000 0x10000\n+    echo read -P 0   0x130000 0x10000\n+    echo read -P 0   0x140000 0x10000\n }\n \n verify_io | $QEMU_IO \"$TEST_IMG\" | _filter_qemu_io\ndiff --git a/tests/qemu-iotests/046.out b/tests/qemu-iotests/046.out\nindex b1a03f40414..6341df335c9 100644\n--- a/tests/qemu-iotests/046.out\n+++ b/tests/qemu-iotests/046.out\n@@ -139,6 +139,36 @@ wrote XXX/XXX bytes at offset XXX\n XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n wrote XXX/XXX bytes at offset XXX\n XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+blkdebug: Suspended request 'A'\n+blkdebug: Resuming request 'A'\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+discarded  XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+blkdebug: Suspended request 'A'\n+blkdebug: Resuming request 'A'\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+blkdebug: Suspended request 'A'\n+blkdebug: Resuming request 'A'\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+wrote XXX/XXX bytes at offset XXX\n+XXX KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n \n == Verify image content ==\n read 65536/65536 bytes at offset 0\n@@ -239,5 +269,11 @@ read 32768/32768 bytes at offset 1130496\n 32 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n read 16384/16384 bytes at offset 1163264\n 16 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+read 65536/65536 bytes at offset 1179648\n+64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+read 65536/65536 bytes at offset 1245184\n+64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n+read 65536/65536 bytes at offset 1310720\n+64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)\n No errors were found on the image.\n *** done\n","prefixes":["4/4"]}