{"id":2229015,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229015/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-19-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427154639.180684-19-dhowells@redhat.com>","date":"2026-04-27T15:46:33","name":"[v4,18/22] netfs: Fix partial invalidation of streaming-write folio","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b2c731b098421a7354e5be87d72645812833ce8e","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-19-dhowells@redhat.com/mbox/","series":[{"id":501682,"url":"http://patchwork.ozlabs.org/api/1.1/series/501682/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501682","date":"2026-04-27T15:46:15","name":"netfs: Miscellaneous fixes","version":4,"mbox":"http://patchwork.ozlabs.org/series/501682/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229015/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229015/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=I/M8qV7a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11174-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"I/M8qV7a\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47qr5bXLz1yHv\n\tfor ; Tue, 28 Apr 2026 02:12:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D62923168309\n\tfor ; Mon, 27 Apr 2026 15:51:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 061963D9055;\n\tMon, 27 Apr 2026 15:48:17 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F5613D9DA1\n\tfor ; Mon, 27 Apr 2026 15:48:15 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-YVQkWbXNNeipfCuB7hO6uw-1; Mon,\n 27 Apr 2026 11:48:11 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 807B71800473;\n\tMon, 27 Apr 2026 15:48:09 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8E57A19560AB;\n\tMon, 27 Apr 2026 15:48:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777304896; cv=none;\n b=suN6Ax2ug3oLduvixKDceHnmtP91JR8fKTsfZoS0J5ZrWA7dW7NlsqR/H7hPQ836e0ZaSxMe37yP8WoB0xEK4nELV+Om/Jsp7oQYT0kuxrk/DCZwFECwcfPjm/PoRrNpM9d4iG9okm+CzZu2ABTXKXVr6Rwb9JHPD5EkS9UTGRU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777304896; c=relaxed/simple;\n\tbh=NWuEILu4xE6q9Mk9vp9plJM/HCqF87+ioNPLfDaVBUs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Qjh5cH7ASvg3WJZL9KZv1r0a/H36j9+yMe5nCctJKZPePCZNXhdd30qzALhu34IyrmdJHNu9zlCHAt1DUvMEtcJb/6kNneoi5wtkIjXV3s67hRRLaSl5pn4e+WqvL7q3GDdQByLD0HuPJwnhQQH9XK+Y02dracaogjT0ILoVPvM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=I/M8qV7a; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777304894;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Vdxi9UOZOtHgo5imTm/mIQ6/cjgNJUqbuly6giNT79Q=;\n\tb=I/M8qV7aZE4W7Zkjm4w4gVrD126K5dxs/O3JljJXNjYt+HBAhKC4vgazY5agT/Tes1zj1G\n\tqNapZw3h+CLefBg45sqK7Kya3kmWQj7oQt5gTH194QWDPz+KmaCMEEQAyHjhagNwXGGK/h\n\tY/zPDhUiuatnAoz/6SIoEZH7Cm8Ieg0=","X-MC-Unique":"YVQkWbXNNeipfCuB7hO6uw-1","X-Mimecast-MFC-AGG-ID":"YVQkWbXNNeipfCuB7hO6uw_1777304889","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH v4 18/22] netfs: Fix partial invalidation of streaming-write\n folio","Date":"Mon, 27 Apr 2026 16:46:33 +0100","Message-ID":"<20260427154639.180684-19-dhowells@redhat.com>","In-Reply-To":"<20260427154639.180684-1-dhowells@redhat.com>","References":"<20260427154639.180684-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"In netfs_invalidate_folio(), if the region of a partial invalidation\noverlaps the front (but not all) of a dirty write cached in a streaming\nwrite page (dirty, but not uptodate, with the dirty region tracked by a\nnetfs_folio struct), the function modifies the dirty region - but\nincorrectly as it moves the region forward by setting the start to the\nstart, not the end, of the invalidation region.\n\nFix this by setting finfo->dirty_offset to the end of the invalidation\nregion (iend).\n\nFixes: cce6bfa6ca0e (\"netfs: Fix trimming of streaming-write folios in netfs_inval_folio()\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/misc.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/netfs/misc.c b/fs/netfs/misc.c\nindex 4e91a8d75bce..094d5e8aad1a 100644\n--- a/fs/netfs/misc.c\n+++ b/fs/netfs/misc.c\n@@ -255,7 +255,7 @@ void netfs_invalidate_folio(struct folio *folio, size_t offset, size_t length)\n \t\t\t\tgoto erase_completely;\n \t\t\t/* Move the start of the data. */\n \t\t\tfinfo->dirty_len = fend - iend;\n-\t\t\tfinfo->dirty_offset = offset;\n+\t\t\tfinfo->dirty_offset = iend;\n \t\t\ttrace_netfs_folio(folio, netfs_folio_trace_invalidate_front);\n \t\t\treturn;\n \t\t}\n","prefixes":["v4","18/22"]}