{"id":2229011,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229011/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-16-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427154639.180684-16-dhowells@redhat.com>","date":"2026-04-27T15:46:30","name":"[v4,15/22] netfs: Fix leak of request in netfs_write_begin() error handling","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"37583c13953b134c69d327c18f6310f5f21a234e","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-16-dhowells@redhat.com/mbox/","series":[{"id":501682,"url":"http://patchwork.ozlabs.org/api/1.1/series/501682/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501682","date":"2026-04-27T15:46:15","name":"netfs: Miscellaneous fixes","version":4,"mbox":"http://patchwork.ozlabs.org/series/501682/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229011/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229011/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PYJ9Td2i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11171-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"PYJ9Td2i\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47gc5Pngz1yHX\n\tfor ; Tue, 28 Apr 2026 02:05:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9D6373074258\n\tfor ; Mon, 27 Apr 2026 15:50:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 934F6346AC4;\n\tMon, 27 Apr 2026 15:48:02 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DAFA3D75A8\n\tfor ; Mon, 27 Apr 2026 15:48:01 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-ca3hdlebOF6rWEa76BVDRA-1; Mon,\n 27 Apr 2026 11:47:56 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4EFF119560B0;\n\tMon, 27 Apr 2026 15:47:55 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 53946300070A;\n\tMon, 27 Apr 2026 15:47:52 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777304882; cv=none;\n b=evZBfc0Wj8bgJP9KLf22rqM1K+i0AeZ95JjbPWu/xJlUiBPD4V7iT9nn6A6Fy0nE4s2CCwJSUVbw41bStXjdbxtfeftfrRTTIo7Uhlm3CFc8fqDWvzeV0x/W9MNelLWmTkeQt4HUEezFhCDZX1wyoIPLNcNRrCMvjuofRAtuGGA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777304882; c=relaxed/simple;\n\tbh=5QREYDZ853cnryQHJ1yTlusLm/biu/XfvMWK4YdBhBs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=mGlvIWMaW0LU2WJyH82UWXQErZR0b5Da7niR3NSNiYvtRjixgLqbdiC8RFhA2eJZys7oGBD1B21g293bZ0eWPVp/PA2FB6cIf0dCpRTMC6+jXYWlf9XEKvG9YHnRZwPcA8FrrnK0HwAHpgNhWSuCb9EnCfviy3dlKuvAGS3RTd4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=PYJ9Td2i; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777304880;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=HZzlSw2rTGIAd1QOD9s2kRLtq32SYiSJ31hk3o8bXSQ=;\n\tb=PYJ9Td2ivzQhzUDtu8s3JDRTr02B91FGlSUpK35FMCfiRuy5kIWoY8D3w1LAOd2aN2mBSW\n\tbgQt5zS11GF2KtkGmXkowyczgyt5uTuVxA5HZ+c8u1HPfjk72ZQtKlxCWJ0Bg9T5FlWQtw\n\toDHjMXM7R6OZ5OWel3hGvUYt1+ep094=","X-MC-Unique":"ca3hdlebOF6rWEa76BVDRA-1","X-Mimecast-MFC-AGG-ID":"ca3hdlebOF6rWEa76BVDRA_1777304875","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH v4 15/22] netfs: Fix leak of request in netfs_write_begin()\n error handling","Date":"Mon, 27 Apr 2026 16:46:30 +0100","Message-ID":"<20260427154639.180684-16-dhowells@redhat.com>","In-Reply-To":"<20260427154639.180684-1-dhowells@redhat.com>","References":"<20260427154639.180684-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4"},"content":"Fix netfs_write_begin() to not leak our ref on the request in the event\nthat we get an error from netfs_wait_for_read().\n\nFixes: 4090b31422a6 (\"netfs: Add a function to consolidate beginning a read\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex a406b5ac120a..71ab81b3f609 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -692,9 +692,9 @@ int netfs_write_begin(struct netfs_inode *ctx,\n \n \tnetfs_read_to_pagecache(rreq, NULL);\n \tret = netfs_wait_for_read(rreq);\n+\tnetfs_put_request(rreq, netfs_rreq_trace_put_return);\n \tif (ret < 0)\n \t\tgoto error;\n-\tnetfs_put_request(rreq, netfs_rreq_trace_put_return);\n \n have_folio:\n \tret = folio_wait_private_2_killable(folio);\n","prefixes":["v4","15/22"]}