{"id":2229000,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2229000/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-5-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427154639.180684-5-dhowells@redhat.com>","date":"2026-04-27T15:46:19","name":"[v4,04/22] netfs: Fix netfs_read_to_pagecache() to pause on subreq failure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6f207c538bc253712f495f6bba6cab419b40f8ad","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-5-dhowells@redhat.com/mbox/","series":[{"id":501682,"url":"http://patchwork.ozlabs.org/api/1.1/series/501682/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501682","date":"2026-04-27T15:46:15","name":"netfs: Miscellaneous fixes","version":4,"mbox":"http://patchwork.ozlabs.org/series/501682/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2229000/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2229000/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EZppV8DS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11160-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"EZppV8DS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47Xk1QWQz1yHv\n\tfor ; Tue, 28 Apr 2026 01:59:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 87BA73155E1D\n\tfor ; Mon, 27 Apr 2026 15:47:48 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0F31234FF78;\n\tMon, 27 Apr 2026 15:47:10 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CE034F27F\n\tfor ; Mon, 27 Apr 2026 15:47:08 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-M65CsH5jPWKe8idtZ72r4Q-1; Mon,\n 27 Apr 2026 11:47:04 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B0DDD18003FC;\n\tMon, 27 Apr 2026 15:47:02 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EF4EC1800348;\n\tMon, 27 Apr 2026 15:46:59 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777304829; cv=none;\n b=riwO4PtKgSUbl+EXBIVfn/e1hXPnJN7xHCW4LneP9ypvpWgzvMNh+NRymG3sXKUejYM5n72fynCI/gr1ykw5C6Dj9uEuEsY6p+Px1s4E2KIkG49pRsgBRcW+ssY71ku9ZuRQi2gYXfVT351L2CJlZUXcbNn1Z2ThNOnqoVb9NtE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777304829; c=relaxed/simple;\n\tbh=4vDqPI8DVk4MKXgzTTYnAtb5Hin/PlJJp6BgfgK/hjI=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=MmEItgRLUO58M9VYu+olPID2HqIpkmaZKXlGGZaz9NeB6lHST4AA82EszSbTupYEIAjvBBEk7fGIbxP7stdK4nTT7VxBltvKl9c/R9cX7QxCMrw4qo81Plb7VVbtiTQERot6bW0PK0sTxWLFFYFqcXcDMiqnRjlw4RS7seUvGg8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=EZppV8DS; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777304827;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=F1+6dfsU9EA3zra9BmDxqCEbg56ER/RAJitXxHpONYg=;\n\tb=EZppV8DSvnkGt7XiNFilNUH0Jx1LTC2dJeF8TtyeZy75hGTU6MZnLbWwCbqToMFl/3k+fG\n\tHDWXp4KZxTLfrV/Gr2OnJGxXZtBH3qs+yvSIao6F5grH7b2PI8LQG3ysJv2nnHVmb1jhK8\n\t8HsBM2EKMe9DIy0FTBzSfbTPDbmxZpo=","X-MC-Unique":"M65CsH5jPWKe8idtZ72r4Q-1","X-Mimecast-MFC-AGG-ID":"M65CsH5jPWKe8idtZ72r4Q_1777304822","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v4 04/22] netfs: Fix netfs_read_to_pagecache() to pause on\n subreq failure","Date":"Mon, 27 Apr 2026 16:46:19 +0100","Message-ID":"<20260427154639.180684-5-dhowells@redhat.com>","In-Reply-To":"<20260427154639.180684-1-dhowells@redhat.com>","References":"<20260427154639.180684-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93"},"content":"Fix netfs_read_to_pagecache() so that it pauses the generation of new\nsubrequests if an already-issued subrequest fails.\n\nFixes: ee4cdf7ba857 (\"netfs: Speed up buffered reading\")\nCloses: https://sashiko.dev/#/patchset/20260425125426.3855807-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex 3bc7d0c5c3b9..9c7a2f984be9 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -304,6 +304,11 @@ static void netfs_read_to_pagecache(struct netfs_io_request *rreq,\n \t\t}\n \n \t\tnetfs_issue_read(rreq, subreq);\n+\n+\t\tif (test_bit(NETFS_RREQ_PAUSE, &rreq->flags))\n+\t\t\tnetfs_wait_for_paused_read(rreq);\n+\t\tif (test_bit(NETFS_RREQ_FAILED, &rreq->flags))\n+\t\t\tbreak;\n \t\tcond_resched();\n \t} while (size > 0);\n \n","prefixes":["v4","04/22"]}