{"id":2228997,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228997/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-18-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427154639.180684-18-dhowells@redhat.com>","date":"2026-04-27T15:46:32","name":"[v4,17/22] netfs: Fix potential uninitialised var in netfs_extract_user_iter()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ca7509557e2bcfd473dbbf2627f55c7cda8137b4","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427154639.180684-18-dhowells@redhat.com/mbox/","series":[{"id":501682,"url":"http://patchwork.ozlabs.org/api/1.1/series/501682/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501682","date":"2026-04-27T15:46:15","name":"netfs: Miscellaneous fixes","version":4,"mbox":"http://patchwork.ozlabs.org/series/501682/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228997/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228997/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RIQPWyeL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11173-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"RIQPWyeL\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47WP3FVGz1yHv\n\tfor ; Tue, 28 Apr 2026 01:57:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 694473002B05\n\tfor ; Mon, 27 Apr 2026 15:51:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 517F13D8916;\n\tMon, 27 Apr 2026 15:48:12 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CB63F351C3C\n\tfor ; Mon, 27 Apr 2026 15:48:10 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-j5TdZ1OYN0mrz3ghpZriCA-1; Mon,\n 27 Apr 2026 11:48:06 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DB55919560B9;\n\tMon, 27 Apr 2026 15:48:04 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id DF56C19560AB;\n\tMon, 27 Apr 2026 15:48:01 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777304892; cv=none;\n b=rI+rLby7QOmBcuo/RG61Uxa2iHMQAOFx7HmM/3Bk6auSUNOyCja3mEv7q5BoTE35WI+kUNit6t9HMxo5Z0uOZBaSYhgrlS1aGJ3unesfQqehU+UmvNtE957bYuVP3Ci9j9DvjSDLhw3+T7i1y08GsT6UZdbD2dZJtrjNhZmwb+I=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777304892; c=relaxed/simple;\n\tbh=ZGvl6pwK8hhI6Z7/+zjDuc7j0IK6cFQmA5My4ZDgo6s=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=XCIB8J3mV5c2A/VbTTSzsf/9fBOXfP0F5Oi9Yui9EIjdI6Oigcyg5N3pDLMnm880t+1vOn0XFxcmxL2zqjp66nYgtp5xewgzSt0qlfoOmO3FG9mZK1iGKrHNucoRujX1AY3cDpKsRnWgDHjaJhcLFn8GkmyPOCDGIrBpRo035kI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=RIQPWyeL; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777304889;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=k8mwXPbUAnJI1Gm/W783qf7sgkpvXeGSln2ciNPV49w=;\n\tb=RIQPWyeLuxV1VZgEAp3ZqVolAqa2DiOhOA+uS81UrPBwn+CDiMcOfTtTEXWlyem6RZgjw/\n\turIobXrYHvJFQ/3AaRIzKcHQ+asckA2HdSgW5ihgxUl6nNcHLfwzDhpQZOQ2XXqfoF6lYx\n\tjx4rRsPLmEEGaIVrGwfwget5knul98M=","X-MC-Unique":"j5TdZ1OYN0mrz3ghpZriCA-1","X-Mimecast-MFC-AGG-ID":"j5TdZ1OYN0mrz3ghpZriCA_1777304885","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH v4 17/22] netfs: Fix potential uninitialised var in\n netfs_extract_user_iter()","Date":"Mon, 27 Apr 2026 16:46:32 +0100","Message-ID":"<20260427154639.180684-18-dhowells@redhat.com>","In-Reply-To":"<20260427154639.180684-1-dhowells@redhat.com>","References":"<20260427154639.180684-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"In netfs_extract_user_iter(), if it's given a zero-length iterator, it will\nfall through the loop without setting ret, and so the error handling\nbehaviour will be undefined, depending on whether ret happens to be\nnegative. The value of ret then propagates back up the callstack.\n\nFix this by presetting ret to 0.\n\nFixes: 85dd2c8ff368 (\"netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/iterator.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/netfs/iterator.c b/fs/netfs/iterator.c\nindex adca78747f23..429e4396e1b0 100644\n--- a/fs/netfs/iterator.c\n+++ b/fs/netfs/iterator.c\n@@ -43,7 +43,7 @@ ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,\n \tunsigned int max_pages;\n \tunsigned int npages = 0;\n \tunsigned int i;\n-\tssize_t ret;\n+\tssize_t ret = 0;\n \tsize_t count = orig_len, offset, len;\n \tsize_t bv_size, pg_size;\n \n","prefixes":["v4","17/22"]}