{"id":2228977,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228977/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427152953.180038-4-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427152953.180038-4-dhowells@redhat.com>","date":"2026-04-27T15:29:30","name":"[v4,03/22] netfs: Fix missing locking around retry adding new subreqs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"816b8cc28df3f31636f25023a7703e3f424fce10","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427152953.180038-4-dhowells@redhat.com/mbox/","series":[{"id":501677,"url":"http://patchwork.ozlabs.org/api/1.1/series/501677/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501677","date":"2026-04-27T15:29:27","name":"netfs: Miscellaneous fixes","version":4,"mbox":"http://patchwork.ozlabs.org/series/501677/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228977/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228977/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AaTzxlzD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11146-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"AaTzxlzD\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g478S1DR6z1yHv\n\tfor ; Tue, 28 Apr 2026 01:41:28 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A91FD30C7FF8\n\tfor ; Mon, 27 Apr 2026 15:34:39 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7D17A3DF00B;\n\tMon, 27 Apr 2026 15:30:25 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A1C433DEACD\n\tfor ; Mon, 27 Apr 2026 15:30:23 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-o_86Fju7MJyIRarjiHxZSQ-1; Mon,\n 27 Apr 2026 11:30:19 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AC26719560A2;\n\tMon, 27 Apr 2026 15:30:15 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id BF3EC19560AB;\n\tMon, 27 Apr 2026 15:30:12 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777303825; cv=none;\n b=nnUNh4jcShtmHosww0rIrKRZ9lEIY/xBo7jd4fd1S89hNJ4J+XnILdk/vbdGEcTBy2VHsWx0sO06ZNspTRfMcwrD48QYJhjmHaekJB6t8zIp3VB0DmXYl1HfyCkSD45GMXH8R5FMBZG6E1shB+QMMsom77YKkfBQJW33hJyRoPE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777303825; c=relaxed/simple;\n\tbh=TzKE7QcFZf39E2UkvuI1rxQbsvby4wW7m4gGjN+BIzs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=lSIbQHOO0QJpAXymv3KSht4FLEEYM4clbYIM82ZvqXjjaeoNsqlFp97OkLTzIlJPtPE0j6izGHpqsthcADrrADniapHozqkAqzOqUSwaxkwwO9VuppsdBBiPuFI9oA1XS+zMpgYILJCtcSDf9LqyrAcGGaQsF7VWClPJOMLvAlo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=AaTzxlzD; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777303822;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=REMGICrXXI7qiSN2rIwTeEeIpWS2D3QtA/yikvDYdpo=;\n\tb=AaTzxlzDPkvHT95gMbQFUIuiGGL5qFd40dC1EWJyK4823Ram/azUysmSFbGfTkwIHINfC3\n\tHQ1UWpZma4QOlXgJbA+WUvFVglMtKqxCCerOTacVJpncJ+qsXhysQtEhYDnvibDGNPfj8v\n\tK7AC2vFeCPK8eHRsR25rEto6vqa9esE=","X-MC-Unique":"o_86Fju7MJyIRarjiHxZSQ-1","X-Mimecast-MFC-AGG-ID":"o_86Fju7MJyIRarjiHxZSQ_1777303816","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v4 03/22] netfs: Fix missing locking around retry adding new\n subreqs","Date":"Mon, 27 Apr 2026 16:29:30 +0100","Message-ID":"<20260427152953.180038-4-dhowells@redhat.com>","In-Reply-To":"<20260427152953.180038-1-dhowells@redhat.com>","References":"<20260427152953.180038-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"Fix netfs_retry_read_subrequests() and netfs_retry_write_stream() to take\nthe appropriate lock when adding extra subrequests into\nstream->subrequests.\n\nFixes: e2d46f2ec332 (\"netfs: Change the read result collector to only use one work item\")\nFixes: 288ace2f57c9 (\"netfs: New writeback implementation\")\nCloses: https://sashiko.dev/#/patchset/20260425125426.3855807-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/read_retry.c | 2 ++\n fs/netfs/write_retry.c | 2 ++\n 2 files changed, 4 insertions(+)","diff":"diff --git a/fs/netfs/read_retry.c b/fs/netfs/read_retry.c\nindex cca9ac43c077..b34561e257f0 100644\n--- a/fs/netfs/read_retry.c\n+++ b/fs/netfs/read_retry.c\n@@ -203,7 +203,9 @@ static void netfs_retry_read_subrequests(struct netfs_io_request *rreq)\n \t\t\t\t\t refcount_read(&subreq->ref),\n \t\t\t\t\t netfs_sreq_trace_new);\n \n+\t\t\tspin_lock(&rreq->lock);\n \t\t\tlist_add(&subreq->rreq_link, &to->rreq_link);\n+\t\t\tspin_unlock(&rreq->lock);\n \t\t\tto = list_next_entry(to, rreq_link);\n \t\t\ttrace_netfs_sreq(subreq, netfs_sreq_trace_retry);\n \ndiff --git a/fs/netfs/write_retry.c b/fs/netfs/write_retry.c\nindex 29489a23a220..db0f23708b2d 100644\n--- a/fs/netfs/write_retry.c\n+++ b/fs/netfs/write_retry.c\n@@ -153,7 +153,9 @@ static void netfs_retry_write_stream(struct netfs_io_request *wreq,\n \t\t\t\t\t netfs_sreq_trace_new);\n \t\t\ttrace_netfs_sreq(subreq, netfs_sreq_trace_split);\n \n+\t\t\tspin_lock(&wreq->lock);\n \t\t\tlist_add(&subreq->rreq_link, &to->rreq_link);\n+\t\t\tspin_unlock(&wreq->lock);\n \t\t\tto = list_next_entry(to, rreq_link);\n \t\t\ttrace_netfs_sreq(subreq, netfs_sreq_trace_retry);\n \n","prefixes":["v4","03/22"]}