{"id":2228970,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228970/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260427152003.26778-1-marex@nabladev.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.1/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427152003.26778-1-marex@nabladev.com>","date":"2026-04-27T15:19:29","name":"[v3] nvmem: core: Default to read-only if wp-gpios present","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"91cb88186069377a043c30a9448daf925b0926e8","submitter":{"id":91452,"url":"http://patchwork.ozlabs.org/api/1.1/people/91452/?format=json","name":"Marek Vasut","email":"marex@nabladev.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260427152003.26778-1-marex@nabladev.com/mbox/","series":[{"id":501674,"url":"http://patchwork.ozlabs.org/api/1.1/series/501674/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=501674","date":"2026-04-27T15:19:29","name":"[v3] nvmem: core: Default to read-only if wp-gpios present","version":3,"mbox":"http://patchwork.ozlabs.org/series/501674/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228970/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228970/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nabladev.com header.i=@nabladev.com header.a=rsa-sha256\n header.s=dkim header.b=DbQBOJc8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17183-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com\n header.b=\"DbQBOJc8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=178.251.229.89","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nabladev.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=nabladev.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g46j55sxYz1xvV\n\tfor ; Tue, 28 Apr 2026 01:21:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 7DF5F301CD8A\n\tfor ; Mon, 27 Apr 2026 15:20:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id ED63332E13B;\n\tMon, 27 Apr 2026 15:20:14 +0000 (UTC)","from mx.nabladev.com (mx.nabladev.com [178.251.229.89])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9821C3314AC;\n\tMon, 27 Apr 2026 15:20:12 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 066D4113A0E;\n\tMon, 27 Apr 2026 17:20:03 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777303214; cv=none;\n b=XsefzF3lnE/zBjvINj/I7IJwSYgiajAJ/narJaB0gq4hlzHIHMft4yyQzbYkxdli8561j2vd7/z34v2p9uLblut8P8FiIah7aKBGwoiiBQldunKy9C1DJXVxjjzZIKBiHUw1MjmdhT23ZAtx9quPfGN/bbK5pqlKG6FMnDBTdu0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777303214; c=relaxed/simple;\n\tbh=QGiQLLzsJNW+MpbQH6Z9J813Lx3+Yz6wTRNABz9qE3g=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=rgVbVnlv2gKkUsB0BUuf1Wl8BohIfLq6DKqUDdzKflMnHjXr8gB+nkFWnHzRSRTIs/tVti/SZIKfsKEVRMv95VfVBuDY5uyxFYH08IEcP6NzENWSfNVj1Wo3Sby4vcZF2WVK9i9DRV4jtwj3kJoa2kMH+z+5vtFSZv2+sXkb/2o=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nabladev.com;\n spf=pass smtp.mailfrom=nabladev.com;\n dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com\n header.b=DbQBOJc8; arc=none smtp.client-ip=178.251.229.89","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com;\n\ts=dkim; t=1777303204; h=from:subject:date:message-id:to:cc:mime-version:\n\t content-transfer-encoding; bh=RVZO448hk3d3psiiCRDH4PBmpZadwwV1wVqDyw9htWQ=;\n\tb=DbQBOJc8hJGWD4TDkioeKRiP7ppiq1xYAvevxrRfu/oz6BEwh35zmed2FrynxgDRfMkUWC\n\t/bBo4giahsPOPzqAYsAjSO+R+PDxIHhZElOUM9Q0bv2raqnf9m+dhzIgsIaDGijUtzfJU6\n\t3P3Y3HSsL138zWNw40mRjU0rp0JhFmgbqSHzo9AxGndAFdm6q8hbZsUEKeMciUCdaoY2UP\n\trHHLMwceXPGz86x8YFEBV/MsFyYGOHMwGpCr7Y9M2PnkwahApEBRkGvx+S0NeD+TkRi9L8\n\tYp6ALrOuN3gUR8EkTdZMg+DC/g9bEWn+yvqj9+bWmXhu5ZDjF9RI9If5xNqutg==","From":"Marek Vasut ","To":"linux-i2c@vger.kernel.org","Cc":"Marek Vasut ,\n\tArnd Bergmann ,\n\tBartosz Golaszewski ,\n\tGreg Kroah-Hartman ,\n\tSrinivas Kandagatla ,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH v3] nvmem: core: Default to read-only if wp-gpios present","Date":"Mon, 27 Apr 2026 17:19:29 +0200","Message-ID":"<20260427152003.26778-1-marex@nabladev.com>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Last-TLS-Session-Version":"TLSv1.3"},"content":"In case the nvmem DT node contains \"wp-gpios\" DT property, the device\ncurrently defaults to read-write and the force_ro sysfs attribute reads\n0. Switch to the default read-only, which is both safer, and aligned\nwith eMMC HW BOOT partition force_ro sysfs attribute behavior, which\nalso defaults to read-only.\n\nThe adjustment of nvmem->read_only value to read-only in case wp-gpios\nDT property is present must be done only after the device_add() got\ncalled because device_add() does internally call nvmem_bin_attr_get_umode(),\nwhich configures the permissions of 'nvmem' bin attr based on the value\nof nvmem->read_only that is only parsed from DT property 'read-only',\nwithout any adjustment. This way, if DT property 'read-only' is present,\nthe 'nvmem' attribute is always read-only. Otherwise, if the device is\nwriteable, then 'nvmem' attribute is writeable, and nvmem->read_only\ndefaults to read-only, but can be switched to read-write at runtime via\nthe 'force_ro' attribute.\n\nThe updated behavior can be tested as follows:\n\nCurrent content:\n\"\n$ cat /sys/bus/nvmem/devices/logging7/force_ro\n1\n\n$ hexdump -C /sys/bus/nvmem/devices/logging7/nvmem\n00000000 66 6f 6f 0a ff ff ff ff\n\"\n\nWrite into default-read-only device:\n\"\n$ echo bar > /sys/bus/nvmem/devices/logging7/nvmem\nbash: echo: write error: Operation not permitted\n$ cat /sys/bus/nvmem/devices/logging7/force_ro\n1\n\"\n\nUnlock and write into device:\n\"\n$ echo 0 > /sys/bus/nvmem/devices/logging7/force_ro\n$ cat /sys/bus/nvmem/devices/logging7/force_ro\n0\n\n$ echo bar > /sys/bus/nvmem/devices/logging7/nvmem\n$ hexdump -C /sys/bus/nvmem/devices/logging7/nvmem\n00000000 62 61 72 0a ff ff ff ff\n\"\n\nRelock and write into device, fails because device is read-only again:\n\"\n$ echo 1 > /sys/bus/nvmem/devices/logging7/force_ro\n$ echo baz > /sys/bus/nvmem/devices/logging7/nvmem\nbash: echo: write error: Operation not permitted\n\n$ hexdump -C /sys/bus/nvmem/devices/logging7/nvmem\n00000000 62 61 72 0a ff ff ff ff\n\"\n\nSigned-off-by: Marek Vasut \n---\nCc: Arnd Bergmann \nCc: Bartosz Golaszewski \nCc: Greg Kroah-Hartman \nCc: Srinivas Kandagatla \nCc: linux-i2c@vger.kernel.org\nCc: linux-kernel@vger.kernel.org\n---\nV2: Simplify the implementation, make devices with wp-gpios default\n to read-only and let users unlock those devices via force_ro\n sysfs attribute, just like eMMC HW BOOT partitions\nV3: Drop unnecessary gpiod_set_value_cansleep()\n---\n drivers/nvmem/core.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c\nindex 311cb2e5a5c02..be28a366f6031 100644\n--- a/drivers/nvmem/core.c\n+++ b/drivers/nvmem/core.c\n@@ -1019,6 +1019,10 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)\n \tif (rval)\n \t\tgoto err_remove_dev;\n \n+\t/* If the device has WP GPIO, default to read-only */\n+\tif (nvmem->wp_gpio)\n+\t\tnvmem->read_only = true;\n+\n #ifdef CONFIG_NVMEM_SYSFS\n \trval = nvmem_populate_sysfs_cells(nvmem);\n \tif (rval)\n","prefixes":["v3"]}