{"id":2228963,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228963/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260427150409.400914-4-ludwig.nussel@siemens.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260427150409.400914-4-ludwig.nussel@siemens.com>","date":"2026-04-27T15:03:41","name":"[4/4] image-fit-sig: require signatures","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"133396879f57b550d940648e9fdd4e9883cca22c","submitter":{"id":90265,"url":"http://patchwork.ozlabs.org/api/1.1/people/90265/?format=json","name":"Ludwig Nussel","email":"ludwig.nussel@siemens.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260427150409.400914-4-ludwig.nussel@siemens.com/mbox/","series":[{"id":501669,"url":"http://patchwork.ozlabs.org/api/1.1/series/501669/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501669","date":"2026-04-27T15:03:38","name":"[1/4] qemu: overlay signature nodes","version":1,"mbox":"http://patchwork.ozlabs.org/series/501669/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228963/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228963/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=siemens.com header.i=ludwig.nussel@siemens.com\n header.a=rsa-sha256 header.s=fm2 header.b=Z7r4MD58;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=siemens.com header.i=ludwig.nussel@siemens.com\n header.b=\"Z7r4MD58\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=ludwig.nussel@siemens.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g46M06vxDz1xvV\n\tfor ; Tue, 28 Apr 2026 01:05:32 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8DA3E841DF;\n\tMon, 27 Apr 2026 17:05:00 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1C3CA8419E; Mon, 27 Apr 2026 17:04:59 +0200 (CEST)","from mta-65-226.siemens.flowmailer.net\n (mta-65-226.siemens.flowmailer.net [185.136.65.226])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BBEA98410D\n for ; Mon, 27 Apr 2026 17:04:53 +0200 (CEST)","by mta-65-226.siemens.flowmailer.net with ESMTPSA id\n 202604271504537c79a7c91e00020743 for ;\n Mon, 27 Apr 2026 17:04:53 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,\n SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2;\n d=siemens.com; i=ludwig.nussel@siemens.com;\n h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To;\n bh=xKfh1LqiXZWINGwprlhclp8hRf7/leQkgw70DQiJ9rM=;\n b=Z7r4MD58maQW7HarKpZK2xYQt7Hb5lhDXEdzsBnoNOHYkvY9o8jOKGH+fwWn3MqRGsAj3c\n b1BL38k8OdmtfWBO/v8aqsHh0qTwA9jjPH11zqMm+ZMeg6TqxqxDSJN7itcR8zK0lqirsLdw\n O8d0z3WHr34GZDe8Q5Lb7DJwkhBTkUhu3mH/0O8zZmGJoHSG4KOQbKeG7BnGSo3zbLYnTv0F\n Tl459I2BGroiE7oY1sUZW1/vCok787GPpBCLGsKi4WAzP6JDPMTYMLghYaYPWFbJIb+aLd5l\n 4hfNuIXPYgSxoNn+qf8yuZwqERVeRnRthHFtLJgOLtmsY/0/NGlSiRnQ==;","From":"Ludwig Nussel ","To":"u-boot@lists.denx.de","Cc":"Ludwig Nussel ,\n Simon Glass , Tom Rini ","Subject":"[PATCH 4/4] image-fit-sig: require signatures","Date":"Mon, 27 Apr 2026 17:03:41 +0200","Message-ID":"<20260427150409.400914-4-ludwig.nussel@siemens.com>","In-Reply-To":"<20260427150409.400914-1-ludwig.nussel@siemens.com>","References":"<20260427150409.400914-1-ludwig.nussel@siemens.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Flowmailer-Platform":"Siemens","Feedback-ID":"519:519-1328817:519-21489:flowmailer","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Signature nodes in the device tree are mandatory if u-boot is compiled\nwith signature verification. Allowing signature verification to pass\nif those nodes are missing would leave the system fail open.\n\nSigned-off-by: Ludwig Nussel \n---\n\n boot/image-fit-sig.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/boot/image-fit-sig.c b/boot/image-fit-sig.c\nindex 433df20281f..b89b82ee58e 100644\n--- a/boot/image-fit-sig.c\n+++ b/boot/image-fit-sig.c\n@@ -618,7 +618,6 @@ static int fit_config_verify_required_keys(const void *fit, int conf_noffset,\n \tint noffset;\n \tint key_node;\n \tint verified = 0;\n-\tint reqd_sigs = 0;\n \tbool reqd_policy_all = true;\n \tconst char *reqd_mode;\n \n@@ -639,9 +638,8 @@ static int fit_config_verify_required_keys(const void *fit, int conf_noffset,\n \t/* Work out what we need to verify */\n \tkey_node = fdt_subnode_offset(key_blob, 0, FIT_SIG_NODENAME);\n \tif (key_node < 0) {\n-\t\tdebug(\"%s: No signature node found: %s\\n\", __func__,\n-\t\t fdt_strerror(key_node));\n-\t\treturn 0;\n+\t\tlog_err(\"No signature node found: %s\\n\", fdt_strerror(key_node));\n+\t\treturn -EPERM;\n \t}\n \n \t/* Get required-mode policy property from DTB */\n@@ -668,8 +666,6 @@ static int fit_config_verify_required_keys(const void *fit, int conf_noffset,\n \t\tif (!required || strcmp(required, \"conf\"))\n \t\t\tcontinue;\n \n-\t\treqd_sigs++;\n-\n \t\tret = fit_config_verify_key(fit, conf_noffset, key_blob,\n \t\t\t\t\t noffset);\n \t\tif (ret) {\n@@ -685,8 +681,8 @@ static int fit_config_verify_required_keys(const void *fit, int conf_noffset,\n \t\t}\n \t}\n \n-\tif (reqd_sigs && !verified) {\n-\t\tprintf(\"Failed to verify 'any' of the required signature(s)\\n\");\n+\tif (!verified) {\n+\t\tlog_err(\"Failed to verify 'any' of the required signature(s)\\n\");\n \t\treturn -EPERM;\n \t}\n \n","prefixes":["4/4"]}