{"id":2228956,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228956/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427144746.1498-1-kshk@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427144746.1498-1-kshk@linux.ibm.com>","date":"2026-04-27T14:47:46","name":"[v3] vdpa: Allow VDPA to work on big-endian machine","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c1b16ab2a2044a31cee14d05ca200b42c5e8e40b","submitter":{"id":90249,"url":"http://patchwork.ozlabs.org/api/1.1/people/90249/?format=json","name":"Konstantin Shkolnyy","email":"kshk@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427144746.1498-1-kshk@linux.ibm.com/mbox/","series":[{"id":501665,"url":"http://patchwork.ozlabs.org/api/1.1/series/501665/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501665","date":"2026-04-27T14:47:46","name":"[v3] vdpa: Allow VDPA to work on big-endian machine","version":3,"mbox":"http://patchwork.ozlabs.org/series/501665/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228956/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228956/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=mQ2aaUdr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g45zx2rPlz1yHX\n\tfor ; Tue, 28 Apr 2026 00:48:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHNFt-0000cj-8N; Mon, 27 Apr 2026 10:48:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHNFr-0000cY-E6\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 10:48:11 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHNFp-0006Ov-Om\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 10:48:11 -0400","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63REl9bD2759019; Mon, 27 Apr 2026 14:48:06 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drnb50xj9-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 14:48:06 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63REcvKp029263;\n Mon, 27 Apr 2026 14:48:04 GMT","from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8avnpa2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 14:48:04 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63REm3GH9503414\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 14:48:03 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 4DD9C58056;\n Mon, 27 Apr 2026 14:48:03 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 2834A58052;\n Mon, 27 Apr 2026 14:48:03 +0000 (GMT)","from WIN-DU0DFC9G5VV.atx-us.ibm.com (unknown [9.16.62.165])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Mon, 27 Apr 2026 14:48:03 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:message-id\n :mime-version:subject:to; s=pp1; bh=Wbm9LDXAHQQvQKBXhuN9AQj/hnNB\n mHIVoSwTMHLCPu4=; b=mQ2aaUdrw6tmMBVQ66AggxBPvYk6iSs1cJlvYxJjm3pb\n QqQ3Ldwm/0B8g6F6Wai4VXTtzqrLDOV0KGOWIotDWfTCfJaHclcUsnSaDJbV8Dy7\n IfTdhcjLnRqnLtdo6o090oCz8fdSeRqGde/VUBFbHWjNUuv23JyKMTc8Nk3RjMGt\n Z5W18BBKjtUwoeeMn/ti87I+GaZWMpdFUmQ7V+BTuHiuZEcIDKdLqUakUYQQVO5M\n FcgDkI/oxOOsH/5gU9w9f7DZ5MtNYTbF5pISl1tVi4k9Acs5AT41rQsBFUTyPAky\n uz1qSi4XzL9aOTad7QxQZDD52wqCHHKjYuinga6vQw==","From":"Konstantin Shkolnyy ","To":"mst@redhat.com, sgarzare@redhat.com, jasowang@redhat.com,\n qemu-devel@nongnu.org","Cc":"mjrosato@linux.ibm.com, Konstantin Shkolnyy ,\n\t=?utf-8?q?Eugenio_P=C3=A9rez?= ,\n Akihiko Odaki ","Subject":"[PATCH v3] vdpa: Allow VDPA to work on big-endian machine","Date":"Mon, 27 Apr 2026 09:47:46 -0500","Message-Id":"<20260427144746.1498-1-kshk@linux.ibm.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=AqDeGu9P c=1 sm=1 tr=0 ts=69ef7726 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8\n a=20KFwNOVAAAA:8 a=wOKiVAmTcRLR3a3dhvcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI3MDE1OCBTYWx0ZWRfX5gtHp7dTuSEg\n 7JhuhL31O7iLLomhBGLIqpIhH6Yl5dr4kctYMaaCdz6wDBdwKJZeDYc9/MPyKzkGtV+K6vGge3b\n QA3g1ZJPKYwuRDCp1xVQed55Eur4TRQ5JBwfQ/GlLsfJRxjo9Tf5z3K0WEuY7blMtD3tEyEXd4w\n cjtamt82W4CWtnv/M5WckPpMN29LxZ8OIWh3xNoCv0irxdHLe0z13L4UWcoudEPM57YRwzS+RcE\n SzOnsuv7/bJ3QgmylhG4IcK1U4Z8WYhioIt2YKrAZnAJr+oCKtaqGFzcNDJnBQtAp5jih27eGA7\n caPmhga3gIrerT3T8XZO4gCjLsXEgkxJv+ikR8/u+NRFVTqepX7LUKlGCtG7y/pDZuivu55iM4o\n mUgrO12Ukjgf8ZHAAICFUKGhzx6trHeany6mU+wtv9pbN0MOVz9Wl8YEs3ZYnHzImFydiSHFpCL\n jkS+9uL82m+FuxxpLWg==","X-Proofpoint-GUID":"Cixd1whsQ1v7HyBucQyjg8R-IJ2LZXlX","X-Proofpoint-ORIG-GUID":"Cixd1whsQ1v7HyBucQyjg8R-IJ2LZXlX","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1011\n lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270158","Received-SPF":"pass client-ip=148.163.156.1; envelope-from=kshk@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"After commit 0caed25cd171 vhost_vdpa_net_load_vlan() started seeing\nVIRTIO_NET_F_CTRL_VLAN flag and making 4096 calls to the kernel with\nVIRTIO_NET_CTRL_VLAN_ADD command. However, it forgot to convert the\n16-bit VLAN IDs to LE format. On BE machine, the kernel calls failed\nwhen they saw \"VLAN IDs\" greater than 4095, and QEMU then said:\n\"unable to start vhost net: 5: falling back on userspace virtio\", and\nVDPA became disabled.\n\nConvert the VLAN ID to LE before putting it into virtio queue.\n\nFixes: 8f7e9967484d (\"vdpa: Restore vlan filtering state\")\nSigned-off-by: Konstantin Shkolnyy \nAcked-by: Jason Wang \nAcked-by: Eugenio Pérez \nReviewed-by: Akihiko Odaki \n---\nThis patch was reviewed several months ago but was never applied. Resending...\nChanges in v3:\n - Add Reviewed-by: Akihiko Odaki.\n---\n net/vhost-vdpa.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c\nindex 3df6091274..f1523697e2 100644\n--- a/net/vhost-vdpa.c\n+++ b/net/vhost-vdpa.c\n@@ -1200,9 +1200,10 @@ static int vhost_vdpa_net_load_single_vlan(VhostVDPAState *s,\n struct iovec *in_cursor,\n uint16_t vid)\n {\n+ uint16_t vid_le = cpu_to_le16(vid);\n const struct iovec data = {\n- .iov_base = &vid,\n- .iov_len = sizeof(vid),\n+ .iov_base = &vid_le,\n+ .iov_len = sizeof(vid_le),\n };\n ssize_t r = vhost_vdpa_net_load_cmd(s, out_cursor, in_cursor,\n VIRTIO_NET_CTRL_VLAN,\n","prefixes":["v3"]}