{"id":2228955,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228955/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260427144338.3436940-1-arnd@kernel.org/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427144338.3436940-1-arnd@kernel.org>","date":"2026-04-27T14:43:05","name":"x86/olpc: select GPIOLIB_LEGACY","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"363e3e3d969b606819c64400f8ce705b441334b2","submitter":{"id":80402,"url":"http://patchwork.ozlabs.org/api/1.1/people/80402/?format=json","name":"Arnd Bergmann","email":"arnd@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260427144338.3436940-1-arnd@kernel.org/mbox/","series":[{"id":501664,"url":"http://patchwork.ozlabs.org/api/1.1/series/501664/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=501664","date":"2026-04-27T14:43:05","name":"x86/olpc: select GPIOLIB_LEGACY","version":1,"mbox":"http://patchwork.ozlabs.org/series/501664/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228955/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228955/checks/","tags":{},"headers":{"Return-Path":"\n <linux-gpio+bounces-35597-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DcGCs3CX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35597-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"DcGCs3CX\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g45t96D9Yz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 00:44:01 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 9945E300B464\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 14:43:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3870C3A0B39;\n\tMon, 27 Apr 2026 14:43:45 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD6737B033;\n\tMon, 27 Apr 2026 14:43:44 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id BB7C9C2BCB7;\n\tMon, 27 Apr 2026 14:43:41 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777301024; cv=none;\n b=lXtJiG7unlc0D/b8c785tST8/S6CHgrKbYUAHc7+Kq7pLPiBo5AWn/Qw4w/Rokc2vCA/FovQNGdPODkDBRzhfKvUNX95VktJdGgCljoCqK2exT/D0Aypvbn6+lOwRGXUgQ/H40L5t5xMvS+hDEiurzR567G9v+w1gqAdMtKZ/Gc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777301024; c=relaxed/simple;\n\tbh=BDpvtcWKS1jt59tEm7D9HL+3Jofqortm0TkjwNkILqo=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=FyMb+yzjSVPMEyrPPP2dEw2hAfu+W4JwGh71g+3n9B750Z0wxp+fs8ip31S0JWASW2neOEBvlJwsdBQybH5/sd42AztDz1yRq7bkPURQY0iZBJ1gpFoAshd3hbx2W9Up3XKvO501bQpNPt3ycm7nEO726R3jc9Z27rhcFwuh+Iw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=DcGCs3CX; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777301024;\n\tbh=BDpvtcWKS1jt59tEm7D9HL+3Jofqortm0TkjwNkILqo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DcGCs3CXM7Tws5OEmsIaAtTxjy5iORbz8iCtZ/i8ov4lUyqPVTmx5drIZbcrxPhlY\n\t FvZx6i21Berg27fR5cHrek2qcXtN/vTKJ/8jX98c5H9ORFad+0PeBZyG3qq3D3/AXr\n\t SwNix4uaeYum5G0yREY0B74kUqnqzguh7lDTxBFOGf5NuVkOTS01pC5If4MyrjtY0L\n\t jCxcZ1rdoi85mqqpK4d2malr0E+g1vgOIVTRV9YIfzvqQpRbPraU2XGVMlcJZ29Smv\n\t ehr3W5Vr1W2CHz0Mgh/2s/miD6EjgFery9qn0S2mA1eJsGxkDf0Yf3UQelgqvhTqAg\n\t wsN9oik70+LGw==","From":"Arnd Bergmann <arnd@kernel.org>","To":"Thomas Gleixner <tglx@kernel.org>,\n\tIngo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>,\n\tDave Hansen <dave.hansen@linux.intel.com>,\n\tx86@kernel.org,\n\tJaroslav Kysela <perex@perex.cz>,\n\tTakashi Iwai <tiwai@suse.com>,\n\tLinus Walleij <linusw@kernel.org>,\n\tBartosz Golaszewski <brgl@kernel.org>","Cc":"Arnd Bergmann <arnd@arndb.de>,\n\t\"H. Peter Anvin\" <hpa@zytor.com>,\n\tPeter Zijlstra <peterz@infradead.org>,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-sound@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org","Subject":"[PATCH] x86/olpc: select GPIOLIB_LEGACY","Date":"Mon, 27 Apr 2026 16:43:05 +0200","Message-Id":"<20260427144338.3436940-1-arnd@kernel.org>","X-Mailer":"git-send-email 2.39.5","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Arnd Bergmann <arnd@arndb.de>\n\nThe OLPC GPIO controller sets up a fixed number space that is used\nby at least two drivers:\n\narch/x86/platform/olpc/olpc-xo1-sci.c: In function 'setup_ec_sci':\narch/x86/platform/olpc/olpc-xo1-sci.c:358:13: error: implicit declaration of function 'gpio_request' [-Wimplicit-function-declaration]\n  358 |         r = gpio_request(OLPC_GPIO_ECSCI, \"OLPC-ECSCI\");\n      |             ^~~~~~~~~~~~\nsound/pci/cs5535audio/cs5535audio_olpc.c: In function 'olpc_analog_input':\nsound/pci/cs5535audio/cs5535audio_olpc.c:41:9: error: implicit declaration of function 'gpio_set_value'; did you mean 'gpiod_set_value'? [-Wimplicit-function-declaration]\n   41 |         gpio_set_value(OLPC_GPIO_MIC_AC, on);\n\nSelect CONFIG_GPIOLIB_LEGACY for this platform and make sure the\nsound driver portion cannot be compiled without this.\n\nAcked-by: Borislav Petkov (AMD) <bp@alien8.de>\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n arch/x86/Kconfig  | 1 +\n sound/pci/Kconfig | 1 +\n 2 files changed, 2 insertions(+)","diff":"diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig\nindex f3f7cb01d69d..5ada2c108f4a 100644\n--- a/arch/x86/Kconfig\n+++ b/arch/x86/Kconfig\n@@ -3022,6 +3022,7 @@ config OLPC\n \tbool \"One Laptop Per Child support\"\n \tdepends on !X86_PAE\n \tselect GPIOLIB\n+\tselect GPIOLIB_LEGACY\n \tselect OF\n \tselect OF_PROMTREE\n \tselect IRQ_DOMAIN\ndiff --git a/sound/pci/Kconfig b/sound/pci/Kconfig\nindex e0996a9d90b0..6366f72b3667 100644\n--- a/sound/pci/Kconfig\n+++ b/sound/pci/Kconfig\n@@ -300,6 +300,7 @@ config SND_CS5535AUDIO\n \ttristate \"CS5535/CS5536 Audio\"\n \tdepends on X86_32 || MIPS || COMPILE_TEST\n \tdepends on HAS_IOPORT\n+\tdepends on GPIOLIB_LEGACY || !OLPC\n \tselect SND_PCM\n \tselect SND_AC97_CODEC\n \thelp\n","prefixes":[]}