{"id":2228892,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228892/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-59-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427124738.966578-59-peter.maydell@linaro.org>","date":"2026-04-27T12:47:32","name":"[PULL,58/63] target/arm: make whpx use syndrome helpers for decode","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"e732c0ac43d899c52ebb375ef7859a3b658173ca","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-59-peter.maydell@linaro.org/mbox/","series":[{"id":501642,"url":"http://patchwork.ozlabs.org/api/1.1/series/501642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501642","date":"2026-04-27T12:46:34","name":"[PULL,01/63] docs/system: add FEAT_AA32 and FEAT_AA64 to emulation list","version":1,"mbox":"http://patchwork.ozlabs.org/series/501642/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228892/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228892/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NhbZ2r8Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g43bw75WKz1yHX\n\tfor ; Mon, 27 Apr 2026 23:01:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHLUj-0000zU-Bh; Mon, 27 Apr 2026 08:55:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHLO9-0008Ez-1m\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:37 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHLO6-0005mo-BQ\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:36 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so127026025e9.2\n for ; Mon, 27 Apr 2026 05:48:33 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.31\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 05:48:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777294113; x=1777898913; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=SNjguSagUUFWrnR8Tu095/iRj+cQaq/6CTCp6Ze1XcY=;\n b=NhbZ2r8ZvC42TEMQz4nvYR+HFoEnFV6KDjQ8MXq+BObgG0WH3IesN6D3T2E9VClVQV\n oqFGOowH3IGoQVemddW1OZCDthqyQR2TN1qRhsXZPwxiplYA+ekL1MMld2t+mjJkTe1i\n wL7arYMlC6kKewL/iqz1t5PmbhTZ2ogtvIy+urWWpYVHwWaJfpCs6Ftp1TOdN9yTDOF1\n 3TRr8tkob9JC6qy3COm019IDIxz11jj6bZVsCrKvYklxPpa07jmx/J75mppA9iu92FbN\n PT5YA5j+/H5esZWtYYOjvC28KDKSmMCRfCmK0WeIpq07Fs0t/Bj5RRZvvUTS67e3K5Oo\n MXEg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777294113; x=1777898913;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=SNjguSagUUFWrnR8Tu095/iRj+cQaq/6CTCp6Ze1XcY=;\n b=dbQjkcgKGT9I24Mv3y2q1QpTeJGlN/hdDzHw0+XliY2WaVHVNYpkAidnV3CpvqGDvo\n rBX8oNu1Vz7LRVCnQCkNhb8+XMe7sCg1/YCPKPqVMOvQydjByZz3lyOqTYHV9eADh9LW\n nF7zLGwyfRG86KXAIE9cneN2LcwUzCNj1V/kJD13K66VeAHUAb4Fra4bM/7a/8UXOfOK\n 49jykDLdoFQ23ucJLEuVH59tug/SIsJuMFjGkey/qTEDHPa/7/O8hoYfy7t4pJEZtC0u\n QkbziYGuA/pmkSMj7ezxt15v+pK3dCMAJF9vyEwHj3S67BV6B2LlOXYSdsDAQ7bDY3YS\n pOfg==","X-Gm-Message-State":"AOJu0Yy1T412esj7No5O2p/yK/dbVtVX3qSaQZwGBJnlrhurf7EHxUF0\n eudGhGpAugbBZ/f8W+qQ6dgRndN/K7fbngqnTHUejSkBpDRdwsENNEnlPyjMeezO5mkzYbtiTEQ\n DSB0q","X-Gm-Gg":"AeBDiesJAnUoUwOwTthKH8Q6DntdS0pQ6GR9b93PZcA7fIeB5h86XzFB0g98X02lYuo\n NFv7EKl30LYA+87v/zRo30NtL/16pGG5mFZVDpuYzjo7eEdi8ED3lt+CCIqegqvTYXQBEwJViYc\n jse+5KU/OUeGfyczdPzusCuwNTcQHrd+YzXhUvlodLJt71ztwdVAHg0VSqoqpK43Q2q2oD4JfCy\n Cmhb8o7JuOkuB4VRloPJeUse6VRzojqN7HYanqJ3sX1ULmJ8Aq4cVdcU2v2LvIzqUqq9D6DrNMI\n Nvof7c8YQJJUkJsOy7egwEmC9ckZ/u5Ao0dWqPQkpdcP4EDeHu9/rz0SjpHKmPlpQ2MqlZT0IMz\n OSdBzSMevaUjfgwUKzZbBsNJBWTeCcBcx96Se/8PVOsApE52qMyBlQ/6Aq3uXIMWAfaQqzDKqlx\n 53cR7O2ZWTNOTX2sDGYrUzScMWkT0vW5hcoCv1fS0PwT0LO3Ks46p0O2ez79nM+t+EL7/PHtMyh\n hEkh+6/HOQ0Oh1UZklp2TbTo8nwxGhNerVjYrCpaA==","X-Received":"by 2002:a05:600c:468c:b0:48a:56d5:16f2 with SMTP id\n 5b1f17b1804b1-48a56d5179amr386817155e9.7.1777294112716;\n Mon, 27 Apr 2026 05:48:32 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Subject":"[PULL 58/63] target/arm: make whpx use syndrome helpers for decode","Date":"Mon, 27 Apr 2026 13:47:32 +0100","Message-ID":"<20260427124738.966578-59-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260427124738.966578-1-peter.maydell@linaro.org>","References":"<20260427124738.966578-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Alex Bennée \n\nRather than open coding a bunch of shifts and masks we can use the\nsyndrome definitions. While we are at it assert it really is a\nEC_DATAABORT.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \nMessage-id: 20260422125250.1303100-19-alex.bennee@linaro.org\nSigned-off-by: Peter Maydell \n---\n target/arm/whpx/whpx-all.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex bbf0f6be96..4cfc7f9969 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -356,15 +356,16 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx)\n {\n uint64_t syndrome = ctx->Syndrome;\n \n- bool isv = syndrome & ARM_EL_ISV;\n- bool iswrite = (syndrome >> 6) & 1;\n- bool sse = (syndrome >> 21) & 1;\n- uint32_t sas = (syndrome >> 22) & 3;\n+ bool isv = FIELD_EX32(syndrome, DABORT_ISS, ISV);\n+ bool iswrite = FIELD_EX32(syndrome, DABORT_ISS, WNR);\n+ bool sse = FIELD_EX32(syndrome, DABORT_ISS, SSE);\n+ uint32_t sas = FIELD_EX32(syndrome, DABORT_ISS, SAS);\n uint32_t len = 1 << sas;\n- uint32_t srt = (syndrome >> 16) & 0x1f;\n- uint32_t cm = (syndrome >> 8) & 0x1;\n+ uint32_t srt = FIELD_EX32(syndrome, DABORT_ISS, SRT);\n+ uint32_t cm = FIELD_EX32(syndrome, DABORT_ISS, CM);\n uint64_t val = 0;\n \n+ assert(syn_get_ec(syndrome) == EC_DATAABORT);\n assert(!cm);\n assert(isv);\n \n","prefixes":["PULL","58/63"]}