{"id":2228889,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228889/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-54-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427124738.966578-54-peter.maydell@linaro.org>","date":"2026-04-27T12:47:27","name":"[PULL,53/63] target/arm: migrate gcs syndromes to registerfields","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"f40a18f8542727191050f191479d9a4c8ff86d67","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-54-peter.maydell@linaro.org/mbox/","series":[{"id":501642,"url":"http://patchwork.ozlabs.org/api/1.1/series/501642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501642","date":"2026-04-27T12:46:34","name":"[PULL,01/63] docs/system: add FEAT_AA32 and FEAT_AA64 to emulation list","version":1,"mbox":"http://patchwork.ozlabs.org/series/501642/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228889/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228889/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=p0BhjCFX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g43bt33dzz1yJX\n\tfor ; Mon, 27 Apr 2026 23:01:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHLW0-00038t-8r; Mon, 27 Apr 2026 08:56:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHLO7-0008D5-P8\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:36 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHLO4-0005lD-IQ\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:35 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488b8bc6bc9so73666275e9.3\n for ; Mon, 27 Apr 2026 05:48:28 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.27\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 05:48:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777294108; x=1777898908; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=Iut+4BJW06xHtE0SB3YNoS1Ssi4OQgnXbFlPQro7fSE=;\n b=p0BhjCFX3kUJcX62nWw1P9gSSM9pO2Ulh3LCYGabcPwe9KPv9cCKMU4+WJB0IR3yRf\n 9h/P7KUEktTCDP0NECcoiM9XPmJNXfplVXitVSE6R3wdA7t6NARL2HKHo347eM0Tme+/\n QzEZqB4G/Y+tCyCe46JH38/ih37B0YmZB7L6KS3ofQbu3szuQaPGleVxh2U7oKMzeFnB\n SBmARPA0wnq7oXm7uYNhDTSbJ4rXHTMaTOuIGvXPMxCZaKEsyIORkyHqy0dBRnXF0gMM\n 08gwYd324ppcz8O/ZG8PZ9w1yPup1TwqRRTXIvOnHH7J9WPFTHYipuusnE/gsB9C4Tr9\n FQQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777294108; x=1777898908;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=Iut+4BJW06xHtE0SB3YNoS1Ssi4OQgnXbFlPQro7fSE=;\n b=WPI9+3epEWe9mDGt73Nqd/MrFJ0InHzEb1sdl5x8+Gy1fLq5pcCZEtsbSbhFJ12h5B\n 3XB4s8dggKZUplNzT5SSrel+9UYJbcmw1EbT95UpzevkbYU63tW4hvusMLYZO4t5WDyV\n Lr0c7qIYPsLpfYT5FOnxovIRKesg0JknTZf2yYWyXw1k5YhLI1MwEzi5LK61IOavilpQ\n rEsrjo02qLYGWxkQa2esez+gJwT9+/Lpaoe61d2er1yX38+UT0/UkEt2rLOqEE6obfT9\n kuC5gqChiiAbh9N/b5mFJRVtqO57WGeo9KWb1AiMVSUIYY8UtPkB2reaiKRRsc7jio7x\n bNiw==","X-Gm-Message-State":"AOJu0YwT6/LtlR7h9R10ylQc/cGZEWucDKh9aTBizalTEfkGaUvBlBTI\n NACBTO4uc0RkZga5Haj2d8HB1gpo0RAdfM8xh2W9Mucw+zQ8JhhfeFKzLjaShbtazK1SEhxOr9Z\n 7dvue","X-Gm-Gg":"AeBDieuvg0yRxL65eRWtB0yova44Op91bU/ywCjUjimIdeOoXAI6jB04umvUX/idgxl\n 9x7qRjacb/Q2luG1Hwn780wbL8XDY5B6b9tJUoxXh9MDnY8jVDG38BcTiDPCt9ItJ6d+HS2ZphK\n vSVBNdIPQSyt5S+Ee/Bvxy8SYdSr4FyNAGOjh7hvZZaQ0ldjJ3fZwfZlxcoNO+cEOPQqno+TX47\n oz8gEjX2v4zXoztSGhpHO51VoZ0hNNHHH4cyMqofqO/TDqybTWUtWzsbLKZSQHGTfdcnfrbyrcS\n 3255K+t+wOMeVUUfHK0lxu2g2QbiXjENshIznWN1/A1FK/w0U9nY03x4VSnaYUoIfJw4iZdCHdR\n ajf/JK4wKvDNhDhKtQtYHXQSfMb9XmaQgyxKArDDgFe/b3BZ4jp5gtsiR83PXXA5uBdmLnMTNJJ\n 5w1Ripe0u5Y1ycHYSWLHf216ACfatyQyDR+WjxriFOH1zmcknGXGzpgcaTD9chQTcG7kV5Vbad7\n 8SwLU+AD2Xj6/F/w8naKWltJ+8JcQ56dSyPDWJexw==","X-Received":"by 2002:a05:600c:3b14:b0:48a:52d9:54ab with SMTP id\n 5b1f17b1804b1-48a52d95604mr449758515e9.30.1777294107883;\n Mon, 27 Apr 2026 05:48:27 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Subject":"[PULL 53/63] target/arm: migrate gcs syndromes to registerfields","Date":"Mon, 27 Apr 2026 13:47:27 +0100","Message-ID":"<20260427124738.966578-54-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260427124738.966578-1-peter.maydell@linaro.org>","References":"<20260427124738.966578-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Alex Bennée \n\nTweak arg names to make it clear raddr is the data address register\nnumber.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \nMessage-id: 20260422125250.1303100-14-alex.bennee@linaro.org\nSigned-off-by: Peter Maydell \n---\n target/arm/syndrome.h | 39 +++++++++++++++++++++++++++++++++------\n 1 file changed, 33 insertions(+), 6 deletions(-)","diff":"diff --git a/target/arm/syndrome.h b/target/arm/syndrome.h\nindex 65d0de63a8..7ff8c30e2b 100644\n--- a/target/arm/syndrome.h\n+++ b/target/arm/syndrome.h\n@@ -690,21 +690,48 @@ static inline uint32_t syn_pcalignment(void)\n return res;\n }\n \n+/*\n+ * ISS encoding for a GCS exception\n+ *\n+ * Field validity depends on EXTYPE\n+ */\n+FIELD(GCS_ISS, IT, 0, 5)\n+FIELD(GCS_ISS, RN, 5, 5) /* only for non EXLOCK exceptions */\n+FIELD(GCS_ISS, RADDR, 10, 5) /* only for GCSSTR/GCSSTTR traps */\n+FIELD(GCS_ISS, EXTYPE, 20, 4)\n+\n static inline uint32_t syn_gcs_data_check(GCSInstructionType it, int rn)\n {\n- return ((EC_GCS << ARM_EL_EC_SHIFT) | ARM_EL_IL |\n- (GCS_ET_DataCheck << 20) | (rn << 5) | it);\n+ uint32_t res = syn_set_ec(0, EC_GCS);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, GCS_ISS, EXTYPE, GCS_ET_DataCheck);\n+ res = FIELD_DP32(res, GCS_ISS, RN, rn);\n+ res = FIELD_DP32(res, GCS_ISS, IT, it);\n+\n+ return res;\n }\n \n static inline uint32_t syn_gcs_exlock(void)\n {\n- return (EC_GCS << ARM_EL_EC_SHIFT) | ARM_EL_IL | (GCS_ET_EXLOCK << 20);\n+ uint32_t res = syn_set_ec(0, EC_GCS);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, GCS_ISS, EXTYPE, GCS_ET_EXLOCK);\n+\n+ return res;\n }\n \n-static inline uint32_t syn_gcs_gcsstr(int ra, int rn)\n+static inline uint32_t syn_gcs_gcsstr(int raddr, int rn)\n {\n- return ((EC_GCS << ARM_EL_EC_SHIFT) | ARM_EL_IL |\n- (GCS_ET_GCSSTR_GCSSTTR << 20) | (ra << 10) | (rn << 5));\n+ uint32_t res = syn_set_ec(0, EC_GCS);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, GCS_ISS, EXTYPE, GCS_ET_GCSSTR_GCSSTTR);\n+ res = FIELD_DP32(res, GCS_ISS, RADDR, raddr);\n+ res = FIELD_DP32(res, GCS_ISS, RN, rn);\n+\n+ return res;\n }\n \n static inline uint32_t syn_serror(uint32_t extra)\n","prefixes":["PULL","53/63"]}