{"id":2228865,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-39-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427124738.966578-39-peter.maydell@linaro.org>","date":"2026-04-27T12:47:12","name":"[PULL,38/63] hw/arm/raspi4b: NOP all DTB nodes when removing unimplemented devices","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"1de1128f7e3ceca3aa560861394aaf0d451eddd0","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-39-peter.maydell@linaro.org/mbox/","series":[{"id":501642,"url":"http://patchwork.ozlabs.org/api/1.1/series/501642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501642","date":"2026-04-27T12:46:34","name":"[PULL,01/63] docs/system: add FEAT_AA32 and FEAT_AA64 to emulation list","version":1,"mbox":"http://patchwork.ozlabs.org/series/501642/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228865/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228865/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=iCdMYgOb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g43WK0pvsz1yHv\n\tfor ; Mon, 27 Apr 2026 22:57:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHLUP-0007IM-P0; Mon, 27 Apr 2026 08:55:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHLNw-00087F-QZ\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:31 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHLNq-0005hZ-NP\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:21 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso107050295e9.1\n for ; Mon, 27 Apr 2026 05:48:16 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.14\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 05:48:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777294095; x=1777898895; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=A6daU2nmrlZ4Sa/74iSVs+RucwjBTPr7uTOaBH+QKpw=;\n b=iCdMYgObo3xF0lZpDBP//5SL40cNVWkV6tDq9ljLTIL5NxL0WucDYUpkfsVovrUltx\n dU14fk8Oak9G3KgrhOb+nX3gI3gslL6PItu6bB6QkCkFCYLGYKaDESNbw9ntWKrjDeOC\n kyefeNm1az1f6XHmqJI0LSj97wxPbXuw6Yrdpg8XeWkvq6s65mgY7VdkQgTxY61XK5PW\n AO7oLqbpqTfPF4hACyAKmW9YCkNyvJvEPtnJtT8mgu/fm3pBYSAx6TMDrL3O2160wkMD\n 1eTyaSo2wEHn/QqE64rZqnR8kmV0tCjUt+WYqSfjfigdMQU3oQfzYbVFW8jwqRAJ4YR6\n VcHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777294095; x=1777898895;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=A6daU2nmrlZ4Sa/74iSVs+RucwjBTPr7uTOaBH+QKpw=;\n b=H5e5GmNgf8SyWfIuv5qHHz7F3B8CVWdRQ7U1vMKwiaGMupWYDM4VJ8QIvacEr+ngfB\n NxAj7oBVnUfwMm9FyPsJ/KwuBY7Edet+gAE1TgekQoK70Je09v4Kjv85RUq4d3rJtM7G\n m18HfEO8gxF71fILQS3fhv84awdyNppBSGF2S7Bm07lE0e8P6gNpbtJbzZN7GlJDbBzb\n +dQU3N0nM0nsl9flD+hmlgF5VRvEBJPUlntgJuKyf/PZF9c0eSfcb4ks5fyBfvugR+bg\n vMZPpzZZzTsEYgPhhwSJWe2Iu5SwUZwy8mVEXu0kHxlOyZCh8qTc8LRHigAtkyasCOHQ\n MnhA==","X-Gm-Message-State":"AOJu0YxQ9/bse8MsJdKHZhk1rDOMQLW1jN2fcVd01ZCKOgkQ7f6yVwn9\n iTr5z7RFVH8NQCiFKpk4UYy3PPnM9+ajXK+9nD9mNhGbey77jDd9aXtHzMYylVkEBx40cuE1rf+\n 6kK8I","X-Gm-Gg":"AeBDieucu0MxJAhxDeRj8DqhYR7Ce1SnRQ/B9WpbCf+PE/9/U/KjiDI6n5swx/efH9f\n LBJBRCVHlm6napB4LNtFxowshV0B42BhcT4X0MF28rI604EFJIZJdtCyh3F5bTrFH/xDLgkURro\n bSgnngwSATXGInwlIKRr8ULGM+Eudbrfbklv+wuZ7ZnfwGMfUT6Ry1Y2xyzRP7mltgtZem2TH6i\n gbQs2KC+/mtcYkj2iiwoIoPS87c9r8g00zni1KUMrqyYz39MFwSJnDirYwmuDAYrvkcg+MYXEYC\n 3uOla8AWnJWZaSAzOk6k4KxUo4Q9GVU6mchNUgJzpfRWr1EQnl9kk+W2HFJGKfY1aQOgSHpNvEZ\n 6VBedWJNpAsd8mhxS0HZbJ72+Q/S8wps6njU48+ts6RbIkoNYULkmCnQsXwGzII2ENXorswCsEP\n C8N7MGTnqWersIYKaejuCn1Qdo+fdmKwyGOPBHf2Z5d1nZlpahQ5FmtTrwGq1KnzXHs92Pj+Sep\n f/f1Jvc9QhtHRdIiPrU7BDnW/L8P4mWg8DM2mZQoA==","X-Received":"by 2002:a05:600c:4e4f:b0:488:ab37:b442 with SMTP id\n 5b1f17b1804b1-488fb793c6bmr620329115e9.28.1777294095029;\n Mon, 27 Apr 2026 05:48:15 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Subject":"[PULL 38/63] hw/arm/raspi4b: NOP all DTB nodes when removing\n unimplemented devices","Date":"Mon, 27 Apr 2026 13:47:12 +0100","Message-ID":"<20260427124738.966578-39-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260427124738.966578-1-peter.maydell@linaro.org>","References":"<20260427124738.966578-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Osama Abdelkader \n\nfdt_node_offset_by_compatible(fdt, -1, compat) only finds the first match.\nIf the blob has more than one node with the same compatible string, extra\nnodes will remain active. Remove all the matching nodes, using the same\nloop as imx8mp-evk.c does for this purpose.\n\nSigned-off-by: Osama Abdelkader \nMessage-id: 20260420162114.308519-1-osama.abdelkader@gmail.com\nReviewed-by: Peter Maydell \nSigned-off-by: Peter Maydell \n---\n hw/arm/raspi4b.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/arm/raspi4b.c b/hw/arm/raspi4b.c\nindex 3eeb8f447e..06aeb8db01 100644\n--- a/hw/arm/raspi4b.c\n+++ b/hw/arm/raspi4b.c\n@@ -72,12 +72,14 @@ static void raspi4_modify_dtb(const struct arm_boot_info *info, void *fdt)\n \n for (int i = 0; i < ARRAY_SIZE(nodes_to_remove); i++) {\n const char *dev_str = nodes_to_remove[i];\n+ int offset;\n \n- int offset = fdt_node_offset_by_compatible(fdt, -1, dev_str);\n- if (offset >= 0) {\n- if (!fdt_nop_node(fdt, offset)) {\n- warn_report(\"bcm2711 dtc: %s has been disabled!\", dev_str);\n+ offset = fdt_node_offset_by_compatible(fdt, -1, dev_str);\n+ while (offset >= 0) {\n+ if (fdt_nop_node(fdt, offset) == 0) {\n+ warn_report(\"bcm2711 dtb: %s has been disabled!\", dev_str);\n }\n+ offset = fdt_node_offset_by_compatible(fdt, offset, dev_str);\n }\n }\n \n","prefixes":["PULL","38/63"]}