{"id":2228852,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228852/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-35-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427124738.966578-35-peter.maydell@linaro.org>","date":"2026-04-27T12:47:08","name":"[PULL,34/63] target/arm/cpu64: Mitigate migration failures due to spurious TCR_EL1, PIRE0_EL1 and PIR_EL1","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"a78464ae25a22deb3a1f95e2d25c578eb59a069c","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-35-peter.maydell@linaro.org/mbox/","series":[{"id":501642,"url":"http://patchwork.ozlabs.org/api/1.1/series/501642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501642","date":"2026-04-27T12:46:34","name":"[PULL,01/63] docs/system: add FEAT_AA32 and FEAT_AA64 to emulation list","version":1,"mbox":"http://patchwork.ozlabs.org/series/501642/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228852/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228852/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=q58AQbzB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g43Tq45KXz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 22:56:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHLPv-00019e-Uw; Mon, 27 Apr 2026 08:50:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHLNw-00087E-QS\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:31 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHLNp-0005ga-24\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:19 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso109080595e9.2\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 05:48:12 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.10\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 05:48:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777294091; x=1777898891; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=0v/Sp1N38U1xnn6NTkNVlcM8HldzbtGaI2x8xgpzJPE=;\n b=q58AQbzBUCJff8HgLzSujIxRSMNwLrnxauYuYbeY1R9Uj/dKz1wgnvj3Bjd9cuDO8X\n OtG8Gtfmdd1IvyvG9DvOd/Bp+INziMtcZJZuR4dgZvzgg8/wuhggDz6wayq65qcRSmis\n lnV8O76/F1UG5KxYTzKj8gMgz0GJsuqOTAP4tTxC+2jM8ndt1kNMznmE79HOcow98fLz\n KkOkmMJb25RIv2RDcK+9cK+4fPU2Yw5fDomeeLe5MmLz3V+NR/64OPre0SlHNrJfYcUZ\n 8oboE/GqQgo7Sb0GRKVx0PgtOQ0kZbTyOE5ctsQy/+8CIE6jHbZFtdsspsMLKcUYOD4Z\n 168g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777294091; x=1777898891;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=0v/Sp1N38U1xnn6NTkNVlcM8HldzbtGaI2x8xgpzJPE=;\n b=nOTHl9RIkPQVFQRk2x1mtVeDRgXUM7G+zSnKtbE5X+ToNteZx+I/10fGS0NNcGfHu2\n fMbzJF29MHn9wkRAsToBZOnTREE0LtUzGFDNQi2g5ME4UHPZ7+RMZ7Vm9qFPm1o7jmI6\n ECGA2OgJ3BMncBCrXrrihl7id0qRQbCaNo45iB6X5GW52YM8Ec/XrjA6gK9eGGA5ijck\n G7iJbQfwlnDkUIK8UZ4WnjSAsNnaD1VrHlLeCtAmZXln1mXH7nrTq1cWLPPkqPn5cOdh\n 7Nd6BgRCMftpgPPIrAtpKOlhR+JZO7TgAkIDzBAxgewHEueDBac/RdawkMn0Z0ifLsFk\n DY/Q==","X-Gm-Message-State":"AOJu0YzwtUJFInI6Md0poZEZ9Nk3UB2kdF3uzGEtOy0zzijTlK5crT1t\n h6FqSz0+syEIgV9duRE6lydNDUHa6rkTnnt1fpY9kHjL0fmOMsiQCW2BLrhOn7KrcNQrQLhhszz\n OqZ4N","X-Gm-Gg":"AeBDieufoDs+Gcikl9jQBMR3a5yoNzTHxOAx4vf1hx/J/+jUQufGOADEdV9MJSMt8bC\n R8lL781NGPJ2Kwvl0it64tm3reI9fCG9e0sWbOXy4/Gz+ErhjoNXKszDNggl0aidlyQrh8uRtVI\n WQ6L4trrPvAj7pQYjeoIxLKXL3fOSVDD6ThGVCjQhus0a+GDVqdezjclBub+GQSBM+EaWYedyAz\n fAlUiTRkkI4URxqeoiqSFES5OAXDIlPoYgxTrpPe7o51dtABcJLefU2LIpthGJJvRgl45nqRsnP\n KuvnHmqrwemgHzGFr8X+quDxwRpoSe53TFEZ/iSlENPSfUdQMni10qWttg3cEORkNH3aiwwIl24\n stxN5du/+AzZzbW4bG6Gp2LBbF5zrSuJZn2sw0HAe/ZzFZjvBGnZC8GnIn3wotr2KT5MrD+RFVB\n eAZkIaXVPBivT+uxFBY+QKK9LpUr/GznKItUJGZJesDBJEsv1iDMKC4w5Oo4IPv1E9x/u7Jrqk/\n lci7cyKpXqmWWnpRO7yt5TJzzT6xTpvyhplQz6wKg==","X-Received":"by 2002:a05:600c:4f49:b0:489:1ff1:74df with SMTP id\n 5b1f17b1804b1-4891ff176bamr504250925e9.1.1777294091145;\n Mon, 27 Apr 2026 05:48:11 -0700 (PDT)","From":"Peter Maydell <peter.maydell@linaro.org>","To":"qemu-devel@nongnu.org","Subject":"[PULL 34/63] target/arm/cpu64: Mitigate migration failures due to\n spurious TCR_EL1, PIRE0_EL1 and PIR_EL1","Date":"Mon, 27 Apr 2026 13:47:08 +0100","Message-ID":"<20260427124738.966578-35-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260427124738.966578-1-peter.maydell@linaro.org>","References":"<20260427124738.966578-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Eric Auger <eric.auger@redhat.com>\n\nBefore linux v6.13 those registers were erroneously unconditionally\nexposed and this was fixed by commits:\n- 0fcb4eea5345 (\"KVM: arm64: Hide TCR2_EL1 from userspace when\n                 disabled for guests\")\n- a68cddbe47ef (\"KVM: arm64: Hide S1PIE registers from userspace\n                 when disabled for guests\")\nin v6.13.\n\nThis means if we migrate from an old kernel host to a >= 6.13 kernel\nhost, migration currently fails.\n\nDeclare cpreg migration tolerance for those registers.\n\nSigned-off-by: Eric Auger <eric.auger@redhat.com>\nReviewed-by: Sebastian Ott <sebott@redhat.com>\nReviewed-by: Peter Maydell <peter.maydell@linaro.org>\nMessage-id: 20260420140552.104369-5-eric.auger@redhat.com\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n target/arm/cpu64.c | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)","diff":"diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c\nindex d6feba220e..e7014022df 100644\n--- a/target/arm/cpu64.c\n+++ b/target/arm/cpu64.c\n@@ -810,6 +810,33 @@ static void aarch64_a53_initfn(Object *obj)\n     define_cortex_a72_a57_a53_cp_reginfo(cpu);\n }\n \n+#if defined(CONFIG_KVM)\n+static void kvm_arm_set_cpreg_mig_tolerances(ARMCPU *cpu)\n+{\n+    /*\n+     * Registers that may be in the incoming stream and not exposed\n+     * on the destination\n+     */\n+\n+    /*\n+     * TCR_EL1 was erroneously unconditionnally exposed before linux v6.13.\n+     * See commit 0fcb4eea5345 (\"KVM: arm64: Hide TCR2_EL1 from userspace\n+     * when disabled for guests\")\n+     */\n+    arm_register_cpreg_mig_tolerance(cpu, ARM64_SYS_REG(3, 0, 2, 0, 3),\n+                                     0, 0, ToleranceNotOnBothEnds);\n+    /*\n+     * PIRE0_EL1 and PIR_EL1 were erroneously unconditionnally exposed\n+     * before linux v6.13. See commit a68cddbe47ef (\"KVM: arm64: Hide\n+     * S1PIE registers from userspace when disabled for guests\")\n+     */\n+    arm_register_cpreg_mig_tolerance(cpu, ARM64_SYS_REG(3, 0, 10, 2, 2),\n+                                     0, 0, ToleranceNotOnBothEnds);\n+    arm_register_cpreg_mig_tolerance(cpu, ARM64_SYS_REG(3, 0, 10, 2, 3),\n+                                     0, 0, ToleranceNotOnBothEnds);\n+}\n+#endif\n+\n static void aarch64_host_initfn(Object *obj)\n {\n     ARMCPU *cpu = ARM_CPU(obj);\n@@ -822,6 +849,7 @@ static void aarch64_host_initfn(Object *obj)\n #endif\n \n #if defined(CONFIG_KVM)\n+    kvm_arm_set_cpreg_mig_tolerances(cpu);\n     kvm_arm_set_cpu_features_from_host(cpu);\n     aarch64_add_sve_properties(obj);\n #elif defined(CONFIG_HVF)\n","prefixes":["PULL","34/63"]}