{"id":2228827,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228827/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-41-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427124738.966578-41-peter.maydell@linaro.org>","date":"2026-04-27T12:47:14","name":"[PULL,40/63] hw/arm/fsl-imx6ul: Wire in the LCDIF device model","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"de258d00078f60bfd5d17045f8a81d5eb255731f","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.1/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-41-peter.maydell@linaro.org/mbox/","series":[{"id":501642,"url":"http://patchwork.ozlabs.org/api/1.1/series/501642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501642","date":"2026-04-27T12:46:34","name":"[PULL,01/63] docs/system: add FEAT_AA32 and FEAT_AA64 to emulation list","version":1,"mbox":"http://patchwork.ozlabs.org/series/501642/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228827/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228827/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Yxu27URy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g43NV6Gwwz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 22:51:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHLQC-00021f-01; Mon, 27 Apr 2026 08:50:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHLNz-00087h-1C\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:31 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHLNr-0005hu-Ng\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:25 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-4891c00e7aeso75998435e9.2\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 05:48:17 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.15\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 05:48:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777294097; x=1777898897; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=4MgWbP/9wmOy0VZTKjCnGxeHPzbsxi09y3T5/RRhIzE=;\n b=Yxu27URy5vlLhiZo3pHH8BeEGnyrw4lDlH/D+Vsk50cUqu1CZYy6IrMWONsPOrkIAr\n hlNwjbwMbHHZyrJGEiO5u3UivrkngLnXopPX1DV9+vr6XLKj/XpVkbf78N8ibLlcHoyo\n 9HApCNAKDpDRSAKFdqks9SQj7loY1s6vtxOVdXTX3HGVLVPQ8B5RmuazLF9aHejnteE9\n Jm+63lGU4kxDYf47013aj0lRBX9wp9fx43Vvx3STRfnLG0DsWgnfa368JHun5y8KFPwQ\n plgLbr5d3VZMV3o5OLp4trbgVTC5QVmjQNa54ESE1jFI02BfpCDSFKDq8issMdGMcm//\n KPew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777294097; x=1777898897;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=4MgWbP/9wmOy0VZTKjCnGxeHPzbsxi09y3T5/RRhIzE=;\n b=nUpDSy5KWz5Erpp2tF37eceOJsxRPfbcFVGNuVFskb+SD76QUeBhKoOtSItxZcravs\n o4ratrAWsKM6CsYnEYpa9ZUtZJIn8N6KvUHSmtzAGqmM/EdwrOyj4cxD6yxPjeIh/7yb\n VJZTKKHxFqc60hvkiZ2NjXYZgSxYDAOLNowm2Sh6HXRABMGAKD63r1Ak3WIw8H7D3uGl\n N9Enl4F/ICg1Q8A8nGy7NAoT2VjQ/CvU2xPEmlwRhARpO39R2egr7sTXcuKxiy5gL3vH\n IU4dPR53E+IpaJd+Uui1L/hEcGWUdOv7tpe+KUosBpi/uuOojQJSrutfNjjNa89euhpK\n boLA==","X-Gm-Message-State":"AOJu0Yw5ihKxXYsjJA6VsWH8ReaZiyHFj0vOyP55L7TGxjgg38o614zJ\n UV36Wx69WCsWEFDRYp6ORxeyrLCVHC9smlJmtHgChpoAE6KrkQsDUcW0UhtaFA4J2EDob7x4kNf\n iZMX2","X-Gm-Gg":"AeBDiesBM/VQuNGaCIN4vKOLaAitZoY5mkpvccCtY3PmafzIeg1AmDMPWG1ioir3tqQ\n pvlIoGw7dp+Hkdcsv2juW8CYJSlDJla6Rw0uIGslwlCPxdNhSrXg10BrESrkN8pUxg3+i7pufo/\n 0UpeP6bBfMivLKLPXS/F5iEPezt5wRwnpNdpyE7ChInlFXtsmfhnnXvK9Ndl+Spofl5TnmEq1RU\n 57i4dhokRRSoes6GALRwbp5xv0sRPYQ2mcy4fZOPPPp6f7klzUoBDwbzw6JXkRmklU7QX9Gbfpk\n 7N9thNfkLaaYshZWBgrk5vmbqWtepqpSUD3PXlYUlqsMCen1hCfuKN5jIjkTC0RcxRnHJQZLMgb\n Xn1wVohUeh+Pn7cm5QLWh7vO2aR3SzZUHqrHHLINJ9Tz0HuDO6uUs6usT7AgiEfEdAA8ZjYWaM+\n gZrRayGUgmno5TUdQAPhl3jOx+YGw1uMeDm2C5lYfqpVBI4NopirarYiAxjdHF179RMq3LCaL8k\n 9b3jQoqqJTYieS+1MORMeaVnkEO8RyO6yv0cJv9nnPXgVo8LEYf","X-Received":"by 2002:a05:600c:1907:b0:489:201c:dc46 with SMTP id\n 5b1f17b1804b1-489201cdf13mr418319805e9.12.1777294096712;\n Mon, 27 Apr 2026 05:48:16 -0700 (PDT)","From":"Peter Maydell <peter.maydell@linaro.org>","To":"qemu-devel@nongnu.org","Subject":"[PULL 40/63] hw/arm/fsl-imx6ul: Wire in the LCDIF device model","Date":"Mon, 27 Apr 2026 13:47:14 +0100","Message-ID":"<20260427124738.966578-41-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260427124738.966578-1-peter.maydell@linaro.org>","References":"<20260427124738.966578-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Yucai Liu <1486344514@qq.com>\n\nInstantiate LCDIF as a child object of the i.MX6UL SoC in init and\nrealize it in the SoC realize path before MMIO/IRQ hookup.\n\nAlso make FSL_IMX6UL select CONFIG_IMX6UL_LCDIF and map the LCDIF\nregion with a 16 KiB size to match the SoC memory map.\n\nSigned-off-by: Yucai Liu <1486344514@qq.com>\nMessage-id: 20260412110240.93116-3-yangyanglan718@gmail.com\nReviewed-by: Peter Maydell <peter.maydell@linaro.org>\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n hw/arm/Kconfig              |  1 +\n hw/arm/fsl-imx6ul.c         | 12 ++++++++++--\n include/hw/arm/fsl-imx6ul.h |  4 +++-\n 3 files changed, 14 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig\nindex b940af9345..c31752e83a 100644\n--- a/hw/arm/Kconfig\n+++ b/hw/arm/Kconfig\n@@ -656,6 +656,7 @@ config FSL_IMX6UL\n     imply I2C_DEVICES\n     select A15MPCORE\n     select IMX\n+    select IMX6UL_LCDIF\n     select IMX_FEC\n     select IMX_I2C\n     select IMX_USBPHY\ndiff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c\nindex 225e179126..1863558a0d 100644\n--- a/hw/arm/fsl-imx6ul.c\n+++ b/hw/arm/fsl-imx6ul.c\n@@ -19,6 +19,7 @@\n #include \"qemu/osdep.h\"\n #include \"qapi/error.h\"\n #include \"hw/arm/fsl-imx6ul.h\"\n+#include \"hw/display/imx6ul_lcdif.h\"\n #include \"hw/misc/unimp.h\"\n #include \"hw/usb/imx-usb-phy.h\"\n #include \"hw/core/boards.h\"\n@@ -136,6 +137,11 @@ static void fsl_imx6ul_init(Object *obj)\n         object_initialize_child(obj, name, &s->usb[i], TYPE_CHIPIDEA);\n     }\n \n+    /*\n+     * LCDIF\n+     */\n+    object_initialize_child(obj, \"lcdif\", &s->lcdif, TYPE_IMX6UL_LCDIF);\n+\n     /*\n      * SDHCIs\n      */\n@@ -656,8 +662,10 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp)\n     /*\n      * LCD\n      */\n-    create_unimplemented_device(\"lcdif\", FSL_IMX6UL_LCDIF_ADDR,\n-                                FSL_IMX6UL_LCDIF_SIZE);\n+    sysbus_realize(SYS_BUS_DEVICE(&s->lcdif), &error_abort);\n+    sysbus_mmio_map(SYS_BUS_DEVICE(&s->lcdif), 0, FSL_IMX6UL_LCDIF_ADDR);\n+    sysbus_connect_irq(SYS_BUS_DEVICE(&s->lcdif), 0,\n+                       qdev_get_gpio_in(gic, FSL_IMX6UL_LCDIF_IRQ));\n \n     /*\n      * CSU\ndiff --git a/include/hw/arm/fsl-imx6ul.h b/include/hw/arm/fsl-imx6ul.h\nindex f8f9c249a2..6205fe6b77 100644\n--- a/include/hw/arm/fsl-imx6ul.h\n+++ b/include/hw/arm/fsl-imx6ul.h\n@@ -33,6 +33,7 @@\n #include \"hw/net/imx_fec.h\"\n #include \"hw/usb/chipidea.h\"\n #include \"hw/usb/imx-usb-phy.h\"\n+#include \"hw/display/imx6ul_lcdif.h\"\n #include \"system/memory.h\"\n #include \"target/arm/cpu.h\"\n #include \"qom/object.h\"\n@@ -84,6 +85,7 @@ struct FslIMX6ULState {\n     IMX2WdtState       wdt[FSL_IMX6UL_NUM_WDTS];\n     IMXUSBPHYState     usbphy[FSL_IMX6UL_NUM_USB_PHYS];\n     ChipideaState      usb[FSL_IMX6UL_NUM_USBS];\n+    IMX6ULLCDIFState   lcdif;\n     MemoryRegion       rom;\n     MemoryRegion       caam;\n     MemoryRegion       ocram;\n@@ -143,7 +145,7 @@ enum FslIMX6ULMemoryMap {\n     FSL_IMX6UL_PXP_SIZE             = (16 * KiB),\n \n     FSL_IMX6UL_LCDIF_ADDR           = 0x021C8000,\n-    FSL_IMX6UL_LCDIF_SIZE           = 0x100,\n+    FSL_IMX6UL_LCDIF_SIZE           = (16 * KiB),\n \n     FSL_IMX6UL_CSI_ADDR             = 0x021C4000,\n     FSL_IMX6UL_CSI_SIZE             = 0x100,\n","prefixes":["PULL","40/63"]}