{"id":2228739,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228739/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427095747.1070244-7-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427095747.1070244-7-thuth@redhat.com>","date":"2026-04-27T09:57:43","name":"[PULL,06/10] tests/functional/qemu_test: Silence warnings from pylint in tesseract.py","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"df917e11e4c5d7a6032c0b8431a7a8e0286ba5e3","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/1.1/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427095747.1070244-7-thuth@redhat.com/mbox/","series":[{"id":501616,"url":"http://patchwork.ozlabs.org/api/1.1/series/501616/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501616","date":"2026-04-27T09:57:40","name":"[PULL,01/10] meson.build: Bump the minimum GCC version to v10.4","version":1,"mbox":"http://patchwork.ozlabs.org/series/501616/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228739/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228739/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LmGwmrCH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3zXz00pXz23Zb\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 19:58:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHIjT-0007uJ-KS; Mon, 27 Apr 2026 05:58:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1wHIjL-0007lC-0q\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 05:58:24 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1wHIjI-00087W-UG\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 05:58:18 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-sm1ka78GM3aL_57NMqH5hg-1; Mon,\n 27 Apr 2026 05:58:14 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 959C719560AF; Mon, 27 Apr 2026 09:58:13 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.44.48.146])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id E71503000C20; Mon, 27 Apr 2026 09:58:11 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777283896;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=V5Jxuf5erNRILrW2WQrAEsFYkX/kGsStLYVOgq23PFw=;\n b=LmGwmrCHhpt9xyF7R5/vd2u3IUNUmnLy1/XOj3xDEvrMiN7lCaMRCt7thdTIy1fPZKzo9Z\n syDYrgh4Ws06wlcBWDQSnOlcD/SFribHXNIuE5I+H49GkiBe0rD8GAWYU3KxuwWGd2o6lN\n NU6oR4Gs5zeKhW3XY4hUECAdxVN2t2Q=","X-MC-Unique":"sm1ka78GM3aL_57NMqH5hg-1","X-Mimecast-MFC-AGG-ID":"sm1ka78GM3aL_57NMqH5hg_1777283893","From":"Thomas Huth <thuth@redhat.com>","To":"Stefan Hajnoczi <stefanha@redhat.com>","Cc":"qemu-devel@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","Subject":"[PULL 06/10] tests/functional/qemu_test: Silence warnings from pylint\n in tesseract.py","Date":"Mon, 27 Apr 2026 11:57:43 +0200","Message-ID":"<20260427095747.1070244-7-thuth@redhat.com>","In-Reply-To":"<20260427095747.1070244-1-thuth@redhat.com>","References":"<20260427095747.1070244-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Thomas Huth <thuth@redhat.com>\n\nPylint complains:\n\n tesseract.py:1:0: C0114: Missing module docstring (missing-module-docstring)\n tesseract.py:12:0: C0116: Missing function or method docstring (missing-function-docstring)\n tesseract.py:15:11: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)\n tesseract.py:12:30: W0613: Unused argument 'tesseract_args' (unused-argument)\n\nThus add the missing bits and remove the unused tesseract_args argument.\nWhile we're at it, also add a SPDX identifier instead of the weird three\ndots at the beginning of the file, and drop the license boilerplate text.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Thomas Huth <thuth@redhat.com>\nMessage-ID: <20260422071145.244820-1-thuth@redhat.com>\n---\n tests/functional/qemu_test/tesseract.py | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)","diff":"diff --git a/tests/functional/qemu_test/tesseract.py b/tests/functional/qemu_test/tesseract.py\nindex 862faec2d2e..9d98181cb45 100644\n--- a/tests/functional/qemu_test/tesseract.py\n+++ b/tests/functional/qemu_test/tesseract.py\n@@ -1,19 +1,21 @@\n-# ...\n+# SPDX-License-Identifier: GPL-2.0-or-later\n #\n # Copyright (c) 2019 Philippe Mathieu-Daudé\n-#\n-# This work is licensed under the terms of the GNU GPL, version 2 or\n-# later. See the COPYING file in the top-level directory.\n+'''\n+Tesseract is an program for doing Optical Character Recognition (OCR),\n+which can be used in the tests to extract text from screenshots.\n+'''\n \n import logging\n from subprocess import run\n \n \n-def tesseract_ocr(image_path, tesseract_args=''):\n+def tesseract_ocr(image_path):\n+    ''' Run the tesseract OCR to extract text from a screenshot '''\n     console_logger = logging.getLogger('console')\n     console_logger.debug(image_path)\n     proc = run(['tesseract', image_path, 'stdout'],\n-               capture_output=True, encoding='utf8')\n+               capture_output=True, encoding='utf8', check=False)\n     if proc.returncode:\n         return None\n     lines = []\n","prefixes":["PULL","06/10"]}