{"id":2228695,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228695/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-30-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-30-philmd@linaro.org>","date":"2026-04-27T08:07:35","name":"[v4,29/32] target/sparc: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"233a83f8e92067cf71d073aca2304f3123f9886a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-30-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228695/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228695/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bvnnCjyH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x9s0K5Bz1yJs\n\tfor ; Mon, 27 Apr 2026 18:12:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH3f-00019T-2f; Mon, 27 Apr 2026 04:11:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH3X-0000uJ-1S\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:11:05 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH3U-0002p3-Gf\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:11:02 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488ab2db91aso140724925e9.3\n for ; Mon, 27 Apr 2026 01:10:59 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc10777csm877418125e9.8.2026.04.27.01.10.57\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277459; x=1777882259; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=YR1bIQJaEN4irJmFXMTH708rYFQjSQ11tGcPtx2WYz4=;\n b=bvnnCjyHdAL2b6drpW1Ch8n0UAYyR7BDi9uRmMJxfuSzpzqJ7mUePtEFehDl3Rw+0Z\n FPEfL1Ni46Q1m3854+mz7aiepOJMg2ugDXNpcWO0irlAXJV6s5kW5/0isV7wtC2xJl9s\n o7AcCn7OEJvXiUMa7GbaIsv7sOM3OMecnbqCaPcxV3yfxgAhOZBWwS8mFgNQjMV8HNho\n xoPsrc1H7zCKMtcOlAaz8RsNgIhytfx++aOLYAcJsQeBpvC7aigO02t54AUAPW6TO6UP\n Js9QHSiobCuvTLP18ocwJ3oqIkN+fYG/zZjk9fu0uZHAucHm7/bwB2ZOcM4iXdKDHkhn\n 4WVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277459; x=1777882259;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=YR1bIQJaEN4irJmFXMTH708rYFQjSQ11tGcPtx2WYz4=;\n b=VmrAllFEtaDfmPFKCgJ9pd94Ysd2nfxNsY99x5yiJWY6mHOyrrrbGnuBF6U21z8xTy\n fXFpAigY638ayTeR0xznw4uhk1rxBfJHygt+vwTs0SMgJtEEvu0cSs1W3Ajq1e/tKmdv\n grNMfkdVY9raF9g5ccxqu/cWvYW3Mf4kTSUX4xFN+y1lJ7a7750+/asrmY+rVgTQxrbx\n VsrCHBr88N6beg0LCMy+gGa/ryhOYk6DycZF7swH3wBHaA21RHpSNKCIumx2a/tnO+7e\n Cs88HVj9Iag6oGSuuK+tAdfi0/MEBudLOhfJ9NaVIJW8Vg/BXXELt+hIFoK6xdNm1AW6\n Tmjw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+QjRij0PCOIwCXfpt+bPNoZnRgqFlOnN96aEk+xiLumKYfsw2rGNOA/4QksFkIUttpdixgAKDjp/ov@nongnu.org","X-Gm-Message-State":"AOJu0Yw8EiRRZVxhDpFA43Q02qkFywklxRvm5tfiRh5wFe0xqS0WiK+A\n 5NJfrDp4lB8D0L7bfQikAt7hxZwk87SGPlONBiKiN64J7XSXXg7//NtphHxJVYNx14Sp1fW9uZX\n M9tPtLBg=","X-Gm-Gg":"AeBDiesgCPn9pw8zsWVLhtbsZNsIYzG6EWNlSzYGvL4BA3NT0INe5Aj8Q4oUgRLl+Yp\n zRtFcA2GwMKaDvi/TT6FzVkyiwd+RRaaFphNvG/dzV9ZKwB9MX8Av2dDD93ei6vgk04nAmi7qY6\n oFoaW86tzyzLV6aPibpIa0ud9g8scX3Tusk75h0dbWRbuPsq7BsC4KcDFD5Gih3S+X0KqSmOBRr\n ior2MTGCassVLYRsg0pvXFKbzmF4v/FPPGekZi7MM8CDduMvkSq34FeSnS1Ev9TUdLJPgfcvr4y\n tfbI7Sx61cB9PJBtnUyqPKiphkPe3z5UYDSufeWWX6qiX8Sv/vVZTBHACMXPK4DJR4pEPZQYao0\n lTHInWgiSWr018PhDU5gy493tpv2dxE4Q8PwsYA2GE81Vo7NQNSgElfv7hOBVO9rfSQ4tQBLSZh\n Ln3qWPa4L0/zKFRUG3ZG0hq/w5HFUKeX2uoVgfuvw9bRWvUU2dccsN9V+8dYfDThkz2Pf8Rey+Y\n y04dvgEKfg=","X-Received":"by 2002:a05:600c:4fd1:b0:488:78f2:6b0 with SMTP id\n 5b1f17b1804b1-488fb78ede0mr591820695e9.29.1777277458736;\n Mon, 27 Apr 2026 01:10:58 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 29/32] target/sparc: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs","Date":"Mon, 27 Apr 2026 10:07:35 +0200","Message-ID":"<20260427080738.77138-30-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Restrict sparc64_monitor_defs[] to cpu.c, register it\nas SysemuCPUOps::monitor_defs hook (taking care to not\nregister it on 32-bit SPARC target), allowing to remove\nthe target_monitor_defs() method.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n target/sparc/cpu.c | 19 +++++++++++++++++++\n target/sparc/monitor.c | 18 ------------------\n 2 files changed, 19 insertions(+), 18 deletions(-)","diff":"diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c\nindex 77046104284..c6989229da6 100644\n--- a/target/sparc/cpu.c\n+++ b/target/sparc/cpu.c\n@@ -993,12 +993,31 @@ static const Property sparc_cpu_properties[] = {\n };\n \n #ifndef CONFIG_USER_ONLY\n+\n+#ifdef TARGET_SPARC64\n+#include \"monitor/hmp.h\"\n+\n+static const MonitorDef sparc64_monitor_defs[] = {\n+ { \"asi\", offsetof(CPUSPARCState, asi) },\n+ { \"pstate\", offsetof(CPUSPARCState, pstate) },\n+ { \"cansave\", offsetof(CPUSPARCState, cansave) },\n+ { \"canrestore\", offsetof(CPUSPARCState, canrestore) },\n+ { \"otherwin\", offsetof(CPUSPARCState, otherwin) },\n+ { \"wstate\", offsetof(CPUSPARCState, wstate) },\n+ { \"cleanwin\", offsetof(CPUSPARCState, cleanwin) },\n+ { NULL },\n+};\n+#endif\n+\n #include \"hw/core/sysemu-cpu-ops.h\"\n \n static const struct SysemuCPUOps sparc_sysemu_ops = {\n .has_work = sparc_cpu_has_work,\n .get_phys_page_debug = sparc_cpu_get_phys_page_debug,\n .legacy_vmsd = &vmstate_sparc_cpu,\n+#if defined(TARGET_SPARC64)\n+ .monitor_defs = sparc64_monitor_defs,\n+#endif\n };\n #endif\n \ndiff --git a/target/sparc/monitor.c b/target/sparc/monitor.c\nindex 99abddbf1e0..36f3d8d58e9 100644\n--- a/target/sparc/monitor.c\n+++ b/target/sparc/monitor.c\n@@ -37,21 +37,3 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n }\n dump_mmu(env1);\n }\n-\n-const MonitorDef monitor_defs[] = {\n-#ifdef TARGET_SPARC64\n- { \"asi\", offsetof(CPUSPARCState, asi) },\n- { \"pstate\", offsetof(CPUSPARCState, pstate) },\n- { \"cansave\", offsetof(CPUSPARCState, cansave) },\n- { \"canrestore\", offsetof(CPUSPARCState, canrestore) },\n- { \"otherwin\", offsetof(CPUSPARCState, otherwin) },\n- { \"wstate\", offsetof(CPUSPARCState, wstate) },\n- { \"cleanwin\", offsetof(CPUSPARCState, cleanwin) },\n-#endif\n- { NULL },\n-};\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return monitor_defs;\n-}\n","prefixes":["v4","29/32"]}